From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6BC1A04C0; Tue, 6 Oct 2020 23:26:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2BEF411A4; Tue, 6 Oct 2020 23:26:03 +0200 (CEST) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id F3822160 for ; Tue, 6 Oct 2020 23:26:00 +0200 (CEST) Received: by mail-ot1-f68.google.com with SMTP id f10so235634otb.6 for ; Tue, 06 Oct 2020 14:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T8VEH7+2n+mz4mRMtM5DXc3GqRicigPUqd05rRWHjNw=; b=fWolT17/BVOo4Ed6LLfytiNfdiV8bXa1O5wO8BEQKDlPPUp1doBfs3Gc0waqdxgHVk aA9h8BOqJOTbG8pplnBoUgz8Lyq6OvYfMkLlVNOtDDBfkiLMnkFpvsZ3FQNMErUIK7oZ Q0cOz/b9SkQm1qktlN3UDBZ3lqExU1KvDXZ7A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T8VEH7+2n+mz4mRMtM5DXc3GqRicigPUqd05rRWHjNw=; b=kH55mopzUPLY35uFcK+Pd1qU6Ydy7/+RUC8KKT+EMoySgXnS/Op6a6Cz7X/bkcD9hm 5G+VwPPxGzAPvnITXswcbIaVfPky85+x1k1QVUxuTN9PWuaGf7SrRa7VRflvXk8mR5nx T8tYQYAuf6KUmRuvzWuR8MXqXmz5+o1Lxrlscx7rIpexUk7juA8PtH3TGfnI5ZhMLqth NgyKzdtNGKwD9DA34uj/8G/WF1PXRFsdGsRDGbLBzZB8DpJQR/I4YUSlZmRhu7lZgI27 4/kTYdWNn7Bik6YMguHP8nT/O6uPjcaeX9pT39xkt+0h8p3bi7UUPPVyp3UJkYhpxNeQ EFOQ== X-Gm-Message-State: AOAM533Q0I8D3z+8tJY+6pEcTD0e7+hbkyBw8/1Hzu8db/umjPH5FlZ+ Lfk8YANpQgrZnDP8jtV3j+M3Rz/8CMNFEKD++/QKbw== X-Google-Smtp-Source: ABdhPJwUvot1AY5uoQxO+Fk3lG5f5UqTtDlwaF21dtXJhpr2eJXp3D2zlP/FyBxr6RWgmff3FsTWK9lTvJHtfHljN/o= X-Received: by 2002:a9d:1909:: with SMTP id j9mr4363735ota.283.1602019560263; Tue, 06 Oct 2020 14:26:00 -0700 (PDT) MIME-Version: 1.0 References: <20201006160156.32228-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20201006160156.32228-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Tue, 6 Oct 2020 14:25:44 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix link update op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 6, 2020 at 8:47 AM Kalesh A P wrote: > > From: Kalesh AP > > 1. When port is stopped, we can forcibly set the link status for the > device to down. > 2. VFs and MH PFs do not have the privilege to bring the link down. > As a result driver prints "Link Up" when port is stopped. > 3. When driver receives link status/speed/config async event from fw, > driver invokes bnxt_link_update() with exp_link_status as ETH_LINK_UP. > This is not logically correct as the async event could be for Link up > or link down or for speed change. > > Fixes: 074cacb9907a ("net/bnxt: fix link during port toggle") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Reviewed-by: Ajit Kumar Khaparde Patch applied to dpdk-next-net-brcm. Thanks