From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BEF2427F7; Tue, 21 Mar 2023 14:58:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E2DC410D1; Tue, 21 Mar 2023 14:58:18 +0100 (CET) Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by mails.dpdk.org (Postfix) with ESMTP id 9979C40A7F for ; Tue, 21 Mar 2023 14:58:16 +0100 (CET) Received: by mail-pf1-f182.google.com with SMTP id fd25so9037537pfb.1 for ; Tue, 21 Mar 2023 06:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1679407096; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=4cWxHugDLWi8p4C0f7ibt1xVHyFAi3Do5vzvW/Jny2o=; b=XJNq7Pm6AZRRhUGwV9UFPhNbXuqc8MOVpsRngTYm8lpP0GK/vp9g5wotN5GElXWLV0 PWxWiPrtNC25wN2N30kidAUkYX8xpDG9m9qNAQYrEmFIbcpPL3uBMTIQRLo/zFECluLc Sp3eLjhiBjsReADxUQ5x6iDbZXFi6Va8LXh90= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679407096; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4cWxHugDLWi8p4C0f7ibt1xVHyFAi3Do5vzvW/Jny2o=; b=Gn2/86UAz8x3I9S0ZRoDXyRZhkuevm9E8OZSF7OAVTNPXCrBjzV+fGqfWDJMtfapYW xnG1rrmtDg9mbnJ+0PJkm18Kob3oj0BYiuhXYyup5tKzIB4uNypRQ2CmyIunk9yMx/5B GoACMfc6y9feGCGUmqmZyPZvReW5Eaj5ubRaP+EWjwYqOprROQ14+mQcEwIf0Xdkgoxq TTL0XDhkooUeo9o2eJpYir0tFf4cKTq+gR3hmEJa6AWFbN1Hc7RAMMJ2eeWY/2rrRD8V 5m4iU5PkGDuruwO3FKms1LwQ3P0mLD56xAeIhe+7k7D2mG+tSEVo2lcV10jf7lVhMHZP O3Mg== X-Gm-Message-State: AO0yUKWZH2wWOcmiGkhrG/vbje60jE6d0Taa4nroBSKnZdabEp89j9iA ezCG2QZ1hqqv7Oz42x5ZFvNVaxXBp4mqlGixuxh9nGLk+vblGxmu2qs= X-Google-Smtp-Source: AK7set+Ut7G/ZORsx3KnDhs94ZgxASqJWl1c9WwHeqV83mFWd1ABYwph5YcR+86xczwARtJg43jHdIUz7nZwbeD2VwU= X-Received: by 2002:a05:6a00:218f:b0:622:c6ad:b373 with SMTP id h15-20020a056a00218f00b00622c6adb373mr1176095pfi.3.1679407095657; Tue, 21 Mar 2023 06:58:15 -0700 (PDT) MIME-Version: 1.0 References: <20230313200040.139415-1-davejo@cisco.com> In-Reply-To: <20230313200040.139415-1-davejo@cisco.com> From: Ajit Khaparde Date: Tue, 21 Mar 2023 06:57:59 -0700 Message-ID: Subject: Re: [PATCH] net/bnxt: limit max_vnics for CoS classification To: Dave Johnson , Ferruh Yigit Cc: somnath.kotur@broadcom.com, dev@dpdk.org Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000645afc05f7696fd0" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000645afc05f7696fd0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 13, 2023 at 1:01=E2=80=AFPM Dave Johnson wro= te: > > When using CoS classification the number of vnics is capped > to avoid unnecessary memzone allocations. > > Signed-off-by: Dave Johnson Acked-by: Ajit Khaparde Patch merged to dpdk-next-net-brcm. Thanks > --- > .mailmap | 1 + > drivers/net/bnxt/bnxt.h | 1 + > drivers/net/bnxt/bnxt_hwrm.c | 10 ++++++++-- > 3 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/.mailmap b/.mailmap > index 4018f0fc47..ae52428557 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -271,6 +271,7 @@ Dariusz Stojaczyk > Darren Edamura > Dave Burley > Dave Ertman > +Dave Johnson > David Binderman > David Bouyeure > David Christensen > diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h > index f6eaaeb470..48bd8f2418 100644 > --- a/drivers/net/bnxt/bnxt.h > +++ b/drivers/net/bnxt/bnxt.h > @@ -811,6 +811,7 @@ struct bnxt { > uint16_t max_l2_ctx; > uint16_t max_rx_em_flows; > uint16_t max_vnics; > +#define BNXT_MAX_VNICS_COS_CLASSIFY 8 > uint16_t max_stat_ctx; > uint16_t max_tpa_v2; > uint16_t first_vf_id; > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index 51e1e2d6b3..d86ac73293 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -902,7 +902,10 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp) > bp->max_l2_ctx =3D rte_le_to_cpu_16(resp->max_l2_ctxs); > if (!BNXT_CHIP_P5(bp) && !bp->pdev->max_vfs) > bp->max_l2_ctx +=3D bp->max_rx_em_flows; > - bp->max_vnics =3D rte_le_to_cpu_16(resp->max_vnics); > + if (bp->vnic_cap_flags & BNXT_VNIC_CAP_COS_CLASSIFY) > + bp->max_vnics =3D rte_le_to_cpu_16(BNXT_MAX_VNICS_COS_CLA= SSIFY); > + else > + bp->max_vnics =3D rte_le_to_cpu_16(resp->max_vnics); > PMD_DRV_LOG(DEBUG, "Max l2_cntxts is %d vnics is %d\n", > bp->max_l2_ctx, bp->max_vnics); > bp->max_stat_ctx =3D rte_le_to_cpu_16(resp->max_stat_ctx); > @@ -1211,7 +1214,10 @@ int bnxt_hwrm_func_resc_qcaps(struct bnxt *bp) > bp->max_l2_ctx =3D rte_le_to_cpu_16(resp->max_l2_ctxs); > if (!BNXT_CHIP_P5(bp) && !bp->pdev->max_vfs) > bp->max_l2_ctx +=3D bp->max_rx_em_flows; > - bp->max_vnics =3D rte_le_to_cpu_16(resp->max_vnics); > + if (bp->vnic_cap_flags & BNXT_VNIC_CAP_COS_CLASSIFY) > + bp->max_vnics =3D rte_le_to_cpu_16(BNXT_MAX_VNICS_COS_CLA= SSIFY); > + else > + bp->max_vnics =3D rte_le_to_cpu_16(resp->max_vnics); > bp->max_stat_ctx =3D rte_le_to_cpu_16(resp->max_stat_ctx); > bp->max_nq_rings =3D rte_le_to_cpu_16(resp->max_msix); > bp->vf_resv_strategy =3D rte_le_to_cpu_16(resp->vf_reservation_st= rategy); > -- > 2.35.6 > --000000000000645afc05f7696fd0 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDAzZWuPidkrRZaiw2zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDVaFw0yNTA5MTAwODE4NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEArZ/Aqg34lMOo2BabvAa+dRThl9OeUUJMob125dz+jvS78k4NZn1mYrHu53Dn YycqjtuSMlJ6vJuwN2W6QpgTaA2SDt5xTB7CwA2urpcm7vWxxLOszkr5cxMB1QBbTd77bXFuyTqW jrer3VIWqOujJ1n+n+1SigMwEr7PKQR64YKq2aRYn74ukY3DlQdKUrm2yUkcA7aExLcAwHWUna/u pZEyqKnwS1lKCzjX7mV5W955rFsFxChdAKfw0HilwtqdY24mhy62+GeaEkD0gYIj1tCmw9gnQToc K+0s7xEunfR9pBrzmOwS3OQbcP0nJ8SmQ8R+reroH6LYuFpaqK1rgQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUbrcTuh0mr2qP xYdtyDgFeRIiE/gwDQYJKoZIhvcNAQELBQADggEBALrc1TljKrDhXicOaZlzIQyqOEkKAZ324i8X OwzA0n2EcPGmMZvgARurvanSLD3mLeeuyq1feCcjfGM1CJFh4+EY7EkbFbpVPOIdstSBhbnAJnOl aC/q0wTndKoC/xXBhXOZB8YL/Zq4ZclQLMUO6xi/fFRyHviI5/IrosdrpniXFJ9ukJoOXtvdrEF+ KlMYg/Deg9xo3wddCqQIsztHSkR4XaANdn+dbLRQpctZ13BY1lim4uz5bYn3M0IxyZWkQ1JuPHCK aRJv0SfR88PoI4RB7NCEHqFwARTj1KvFPQi8pK/YISFydZYbZrxQdyWDidqm4wSuJfpE6i0cWvCd u50xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwM2Vrj 4nZK0WWosNswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIH2nsrvoQ0jRhtqjodpF BdzEF1sK5XBB8fqSs3r4JMNwMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTIzMDMyMTEzNTgxNlowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQCOVfViqcP0gzf9PkNl5QbCftzUZCyXOUyz++MW 0/lTTSYUBIBxeyoLjEWzzu/bgaPas0wkOb095cQG/1FwEXPBKwpoBlYxwUK83cRGrJ2M3L8kbPLE S4szRAoQ6GtNd9geZAuE1gKZSAJFQzPGRKrgt3zdBYOuyR7nJtc+G8ey4mT2p9fqVvAsmOQr7YSQ hiffKojPG/1QB4vzI1sC6+8DMOOsmbvxJC1c3t/deSbkDEnyzlLRv4wHBf9EyRKva7IJlLRxpMGY cLv1Dv/5jivFycRVfE7pM7n4bnWfrHb+SVS6Bp5L1JTLwCrLpnb24a5KjZwwgGiutw8EUV4mBn9P --000000000000645afc05f7696fd0--