From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by dpdk.org (Postfix) with ESMTP id A65C41B752 for ; Wed, 7 Feb 2018 00:27:42 +0100 (CET) Received: by mail-qk0-f195.google.com with SMTP id x127so4577089qkb.12 for ; Tue, 06 Feb 2018 15:27:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=nzxl+HEKaG3MiDY/nue+p/EMeyznSYgYYRvoTD89zww=; b=ASXgM+5xEnExH2KZZXDF78rsGNSENwCaiV3AfEX67CR+YZRORUlQXVInA/n5sT5yP8 g4/tuawAdPUmvGKuUndr6TMp6RTjja9+UYc6uhv2cxpA288CGsnC41oJdZjUc0gYQtcZ qLMgrP+LtzxpmqnAwXoct90LT95VgeiWEdawo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=nzxl+HEKaG3MiDY/nue+p/EMeyznSYgYYRvoTD89zww=; b=fK2BNDq1EljDfVzIYMxkCPm15R5Sz/Vkfixd0aCe6TTfAkBofYDMhC6maDDwlIHWsJ z/WJU+BEvr589NFlbLs76jyDqWKL4jy3PSbpyFrLAr4wMrFL17WaAOGNSN8CDbuvDgTW faXiVEFBrSAGdZDFgnO+6t0I1x107opu/+mmkzd8cpvqjKSOh0N2sFpHa/L+2IQYX2UZ 7+API/SBxo8U1dKErf6ALFGTuQCN7n3CxGwr5r96Khb92ru1xJlx3Ox/Hj3LU81YqYrd MlFHTFUNS6ATIKSBhZQ8TFMX68huXtIDypwfiEC/90wlF5TDwBhszyZP2DibHcBuLoJm XmgQ== X-Gm-Message-State: APf1xPAirgHnVVeOvKkiDjqC5vZjfGOXZBRWxXtBhyw6ELyOaQdNVcgR Y3tMohuoFGDIWK/UbAtPYCUDvzfDj3Vcluj2S/bYRg== X-Google-Smtp-Source: AH8x224KcufYHqDQuqr/rftXM+ZWGL/52b3mbPIs7uvP3LCSpc71D8yDn8rW7plzSB/7EhlGHvGDwXPvmuVYBY9Ipss= X-Received: by 10.55.138.134 with SMTP id m128mr6256149qkd.72.1517959662094; Tue, 06 Feb 2018 15:27:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.47.228 with HTTP; Tue, 6 Feb 2018 15:27:01 -0800 (PST) In-Reply-To: <20180206133931.23991-1-olivier.matz@6wind.com> References: <20180206133931.23991-1-olivier.matz@6wind.com> From: Ajit Khaparde Date: Tue, 6 Feb 2018 15:27:01 -0800 Message-ID: To: Olivier Matz Cc: dev@dpdk.org, Somnath Kotur , dpdk stable Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix Rx checksum flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Feb 2018 23:27:43 -0000 On Tue, Feb 6, 2018 at 5:39 AM, Olivier Matz wrote= : > Fix the Rx offload flags when the IP or L4 checksum is seen as incorrect > by the hardware. In this case, the proper value is PKT_RX_IP_CKSUM_BAD. > > PKT_RX_IP_CKSUM_NONE means that the checksum may be incorrect in the > packet headers, but the integrity of the IP header is verified. This is > mostly useful for virtual drivers. > > Fixes: 7ec39d8c524b ("net/bnxt: update status of Rx IP/L4 CKSUM") > Cc: stable@dpdk.org > > Signed-off-by: Olivier Matz > =E2=80=8BAcked-by: Ajit Khaparde =E2=80=8B > --- > > Hi Ajit, > > PKT_RX_IP_CKSUM_UNKNOWN is also a good candidate instead of > PKT_RX_IP_CKSUM_BAD. Please can you check? > =E2=80=8BThanks Oliver. Sure. I will take a look.=E2=80=8B Ajit > > Thanks > Olivier > > > > drivers/net/bnxt/bnxt_rxr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > index 9e70c8604..9b88a64bf 100644 > --- a/drivers/net/bnxt/bnxt_rxr.c > +++ b/drivers/net/bnxt/bnxt_rxr.c > @@ -475,12 +475,12 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt, > if (likely(RX_CMP_IP_CS_OK(rxcmp1))) > mbuf->ol_flags |=3D PKT_RX_IP_CKSUM_GOOD; > else > - mbuf->ol_flags |=3D PKT_RX_IP_CKSUM_NONE; > + mbuf->ol_flags |=3D PKT_RX_IP_CKSUM_BAD; > > if (likely(RX_CMP_L4_CS_OK(rxcmp1))) > mbuf->ol_flags |=3D PKT_RX_L4_CKSUM_GOOD; > else > - mbuf->ol_flags |=3D PKT_RX_L4_CKSUM_NONE; > + mbuf->ol_flags |=3D PKT_RX_L4_CKSUM_BAD; > > mbuf->packet_type =3D bnxt_parse_pkt_type(rxcmp, rxcmp1); > > -- > 2.11.0 > >