From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1828A04B5; Mon, 26 Oct 2020 05:09:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AD4A41E2B; Mon, 26 Oct 2020 05:09:42 +0100 (CET) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id 10B141D9E for ; Mon, 26 Oct 2020 05:09:40 +0100 (CET) Received: by mail-ot1-f68.google.com with SMTP id o14so6858200otj.6 for ; Sun, 25 Oct 2020 21:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rYzkh34t3Eal6jwsebgoYTiC1lGbQeLdIjjyGDTzG7M=; b=AQPvyrugPhHrqhYEl3wQYaoZUt+RpCVkdKkSWNPabg4f8FWOL+h/Aonu4Rf6aG+MkB rvBd4eJ/+jPftxAKYERpPkPZQvLgkLD3NZB6nKkZEYxE2a1sOoOuvYa8xeyuYfUrQ/cZ 9ww1Lx+vCEg4KFx4Je+yrIzA/iKOK6pVEP/wU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rYzkh34t3Eal6jwsebgoYTiC1lGbQeLdIjjyGDTzG7M=; b=Y+18L+WTToHocY6j177FOogvZz3Pb2xNgiZqGGSxTPblEWNk9sCOvuomrYUUxaZiqc 44PjBMCVWHq3NQHkdPTyNdX6PEyN5ZALou6Y+u77ZHNC2qnYIQAUHkZNgR8vkThB6ATs T51B3vAZDNRX1zDvDy2uxNorAVMAuIEM1WoVvLas5AqZtyjzRL0czAjS5VyR9nUqMy7T C6NznGmRDk5+xki8ODwbBtr0GS71m1fIkz6U2Q/juRHzva+cWjBFsrbRE6xBm7ESzwfK eM0rDhSA8m0eKBHSHsghsM8O133cjXA/jANL7lMRVeZplpab0HBcS7pGfdawA8qiLLbe uW0A== X-Gm-Message-State: AOAM532ShfQm7UooatRZIHUCBqPLhmS56KI7dSooRQIxI+50vv949lJU MKRCtVrLGC0zKby8ID9QjZhatJjg0OcxbtOf+ieAAQ== X-Google-Smtp-Source: ABdhPJwh4qKRH3mA9b08SF/3djGrZUXOw7YFs36m++5SnnGQS/NYgwnmhl+uCVmiTcEfFjLshwu9jxqsrlQGX8uy3YQ= X-Received: by 2002:a05:6830:17d6:: with SMTP id p22mr8653729ota.154.1603685379108; Sun, 25 Oct 2020 21:09:39 -0700 (PDT) MIME-Version: 1.0 References: <20201022184510.182976-1-lance.richardson@broadcom.com> In-Reply-To: <20201022184510.182976-1-lance.richardson@broadcom.com> From: Ajit Khaparde Date: Sun, 25 Oct 2020 21:09:23 -0700 Message-ID: To: Lance Richardson Cc: Somnath Kotur , dpdk-dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix incorrect boolean operator usage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 22, 2020 at 11:45 AM Lance Richardson wrote: > > Use boolean AND operator instead of bitwise operator. > > Coverity issue: 323488 > Fixes: b42c15c83e88 ("net/bnxt: support trusted VF") > Signed-off-by: Lance Richardson > Reviewed-by: Ajit Khaparde Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index aa2d9e00e..3ee4b5524 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1547,7 +1547,7 @@ static int bnxt_mac_addr_add_op(struct rte_eth_dev *eth_dev, > if (rc) > return rc; > > - if (BNXT_VF(bp) & !BNXT_VF_IS_TRUSTED(bp)) { > + if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp)) { > PMD_DRV_LOG(ERR, "Cannot add MAC address to a VF interface\n"); > return -ENOTSUP; > } > -- > 2.25.1 >