From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dpdk-dev <dev@dpdk.org>,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix RSS action parser
Date: Fri, 29 Oct 2021 10:35:25 -0700 [thread overview]
Message-ID: <CACZ4nhvb0OeUrZtGpwo_ZjOkAB4tiqL2ovw5d00EC-rwYm6aew@mail.gmail.com> (raw)
In-Reply-To: <6c82f2aa-e5dc-fc3d-34d0-a309077cb4cd@intel.com>
On Fri, Oct 29, 2021 at 10:22 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 10/26/2021 6:14 AM, Ajit Khaparde wrote:
> > Minor fixes are needed in the RTE_FLOW RSS action parser.
> > 1. Update the comment in the parser to indicate rss level 1 implies
> > RSS on outer header.
> > 2. RSS action will not be supported if level is > 1.
> > 3. RSS action will not be supported if user or application specifies
> > MARK or COUNT action.
> > 4. If RSS types is not specified i.e., is 0, the best effort RSS should
> > use IPV4 and IPV6 headers. Currently we are considering only IPV4.
> >
> > Fixes: fe0bab7eb34e ("net/bnxt: enhance support for RSS action")
> >
> > Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > Acked-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> > Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>
>
> <...>
>
> > @@ -1177,7 +1172,7 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp,
> > }
> >
> > /* If RSS types is 0, use a best effort configuration */
> > - types = rss->types ? rss->types : RTE_ETH_RSS_IPV4;
> > + types = rss->types ? rss->types : ETH_RSS_IPV4 | ETH_RSS_IPV6;
>
> We should keep the RTE_ prefix, updating in the next-net.
ACK. Thanks
>
prev parent reply other threads:[~2021-10-29 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 5:14 Ajit Khaparde
2021-10-27 1:51 ` Ajit Khaparde
2021-10-29 17:22 ` Ferruh Yigit
2021-10-29 17:35 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhvb0OeUrZtGpwo_ZjOkAB4tiqL2ovw5d00EC-rwYm6aew@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).