From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EA6FA0C41; Fri, 29 Oct 2021 19:35:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D8D9040688; Fri, 29 Oct 2021 19:35:43 +0200 (CEST) Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by mails.dpdk.org (Postfix) with ESMTP id 28ECB40395 for ; Fri, 29 Oct 2021 19:35:42 +0200 (CEST) Received: by mail-il1-f170.google.com with SMTP id j28so5023658ila.1 for ; Fri, 29 Oct 2021 10:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=71qhjoc+7FBt2e4WEBxYgLJ/Ti7+3DGA5Cp+cXOmrjI=; b=fz5S7qg6pXuP4d6B5HHCYB5O3EY/2wHoh6lf/pBqXOpnZGWG1FiqnXzPkG17ItH7aH jFBKFspeqKEXWp8aYQSRNFKathtdgewTCbBuRLqMLZrbqa2vf7AYYaxNfeOPJfzdfxfV NZWNeJZ9vjuQW6I/F9Pvp1CVAFpynXBzVhDCg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=71qhjoc+7FBt2e4WEBxYgLJ/Ti7+3DGA5Cp+cXOmrjI=; b=M7FOq85U5RkhnlFgjUwtxg6JwzKaHWTdcKlWDZBv0dHnuqgR2oaLtGyerxQ+okmUXq BbQ7HhA23PngsFGKFtiZMNKRfsjLekIDEH5WEoVhXWfi7wJy7U0H0E6EliTCgoPCZVsI SzNXBnHkHKoRm1nGGuBUX03AGPrBIOR0VS5tVb+yf16bTOyFrEptMgJvKlLP63g5DDCV ++hI+HKx+GotIV0K8WgKE5z1I2EqTu+iNdDcZPKBSlqYlqcR154JnbW5CfHQEj8jKgcP WsUs7DQPEUK0S7wjW87j/V/oVicFiqArdntdY1PSq/xus6IKUPbRlREBQwJfURtgULIy yx8w== X-Gm-Message-State: AOAM5330c6LoYV9+t0Khx3Q7I/dKMO7LbZfGf2oIcUiiJNPjNqnaAGSY ifNQQSyRmL5dkxtP9Kgel/ONO4WDex+KmU3uNTLn8w== X-Google-Smtp-Source: ABdhPJyHROKjajksHrsT+Wrgl3GtJlSfI+UQQBFqRdKzae84hRNSXbNB3ztKWOGWoeMRzw7K/qDY271jVRQoqHaxdFg= X-Received: by 2002:a05:6e02:148c:: with SMTP id n12mr9102906ilk.311.1635528941495; Fri, 29 Oct 2021 10:35:41 -0700 (PDT) MIME-Version: 1.0 References: <20211026051432.83989-1-ajit.khaparde@broadcom.com> <6c82f2aa-e5dc-fc3d-34d0-a309077cb4cd@intel.com> In-Reply-To: <6c82f2aa-e5dc-fc3d-34d0-a309077cb4cd@intel.com> From: Ajit Khaparde Date: Fri, 29 Oct 2021 10:35:25 -0700 Message-ID: To: Ferruh Yigit Cc: dpdk-dev , Kalesh AP , Somnath Kotur Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix RSS action parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 29, 2021 at 10:22 AM Ferruh Yigit wrote: > > On 10/26/2021 6:14 AM, Ajit Khaparde wrote: > > Minor fixes are needed in the RTE_FLOW RSS action parser. > > 1. Update the comment in the parser to indicate rss level 1 implies > > RSS on outer header. > > 2. RSS action will not be supported if level is > 1. > > 3. RSS action will not be supported if user or application specifies > > MARK or COUNT action. > > 4. If RSS types is not specified i.e., is 0, the best effort RSS should > > use IPV4 and IPV6 headers. Currently we are considering only IPV4. > > > > Fixes: fe0bab7eb34e ("net/bnxt: enhance support for RSS action") > > > > Signed-off-by: Ajit Khaparde > > Acked-by: Kalesh AP > > Acked-by: Somnath Kotur > > <...> > > > @@ -1177,7 +1172,7 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp, > > } > > > > /* If RSS types is 0, use a best effort configuration */ > > - types = rss->types ? rss->types : RTE_ETH_RSS_IPV4; > > + types = rss->types ? rss->types : ETH_RSS_IPV4 | ETH_RSS_IPV6; > > We should keep the RTE_ prefix, updating in the next-net. ACK. Thanks >