From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3275A2EFC for ; Tue, 17 Sep 2019 03:56:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 91DCA1BFD9; Tue, 17 Sep 2019 03:56:16 +0200 (CEST) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by dpdk.org (Postfix) with ESMTP id 1C2F61BEF2 for ; Tue, 17 Sep 2019 03:56:15 +0200 (CEST) Received: by mail-ot1-f65.google.com with SMTP id z6so1642784otb.2 for ; Mon, 16 Sep 2019 18:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hHmEv3EeZlev9ziyRmRuclcNp0TzPmxqToKJKuIyzCU=; b=hK4fYJnV5U0tYJppfoZEJhASEpornGAJzXEczEs8xSfUs47fgjr7vhkgvNZZ6N5wGA fN7eOdPQUsWsAZvKzDqMbxRFY7cY0hbuAXVo8A2w3b9EeaBR0x+fkLUyAGxdBO57ppFI KzJxpYMeXVgTvcI7NXtX5m3VvDG2YsAUvQXIU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hHmEv3EeZlev9ziyRmRuclcNp0TzPmxqToKJKuIyzCU=; b=SQ9Mq+pI9qARhREJl4AA1C0VY/b6RDkIlD9L7Hyjx24UuZwWzB2OvpIx3lIJzlsSgD NEqmTVMoQ4vC3VtBIGgT+RRHtExs+MJAGtk1wXYxDU2i3IX8HvRUqe4298Z86r6GKyTF BXVfJ+YqCSu8yDzmxNeztPCKAuswzRI/Esgcg4sMjiS8x9iaaqw5YAfuPCYNCRXMs3/G RLrAoynCEzr5gTBnOWrIyXNskdTI/BsW8mwxnxpy4QVGNsDHlnUcWFjmjYvZZzceI1jK ldSuZSRIVr7gBIkhWKS/rqbjrpHiyEj0lkfEdAUwZd+W4GrAsbs8XlwA8hsXEyYmyB2n zRFg== X-Gm-Message-State: APjAAAVV/498p+o3CO7ByQXkoGN7FfR7IVkXe7zUHBx6GFSBR17IJJf4 e1PcTDkjnos/395m0kHIceeTW3wG6tm+Yw1OTkq1uA== X-Google-Smtp-Source: APXvYqz2+4hudeXEFqApM/nAMh82fu6XJHa4oA0OQrix2FKctUy94YMaOXeTQfsEKxuQAav4yenAblNJVpqDSErdmpU= X-Received: by 2002:a05:6830:18c1:: with SMTP id v1mr851289ote.305.1568685374053; Mon, 16 Sep 2019 18:56:14 -0700 (PDT) MIME-Version: 1.0 References: <1567751873-15964-1-git-send-email-gavin.hu@arm.com> <1568633238-47888-1-git-send-email-gavin.hu@arm.com> <1568633238-47888-4-git-send-email-gavin.hu@arm.com> In-Reply-To: <1568633238-47888-4-git-send-email-gavin.hu@arm.com> From: Ajit Khaparde Date: Mon, 16 Sep 2019 18:55:57 -0700 Message-ID: To: Gavin Hu Cc: dev@dpdk.org, nd@arm.com, Thomas Monjalon , Bruce Richardson , yong.liu@intel.com, yinan.wang@intel.com, Somnath Kotur , Honnappa.Nagarahalli@arm.com, ruifeng.wang@arm.com, steve.capper@arm.com, dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 3/5] net/bnxt: remove duplicate barrier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 16, 2019 at 4:27 AM Gavin Hu wrote: > As there is an inclusive rte_io_wmb within the following rte_write32() > API who rings the doorbell, this makes the above rte_wmb unnecessary and > remove it. > > Fixes: 1cd45aeb3270 ("net/bnxt: support Stratus VF device") > Cc: stable@dpdk.org > > Signed-off-by: Gavin Hu > Reviewed-by: Steve Capper > Reviewed-by: Ruifeng Wang > Reviewed-by: Phil Yang > Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_hwrm.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index 9883fb5..1d9fb17 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -115,9 +115,6 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, > void *msg, > data = (uint32_t *)&short_input; > msg_len = sizeof(short_input); > > - /* Sync memory write before updating doorbell */ > - rte_wmb(); > - > max_req_len = BNXT_HWRM_SHORT_REQ_LEN; > } > > -- > 2.7.4 > >