From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com [209.85.220.181]) by dpdk.org (Postfix) with ESMTP id 312514C57 for ; Fri, 30 Jun 2017 04:28:38 +0200 (CEST) Received: by mail-qk0-f181.google.com with SMTP id p21so91239053qke.3 for ; Thu, 29 Jun 2017 19:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9+u2dS4k+hloU63h7qfaZKtPEfOJ/SLIDFP37jizVn0=; b=SfC7Hy1cFwwf33rPYkyTgOSuaCIfHJmlbYOl8UxM5L9r6HwgHpHMjF5l/J6cEnrwDv L5wnHyRJ4wahS8NC/t0c9Sh3RqZlZxuPnt7pKLDAx4ZtzQfJ8YoZdX5XXaFJNlynDoVM hNn0eY1aqgfHR/q49zSi8u2e8l7VTjhHq+kN8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9+u2dS4k+hloU63h7qfaZKtPEfOJ/SLIDFP37jizVn0=; b=XF08ktViK2R7IFLkD58A0ILzLHq2X2oTotEhvy0G0MyjCJKXBET/KQ0IAGO3aMvgLK tTptvfajp5PC0HMSO5jH+RsKMvkazn488gbKytQA3iwI6gFjIUwyYMbMpAeFYUeWS8Z8 oy0TLROaqV+53BsMwSSmlGvTppD7nimqzPOYALaRM26B/1i1bUSEp8/7XJDyGzmt0ssm bOmxb+QOvYvK5oCJq1D8RN9Gx2BTdCjZcxva+g/Y/IHhQZtrOw/wubzE0H3X4DYBGa8m Qq/lnQjdnu0K+YixWGFI4o1hCSXFi3jZo4DDDYCrmcsOWF4lcMO2hr+57EOzduX3j2+y +YcQ== X-Gm-Message-State: AKS2vOz43HlAF3kRgRzJNkE3Th3KbOBEOVxu51Zhpm/DKY5+kCGYVgzT 15h5Ay3VEULQL7lrOvc3esC22oGSxQcI X-Received: by 10.55.104.195 with SMTP id d186mr21777190qkc.176.1498789717572; Thu, 29 Jun 2017 19:28:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.45.197 with HTTP; Thu, 29 Jun 2017 19:27:56 -0700 (PDT) In-Reply-To: <096daf46-dd9f-f84b-de0d-9a4e87a8d461@intel.com> References: <20170629025142.19404-1-ajit.khaparde@broadcom.com> <20170629025142.19404-7-ajit.khaparde@broadcom.com> <096daf46-dd9f-f84b-de0d-9a4e87a8d461@intel.com> From: Ajit Khaparde Date: Thu, 29 Jun 2017 21:27:56 -0500 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Stephen Hurd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 6/7] net/bnxt: fix some link related issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 02:28:38 -0000 On Thu, Jun 29, 2017 at 5:55 AM, Ferruh Yigit wrote: > On 6/29/2017 3:51 AM, Ajit Khaparde wrote: > > This patch fixes some link related issues that can occur because: > > > > bnxt_hwrm_port_phy_cfg() was setting enables inappropriately. > > bnxt_hwrm_port_phy_qcfg() was overly complex. > > bnxt_get_hwrm_link_config() was basing the speed on the link status. > > bnxt_get_hwrm_link_config() was using the incorrect macros for auto_mod= e > > we are not using supported speeds from phy_qcfg for auto mask. > > Does it make sense to split patch per issue fixed? > Sure. Working on that. Thanks =E2=80=8B > > > > > Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification") > > > > Signed-off-by: Stephen Hurd > > Signed-off-by: Ajit Khaparde > <...> > >