From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27478A052A; Tue, 26 Jan 2021 06:36:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E959F14120A; Tue, 26 Jan 2021 06:35:58 +0100 (CET) Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by mails.dpdk.org (Postfix) with ESMTP id 578201411DA for ; Tue, 26 Jan 2021 06:35:58 +0100 (CET) Received: by mail-qk1-f179.google.com with SMTP id t63so2290287qkc.1 for ; Mon, 25 Jan 2021 21:35:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c8E2HPfSVy/HTZmV2f0gN7quHBSCGLo9JBiBXua8GU0=; b=Ol6IA0rIzCN2LWhBvUuGm29KDnRjFny/qqqtzKhgvF9uZb+Q7sgCYGJ4qt8gC7FWhn YvYVeBq0uUHRD5672DNmEvu0MaPGJ1jv67mIwjbvNYdPCBx381KOfgNP7tMvELdWXzaW QKcqrRQM5rIhtTUjLrp2R6UoBqR4zW7WellzY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c8E2HPfSVy/HTZmV2f0gN7quHBSCGLo9JBiBXua8GU0=; b=RymE8yZcEeQ0Prgtky5FrdQzly8IaL5opFGBdeMA62AeFtVLpupb5f23FM0CCmg1IB EqaRowtvAmHWdmUouSqczBebpFmSbKMQ1kx1QZTOgRNVwc7xXsq0eWds7IeujykAmYua qNUalOxGa4HKuCY3jwYBdpntsCxlECUTFT7O+MRzaNiCf7FKRBnpmjNGL7rpptsd4Pfg GfJThTwXrQqE0Xvhoi/FPExzJgII9+J3oxmpOpiwwR5elv7ApSUkUkx2UItFJnSezXfE RRXXwx4kg/dj1H8Noe13w8ndMy9RNMBRsnO1JeNHvtcMwqwpAIw598SDb+ZGyLeVxqmn Vj9w== X-Gm-Message-State: AOAM532LdZNwPqVk7s9AIUsOH8miq0ojbXcrrJO94TyHDuQ3o20u5YPF 8xgXs51FdHGq/rA4QHK4z12K5SicAg6uzI0xIfoPfQ== X-Google-Smtp-Source: ABdhPJyruUNNqbKbSBoVGzVN/oY+Ly99NEvNSIVn3wP0qvZ3jVShcgRsvZeP5q8LWyqNstndYvM8dNhAop41eIpallY= X-Received: by 2002:a37:8703:: with SMTP id j3mr4260682qkd.455.1611639357605; Mon, 25 Jan 2021 21:35:57 -0800 (PST) MIME-Version: 1.0 References: <20210126033824.29175-1-akozyrev@nvidia.com> <20210125194354.5b2fccdc@hermes.local> In-Reply-To: From: Ajit Khaparde Date: Mon, 25 Jan 2021 21:35:41 -0800 Message-ID: To: Alexander Kozyrev Cc: Stephen Hemminger , "dev@dpdk.org" , Slava Ovsiienko , Ori Kam , NBU-Contact-Thomas Monjalon , "ferruh.yigit@intel.com" , "andrew.rybchenko@oktetlabs.ru" , "jerinjacobk@gmail.com" Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000070655405b9c70799" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] ethdev: add IPv6 DSCP option for modify field action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000070655405b9c70799 Content-Type: text/plain; charset="UTF-8" On Mon, Jan 25, 2021 at 9:21 PM Alexander Kozyrev wrote: > > > From: Stephen Hemminger on Monday, January 25, 2021 22:44 > > > > On Tue, 26 Jan 2021 03:38:24 +0000 > > Alexander Kozyrev wrote: > > > > > IPv6 DSCP field ID is missing from the original list of Field IDs > > > for MODIFY_FIELD action. Add it to support IPv6 header fully. > > > > > > Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action") > > > > > > Signed-off-by: Alexander Kozyrev > > > --- > > > lib/librte_ethdev/rte_flow.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > > > index 46e8ee70ab..68c68cdd6c 100644 > > > --- a/lib/librte_ethdev/rte_flow.h > > > +++ b/lib/librte_ethdev/rte_flow.h > > > @@ -2842,6 +2842,7 @@ enum rte_flow_field_id { > > > RTE_FLOW_FIELD_IPV4_TTL, > > > RTE_FLOW_FIELD_IPV4_SRC, > > > RTE_FLOW_FIELD_IPV4_DST, > > > + RTE_FLOW_FIELD_IPV6_DSCP, > > > RTE_FLOW_FIELD_IPV6_HOPLIMIT, > > > RTE_FLOW_FIELD_IPV6_SRC, > > > RTE_FLOW_FIELD_IPV6_DST, > > > > Adding field in middle of enum will break ABI. > > I added the rte_flow_field_id enum a week ago into 20.11-rc1. 21.02-rc1 > I believe it is not too late to make it right without breaking ABI, don't you think so? --00000000000070655405b9c70799--