From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F4A0A04C8; Fri, 15 Nov 2019 06:24:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5CC402C08; Fri, 15 Nov 2019 06:24:41 +0100 (CET) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by dpdk.org (Postfix) with ESMTP id 5C62BB62 for ; Fri, 15 Nov 2019 06:24:40 +0100 (CET) Received: by mail-oi1-f196.google.com with SMTP id y194so7615810oie.4 for ; Thu, 14 Nov 2019 21:24:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HcuXSuAH/cTngwwozfhmGOXB8LlWtAsKewc8iyDfROU=; b=LtDO9XmK0YissaUMfs2lZh0PID23Rk4p/9yqq9HxM+I1Pg7zmEN+fGB8fHk+0UpWiH ADfwd98J43XpIpIC+PXVD+0zhwM3NQ1//CcTbbgG2vcKCI+XVCGc09qUl4475hFFtE3p DCpZFXzdr1n/TvztqnO3cEKUMNhtUHIHl+Ybo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HcuXSuAH/cTngwwozfhmGOXB8LlWtAsKewc8iyDfROU=; b=cYgmZ1pAULuZ4EgY49guU78aLb8uo6W+fFAULQQkxU+eCK0dJbrha4JxnvOq1G9sSO 6HFROaIFhzpxHbW47FxsQQtuiEbIkJYBrandRZUczfPbfJyDlglTP9CYdCqIeDvwV8Og fMojB+cEdkOU3A4pzbFw3RHi24Sle7ZMIfiNJxTJ+UZX9+mCE/3LVxv0YBqH4VS+tw0L VyvydTPQOLLBHB2TMOIQqoUJZt77b+osxSLWcI8oB7PdXsAtuLL3NXjwKHNe1Sw64D1t 52BqkZa+asRUMNJ2UHDO+W6x+aQRuh8VveVdH2o+NjUVYeNfcnrkryAQhR/6ajWWWueH 1sQQ== X-Gm-Message-State: APjAAAWy8QWTVzbY4tacJMTR6UOmrf3zA3jTLKkImic2fz4mSeuyCWn8 y/VOoLB9jKleWiWtUWncXGnqiQCiLaPLnXKsjJi9Hg== X-Google-Smtp-Source: APXvYqwyzeMSosCrrjqW9VWOMef6DwqUqzTNfP6iEEk+GSADo+T3twhcx4sw/Tx2AQetkMtPp/ZWScuvQaFJjl4K3sc= X-Received: by 2002:aca:1c03:: with SMTP id c3mr6464948oic.168.1573795479356; Thu, 14 Nov 2019 21:24:39 -0800 (PST) MIME-Version: 1.0 References: <20191115045028.11319-1-somnath.kotur@broadcom.com> In-Reply-To: <20191115045028.11319-1-somnath.kotur@broadcom.com> From: Ajit Khaparde Date: Thu, 14 Nov 2019 21:24:23 -0800 Message-ID: To: Somnath Kotur Cc: dpdk-dev , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix IP checksum error indication in non-vector mode rx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 14, 2019 at 8:58 PM Somnath Kotur wrote: > From: Kalesh AP > > Update "mbuf->ol_flags" correctly for 'Checksum Unknown' errors > for both tunneled and non-tunneled IP packets. > > Fixes: b875339622a3 ("net/bnxt: fix L4 checksum indication in non-vector > Rx") > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_rxr.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > index c35bc1afd..3b713c242 100644 > --- a/drivers/net/bnxt/bnxt_rxr.c > +++ b/drivers/net/bnxt/bnxt_rxr.c > @@ -515,16 +515,18 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt, > if (likely(IS_IP_NONTUNNEL_PKT(flags2_f))) { > if (unlikely(RX_CMP_IP_CS_ERROR(rxcmp1))) > mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD; > + else if (unlikely(RX_CMP_IP_CS_UNKNOWN(rxcmp1))) > + mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN; > else > mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD; > } else if (IS_IP_TUNNEL_PKT(flags2_f)) { > if (unlikely(RX_CMP_IP_OUTER_CS_ERROR(rxcmp1) || > RX_CMP_IP_CS_ERROR(rxcmp1))) > mbuf->ol_flags |= PKT_RX_IP_CKSUM_BAD; > + else if (unlikely(RX_CMP_IP_CS_UNKNOWN(rxcmp1))) > + mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN; > else > mbuf->ol_flags |= PKT_RX_IP_CKSUM_GOOD; > - } else if (unlikely(RX_CMP_IP_CS_UNKNOWN(rxcmp1))) { > - mbuf->ol_flags |= PKT_RX_IP_CKSUM_UNKNOWN; > } > > /* L4 Checksum */ > -- > 2.23.0.rc1 > >