[dpdk-dev] [PATCH] net/bnxt: remove workaround for default VNIC

[dpdk-dev] [PATCH] net/bnxt: remove workaround for default VNIC

[Kalesh A P]

From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>

On older Wh+ firmware versions, HWRM_FUNC_QCFG returns zero
for the parent default vnic. Commit "3fb93bc7c349" added a
temporary Wh+-specific workaround in the PMD.
This has been fixed in latest firmware and hence removing
the workaround.

Fixes: 3fb93bc7c349 ("net/bnxt: initialize parent PF information")
Cc: stable@dpdk.org

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index e6c46d4..73deb41 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -3390,16 +3390,6 @@ int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp)
 	bp->parent->fid = rte_le_to_cpu_16(resp->fid);
 	bp->parent->port_id = rte_le_to_cpu_16(resp->port_id);
 
-	/* FIXME: Temporary workaround - remove when firmware issue is fixed. */
-	if (bp->parent->vnic == 0) {
-		PMD_DRV_LOG(DEBUG, "parent VNIC unavailable.\n");
-		/* Use hard-coded values appropriate for current Wh+ fw. */
-		if (bp->parent->fid == 2)
-			bp->parent->vnic = 0x100;
-		else
-			bp->parent->vnic = 1;
-	}
-
 	HWRM_UNLOCK();
 
 	return 0;
-- 
2.10.1

Re: [dpdk-dev] [PATCH] net/bnxt: remove workaround for default VNIC

[Ajit Khaparde]

[-- Attachment #1: Type: text/plain, Size: 1705 bytes --]

On Sat, Jul 17, 2021 at 10:10 PM Kalesh A P <
kalesh-anakkur.purayil@broadcom.com> wrote:

> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> On older Wh+ firmware versions, HWRM_FUNC_QCFG returns zero
> for the parent default vnic. Commit "3fb93bc7c349" added a
> temporary Wh+-specific workaround in the PMD.
> This has been fixed in latest firmware and hence removing
> the workaround.
>
> Fixes: 3fb93bc7c349 ("net/bnxt: initialize parent PF information")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
>
Patch applied to dpdk-next-net-brcm


> ---
>  drivers/net/bnxt/bnxt_hwrm.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
> index e6c46d4..73deb41 100644
> --- a/drivers/net/bnxt/bnxt_hwrm.c
> +++ b/drivers/net/bnxt/bnxt_hwrm.c
> @@ -3390,16 +3390,6 @@ int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp)
>         bp->parent->fid = rte_le_to_cpu_16(resp->fid);
>         bp->parent->port_id = rte_le_to_cpu_16(resp->port_id);
>
> -       /* FIXME: Temporary workaround - remove when firmware issue is
> fixed. */
> -       if (bp->parent->vnic == 0) {
> -               PMD_DRV_LOG(DEBUG, "parent VNIC unavailable.\n");
> -               /* Use hard-coded values appropriate for current Wh+ fw. */
> -               if (bp->parent->fid == 2)
> -                       bp->parent->vnic = 0x100;
> -               else
> -                       bp->parent->vnic = 1;
> -       }
> -
>         HWRM_UNLOCK();
>
>         return 0;
> --
> 2.10.1
>
>