From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 191ADA0C4C; Tue, 20 Jul 2021 23:36:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3DFF4068F; Tue, 20 Jul 2021 23:36:34 +0200 (CEST) Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by mails.dpdk.org (Postfix) with ESMTP id 7696140689 for ; Tue, 20 Jul 2021 23:36:33 +0200 (CEST) Received: by mail-qv1-f47.google.com with SMTP id gh6so10824625qvb.3 for ; Tue, 20 Jul 2021 14:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IK2KM+wiT4QhYqfsYeD50ytO2kmM1IxqTq8k1LkMz2E=; b=J1jDGzAQamdGvFmEp+bNOft3yVQjIdVzXSC54/73viHSQ8GIIh3O8Q3O4z6sCzQywq c/dOxWSaAWV4Hf4X7VRQ8INXu0TM2HGX9HUHFDlepgkwVDOit4K2zKj5ojAfPbAEjy/h 5Fws6jDowcCDd5DNPxaqVLazD4zjERR0yZE6A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IK2KM+wiT4QhYqfsYeD50ytO2kmM1IxqTq8k1LkMz2E=; b=rJu2dnjWnTHvF+k9JJRiXrc7602w1Z1lHqT++8WJCeFcd/yVcIurD7ZRksFVspuWxE SXBMwUxNhnK2JijCg8GXhKHM5TgVuX1GLdUaZPjXPuwe4F1FrSzf31IDBi4OeEiLeBoi d6D4dSI+UrpafFeKTZIKw9sj1P+kdP8Xt4T3tQhPO5xVK5p9TvfIqgSXrjgCLe6p+8Nf MSi4tkwoAJkCVbRNUo4mqYBoRXhx1ML58mselc7bw7nQcKPFGLBNfaeY3WzM+NlOxmFj T7jDDQ1+Kwv+ZIWk9RKUKTYpz6WGSv0p1c2URJ2vKx4fD7WKyDJleNDjdI0DzeAWCwMa zM4A== X-Gm-Message-State: AOAM530BEG+rhX+AlxW+KRKnCdSkH0A4swYMJl4jkvfh+kPjCTkxopNY SoPlXL5lhdEuHYDMIWq9g1Gc6VJkve72WGJQppGzYA== X-Google-Smtp-Source: ABdhPJzia3Niv0LVtMNvwRVCQ6AepLzsgDJ2b3RuU6Do7TFfc0dNnYO47LNMiIfGDlcBmMaJ7covZ9zZPNcvujTnyX4= X-Received: by 2002:ad4:54d0:: with SMTP id j16mr32858843qvx.30.1626816992908; Tue, 20 Jul 2021 14:36:32 -0700 (PDT) MIME-Version: 1.0 References: <20210718053059.16194-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20210718053059.16194-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Tue, 20 Jul 2021 14:36:16 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000fd602605c794d86e" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: remove workaround for default VNIC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000fd602605c794d86e Content-Type: text/plain; charset="UTF-8" On Sat, Jul 17, 2021 at 10:10 PM Kalesh A P < kalesh-anakkur.purayil@broadcom.com> wrote: > From: Kalesh AP > > On older Wh+ firmware versions, HWRM_FUNC_QCFG returns zero > for the parent default vnic. Commit "3fb93bc7c349" added a > temporary Wh+-specific workaround in the PMD. > This has been fixed in latest firmware and hence removing > the workaround. > > Fixes: 3fb93bc7c349 ("net/bnxt: initialize parent PF information") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Ajit Khaparde > Reviewed-by: Lance Richardson > Patch applied to dpdk-next-net-brcm > --- > drivers/net/bnxt/bnxt_hwrm.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index e6c46d4..73deb41 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -3390,16 +3390,6 @@ int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp) > bp->parent->fid = rte_le_to_cpu_16(resp->fid); > bp->parent->port_id = rte_le_to_cpu_16(resp->port_id); > > - /* FIXME: Temporary workaround - remove when firmware issue is > fixed. */ > - if (bp->parent->vnic == 0) { > - PMD_DRV_LOG(DEBUG, "parent VNIC unavailable.\n"); > - /* Use hard-coded values appropriate for current Wh+ fw. */ > - if (bp->parent->fid == 2) > - bp->parent->vnic = 0x100; > - else > - bp->parent->vnic = 1; > - } > - > HWRM_UNLOCK(); > > return 0; > -- > 2.10.1 > > --000000000000fd602605c794d86e--