From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE3E8A0579; Sat, 24 Apr 2021 21:39:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2AB2A4013F; Sat, 24 Apr 2021 21:39:25 +0200 (CEST) Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) by mails.dpdk.org (Postfix) with ESMTP id 0627D40040 for ; Sat, 24 Apr 2021 21:39:23 +0200 (CEST) Received: by mail-qv1-f48.google.com with SMTP id bs7so24953423qvb.12 for ; Sat, 24 Apr 2021 12:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vKCI1i3OZj9LS+VoW6r5oD/6j1jv2slhFWFG8K44/MU=; b=gGIUcU6A4UJxETRN+m+g/Rjp7BlxDwj74PBoQYgh8YpoQvjYfuF0BRmpV+xBv2axyB spKCJzAH3u0m6Q0cwh5DUO6R/rtnlewfCeQ3oUH+kGXz9YLMf4CpEgDO3A6zPrde9ar7 +DcWz+jfD9rzg8vlnNgLD2G5uieaZD9oBml18= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vKCI1i3OZj9LS+VoW6r5oD/6j1jv2slhFWFG8K44/MU=; b=NOQa7CwNMbL5NSYLo4XD5jdBV072Zxqj3EGMQn/dYCwhJLXIcAW8bkgZmOrLf5IlwZ YLN5t6m52VkDYhwagDqN+HQlLh0esRdBlCFNd9cs2rCcqWo41LlWbK5Ygy0z2DMbHdFc 0VDFJEG89JW4jCf1gBTtsyoKZmDGO6WbHbBpjBOcrfSgBxRtaFuJebmQBzsdGF1sTtxA stT9EY725wdWagZ2TdIk36ndQi157vHPmKOboSa6uOTkfVzhJXxUf+tpC6Iwyw5LsYol tmz1vOdm1lz/sBv0neJwAXlxLC0eQe1ViQIaoqQ9TJF0YhjVHb8qfILqYEIhDnZHnca1 S2aA== X-Gm-Message-State: AOAM532T0v6AWS55CBZMrYE7vI7gN3kE3i07TZS7pr+LuGROdBzjJhwn leDbDbvjXRNZh7p0+ERUS7abvmgaegEMFilvWvntZX/+N0Y2sQ== X-Google-Smtp-Source: ABdhPJw07VFgS69UV8XVHdv+FGtny3V+q/5Wv/haO1qD5cF5HqYw00eSq7qxNzAQRfkn9lCoqQI7pj2hMcGvPHcwbX0= X-Received: by 2002:a0c:9e0f:: with SMTP id p15mr10457362qve.33.1619293163222; Sat, 24 Apr 2021 12:39:23 -0700 (PDT) MIME-Version: 1.0 References: <20210423210444.197230-1-stephen@networkplumber.org> In-Reply-To: <20210423210444.197230-1-stephen@networkplumber.org> From: Ajit Khaparde Date: Sat, 24 Apr 2021 12:39:05 -0700 Message-ID: To: Stephen Hemminger Cc: dpdk-dev Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000cdea3805c0bd1126" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: use bnxt_ prefix on global function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000cdea3805c0bd1126 Content-Type: text/plain; charset="UTF-8" On Fri, Apr 23, 2021 at 2:04 PM Stephen Hemminger wrote: > > When statically linked the function prandom_bytes is exposed > and might conflict with something in application. All driver > functions should use same prefix. > > Fixes: 9738793f28ec ("net/bnxt: add VNIC functions and structs") > Signed-off-by: Stephen Hemminger Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_flow.c | 4 ++-- > drivers/net/bnxt/bnxt_vnic.c | 4 ++-- > drivers/net/bnxt/bnxt_vnic.h | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c > index e3906b47791b..844bf1520f50 100644 > --- a/drivers/net/bnxt/bnxt_flow.c > +++ b/drivers/net/bnxt/bnxt_flow.c > @@ -1404,8 +1404,8 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev, > /* If hash key has not been specified, > * use random hash key. > */ > - prandom_bytes(vnic->rss_hash_key, > - HW_HASH_KEY_SIZE); > + bnxt_prandom_bytes(vnic->rss_hash_key, > + HW_HASH_KEY_SIZE); > } else { > if (rss->key_len > HW_HASH_KEY_SIZE) > memcpy(vnic->rss_hash_key, > diff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c > index 14ad33b4e86c..de5c14566deb 100644 > --- a/drivers/net/bnxt/bnxt_vnic.c > +++ b/drivers/net/bnxt/bnxt_vnic.c > @@ -16,7 +16,7 @@ > * VNIC Functions > */ > > -void prandom_bytes(void *dest_ptr, size_t len) > +void bnxt_prandom_bytes(void *dest_ptr, size_t len) > { > char *dest = (char *)dest_ptr; > uint64_t rb; > @@ -172,7 +172,7 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp) > HW_HASH_KEY_SIZE); > vnic->mc_list_dma_addr = vnic->rss_hash_key_dma_addr + > HW_HASH_KEY_SIZE; > - prandom_bytes(vnic->rss_hash_key, HW_HASH_KEY_SIZE); > + bnxt_prandom_bytes(vnic->rss_hash_key, HW_HASH_KEY_SIZE); > } > > return 0; > diff --git a/drivers/net/bnxt/bnxt_vnic.h b/drivers/net/bnxt/bnxt_vnic.h > index 00a664c8b839..37b452f28170 100644 > --- a/drivers/net/bnxt/bnxt_vnic.h > +++ b/drivers/net/bnxt/bnxt_vnic.h > @@ -68,7 +68,7 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp); > void bnxt_free_vnic_mem(struct bnxt *bp); > int bnxt_alloc_vnic_mem(struct bnxt *bp); > int bnxt_vnic_grp_alloc(struct bnxt *bp, struct bnxt_vnic_info *vnic); > -void prandom_bytes(void *dest_ptr, size_t len); > +void bnxt_prandom_bytes(void *dest_ptr, size_t len); > uint16_t bnxt_rte_to_hwrm_hash_types(uint64_t rte_type); > int bnxt_rte_to_hwrm_hash_level(struct bnxt *bp, uint64_t hash_f, uint32_t lvl); > uint64_t bnxt_hwrm_to_rte_rss_level(struct bnxt *bp, uint32_t mode); > -- > 2.30.2 > --000000000000cdea3805c0bd1126--