From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61F6DA0C5A; Mon, 29 Nov 2021 20:00:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F22EC4068E; Mon, 29 Nov 2021 20:00:38 +0100 (CET) Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) by mails.dpdk.org (Postfix) with ESMTP id 5DE8340689 for <dev@dpdk.org>; Mon, 29 Nov 2021 15:13:05 +0100 (CET) Received: by mail-oi1-f178.google.com with SMTP id bk14so34849842oib.7 for <dev@dpdk.org>; Mon, 29 Nov 2021 06:13:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fxpYGK0AXNZYSeqs1rnGUGj1VAlt8oy2qy4cCS1TjZo=; b=g8QBMfZl10kr9jlxE6WFkWrSNfMPGW2SFJIbtH2QxVgtq1k0kf1prxhUV92OBR9K4M I0/43MXNb986odeh5zYoB3XYCUPOLzs+nE84wyuZKYjsVre6CGO4zM6XD6qK2GUck2lp +6daC0p538U53c7RzMliD2Kr+D5cQyVsp/LWac9eWu98YuWTSq95Zam3daR5cHun4ojS otfLOXbSIahq8JIa7FqYvXEFn5Q4aRF+HHHyr6P1BAGudlTb2HpNquQpPnvJWCaUIxnz BxJY+j0YSR1AOJl1nBdmQLeDLJX6e5YSO4RCqqSYJuLmljj45Wa113Nu1YU5LoiPH1v8 a1Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fxpYGK0AXNZYSeqs1rnGUGj1VAlt8oy2qy4cCS1TjZo=; b=BEEz/ZgJGTOGil7YplTblBAQjY8gJDDQUcq03KZdNiCwuPiUTiaLfT0OQOHuMZzrR3 XdIteXgJqnMPL+hM8kZHH2tSY5H8sVA/IniuQ6BAWWdI00k8+peeO2urfLNSpBwOVU6/ 7EknKI4FkJU0yqf6thu7xEagJ4aTPJ1ER4kcLc4dZzJ4jzdsiY8eLJOT2pdcBrzJecp3 kPsfwRqaZvuO1/FBS21D1Fvp2lmqhziX2CX+u7h0wDeL9SXSsBmfY/bmEVOZc1l8Ae2X AsyZ/erejXb2jsAEPaXxJRtKRkTgtaLKnOZjx40M9VZxSyAsfdw6hwH39BVxV9JxEVkw G9Sw== X-Gm-Message-State: AOAM532S1M6GYB31Dxtsovs/fKHofFbL78iX3jX0shmaiuEasseRa5Sv fhLFCWwnxR7SaLRiOZNIq0CScQJt8REIpH7sa9U= X-Google-Smtp-Source: ABdhPJwjqeGaTI+eMSdy7WbLfw/rc/PvC8/p/vfLyX3JhUFlkWa9BoAD4E3c++iq1TxHbV38CWE0BABHn/6VF+CAQi8= X-Received: by 2002:a05:6808:68f:: with SMTP id k15mr40111805oig.5.1638195184687; Mon, 29 Nov 2021 06:13:04 -0800 (PST) MIME-Version: 1.0 References: <20211126195851.50167-1-jsoref@users.noreply.github.com> <737b8856-a247-3709-ad4c-a074d4547c86@intel.com> <YaTcpcVk4+nPZ3MB@bricha3-MOBL.ger.corp.intel.com> <68412427-b6aa-cb38-110a-14bc90d8fdc0@intel.com> In-Reply-To: <68412427-b6aa-cb38-110a-14bc90d8fdc0@intel.com> From: Josh Soref <jsoref@gmail.com> Date: Mon, 29 Nov 2021 09:12:53 -0500 Message-ID: <CACZqfqBXnVb4j+BfrZBgaMQoZvM1vkAhkXv1uXwNDhyro1Pykw@mail.gmail.com> Subject: Re: [PATCH] Spelling To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org, David Marchand <david.marchand@redhat.com>, Thomas Monjalon <thomas@monjalon.net> Content-Type: multipart/alternative; boundary="0000000000000e5b9805d1ee0add" X-Mailman-Approved-At: Mon, 29 Nov 2021 20:00:37 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org --0000000000000e5b9805d1ee0add Content-Type: text/plain; charset="UTF-8" On Mon, Nov 29, 2021, 9:05 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > On 11/29/2021 1:59 PM, Bruce Richardson wrote: > > On Mon, Nov 29, 2021 at 12:49:56PM +0000, Ferruh Yigit wrote: > >> Hi Josh, Thanks for the patch. > >> > >> The typo fixes for comments and logs are more straightforward, but I > have > >> mixed feeling about the variable / macro typo fixes, let's see what > others > >> think. > >> > >> And I think we should get this patch either one of the first patch or > last > >> patch to prevent conflict with other patches. > > > > +1 to being a first patch to start things off clean. > > > > For the macros, since there is quick a bit of content in the patch, could > > we have the patch split into a separate patch for macro changes to review > > separately, allowing the simple doc/printf spelling changes to go in > > immediately? > Yeah, this is doable. I'll see if I can do it now. It's a lot of files, plus I'll need to figure out the command sequence to reply to this thread. If someone is available on Slack for some handholding, that might help me get it done faster. Also as far as I can see there are multiple build errors related to the > variable / macro renames, which was the concern. > I'm used to having access to GitHub based CI that let me test before making a PR. I've locally dropped the peer change, but didn't resubmit since I figured I'd wait for replies. (Last night I installed meson and ninja, so I might be able to do a local build.) > --0000000000000e5b9805d1ee0add Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" = class=3D"gmail_attr">On Mon, Nov 29, 2021, 9:05 AM Ferruh Yigit <<a href= =3D"mailto:ferruh.yigit@intel.com">ferruh.yigit@intel.com</a>> wrote:<br= ></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-= left:1px #ccc solid;padding-left:1ex">On 11/29/2021 1:59 PM, Bruce Richards= on wrote:<br> > On Mon, Nov 29, 2021 at 12:49:56PM +0000, Ferruh Yigit wrote:<br> >> Hi Josh, Thanks for the patch.<br> >><br> >> The typo fixes for comments and logs are more straightforward, but= I have<br> >> mixed feeling about the variable / macro typo fixes, let's see= what others<br> >> think.<br> >><br> >> And I think we should get this patch either one of the first patch= or last<br> >> patch to prevent conflict with other patches.<br> > <br> > +1 to being a first patch to start things off clean.<br> > <br> > For the macros, since there is quick a bit of content in the patch, co= uld<br> > we have the patch split into a separate patch for macro changes to rev= iew<br> > separately, allowing the simple doc/printf spelling changes to go in<b= r> > immediately?<br></blockquote></div></div><div dir=3D"auto"><br></div><= div dir=3D"auto">Yeah, this is doable. I'll see if I can do it now. It&= #39;s a lot of files, plus I'll need to figure out the command sequence= to reply to this thread. If someone is available on Slack for some handhol= ding, that might help me get it done faster.</div><div dir=3D"auto"><br></d= iv><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gmail_= quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1= ex">Also as far as I can see there are multiple build errors related to the= <br> variable / macro renames, which was the concern.<br></blockquote></div></di= v><div dir=3D"auto"><br></div><div dir=3D"auto">I'm used to having acce= ss to GitHub based CI that let me test before making a PR. I've locally= dropped the peer change, but didn't resubmit since I figured I'd w= ait for replies.</div><div dir=3D"auto"><br></div><div dir=3D"auto">(Last n= ight I installed meson and ninja, so I might be able to do a local build.)<= /div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gmai= l_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left= :1ex"> </blockquote></div></div></div> --0000000000000e5b9805d1ee0add--