From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id EAE9A9A8F for ; Mon, 18 May 2015 11:16:32 +0200 (CEST) Received: by wgfl8 with SMTP id l8so28250193wgf.2 for ; Mon, 18 May 2015 02:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=j2lALfWI5j4Y4Irc7w5pOxYdn11lnIHXe8iu+6ejMHs=; b=DEgRmWuT5CFz0y4lr1EES1mAVe1HOk1qo2T7FrfAqX0HAbChQPujzFLo5F529CH07I r+r0pK6MmeJZxO2ZiFACIOP0WH9B0WD7ZkNvHEXg9USmm8dIsYUbabzcGWyyDiubh9rM TFD1hPPxOEVupPKE4u02oCuxcdoXFZU0oRU80= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=j2lALfWI5j4Y4Irc7w5pOxYdn11lnIHXe8iu+6ejMHs=; b=ZTVu4QVc6jl1PIjuxRfbbRpF0j4eonz6FypcBY4+SeNv85WT7jiZ3gxzblLDegRQ6s pZL0xL0nkKhB9OkxiIjIMtpQfzkEPGLFU1ZNwjo2wpL8g72E/V/+et+WSg5cqOvMYfWP PCusWxDbNQXMM+f9Im44YNKrATU2zWl2Pknx54g9Ts+Vog7J0qKZ7xmX77Cix/kNhagw rA6bZH1Z9TPZEMF16ZwImsallA0yoPwZ7g/7ViyvK2GCuXc58bEkf+A1wd7i2m5EbFTE ExNtHvCuYw6xyEpaGZ3SsN3/infcQlGbjsBRyplg2KRjdGcPmNjwpvvYT3CuCDA3FTFd SJtQ== X-Gm-Message-State: ALoCoQkfCdSwYFxIolK3IgKGT+6VUoNKhMr0quhGgIJnjvaNEX0GRBBKEAwS3ifwMMN/PqIwi7T7 MIME-Version: 1.0 X-Received: by 10.180.14.134 with SMTP id p6mr19805346wic.44.1431940592809; Mon, 18 May 2015 02:16:32 -0700 (PDT) Received: by 10.194.38.104 with HTTP; Mon, 18 May 2015 02:16:32 -0700 (PDT) In-Reply-To: References: <1427123731-15654-1-git-send-email-pboldin@mirantis.com> <1427994080-10163-1-git-send-email-pboldin@mirantis.com> <1427994080-10163-2-git-send-email-pboldin@mirantis.com> Date: Mon, 18 May 2015 12:16:32 +0300 Message-ID: From: Pavel Boldin To: "Xie, Huawei" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v4 1/5] vhost: eventfd_link: moving ioctl to a function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2015 09:16:33 -0000 On Mon, May 18, 2015 at 9:06 AM, Xie, Huawei wrote: > On 5/7/2015 9:17 PM, Pavel Boldin wrote: > > > On Thu, May 7, 2015 at 10:57 AM, Xie, Huawei huawei.xie@intel.com>> wrote: > On 4/3/2015 1:02 AM, Pavel Boldin wrote: > > Move ioctl `EVENTFD_COPY' handler code to an inline function. > Pavel: > There is no necessity to inline this function. > Xie, there is even no necessity to split this in a five piece patchseries. > I did that solely for the purpose of clean reading. > > There is no necessity to inline any single-used functions as long the > compiler is decent. But I prefer to instruct compiler to do this explictly > so there is no call/ret path in the generated code. > > The purpose of inline or not is not for friendly reading. inline is for > performance only. > Well, an optimizing compiler `inline's all the `static' functions that are called only once in the file. So, this `inline' is purely for readability of the code. This makes user aware that the function will be `inline'd anyway. Pavel > > > > /huawei > > >