From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id F25628D9E for ; Wed, 28 Oct 2015 19:35:29 +0100 (CET) Received: by wikq8 with SMTP id q8so263896564wik.1 for ; Wed, 28 Oct 2015 11:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=qahk5vvEJeNBkjN2yVjgCi9h/vc9QThkKOrmL5r957Y=; b=j3SMuWfcyd53tVSz0smjGxXHJpVOXKksNRZIqpCuL3VTPuXm4ST1fwJWxo4TCkn8Pv ozeQg7GxwniVvZnVlDbabn9wnQ21n+NHn2q+y2d/rGh7p8+4VbgTUxv6YXnVoo9/kibl 81rxGYuMJyG/xYvcbLYPUSyyhZ8keyYPh/3do= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=qahk5vvEJeNBkjN2yVjgCi9h/vc9QThkKOrmL5r957Y=; b=E+ertLD9Boyh0spIdz8GX5n8b5f6d6PD7uavfxcMqyswgWuxgHlQm3CoaUYC57DcmK 0b1RjadG9NnBKHzE5DsNj1BTqtWTQv4vT7uhT95LtWSJwdZgddfoSUeyjtWrbR9brXw6 um4FHiDtaQ34XZJVd6J5+3Scj47dOReUHDoTSXjUICZWv6xvc7jDzSa+jJQUaNsTRGqc iAe2fPLi2gbfNJG5FU9BfeUaUqrb359mQsURhzMisK40v+Augoo3AZGvk/4Eq8Xx+NTX D4tqKf9LnrXZ0Q5F5VsIbSkay9q9Jk3qWqTqxW+quxkuDUujIAOvtjfYsD58hbmHDwsZ 8aYg== X-Gm-Message-State: ALoCoQk3BGCvmr/h/r4j+nvCWSxz15IUw+wyjMNAbeFRPo7l6uRA0cEfyzi9Ls20K5xOUm/KZMyW MIME-Version: 1.0 X-Received: by 10.180.86.71 with SMTP id n7mr4364972wiz.91.1446057329790; Wed, 28 Oct 2015 11:35:29 -0700 (PDT) Received: by 10.194.127.199 with HTTP; Wed, 28 Oct 2015 11:35:29 -0700 (PDT) In-Reply-To: References: <1429184910-30186-2-git-send-email-pboldin@mirantis.com> <1440787880-7079-3-git-send-email-pboldin@mirantis.com> Date: Wed, 28 Oct 2015 20:35:29 +0200 Message-ID: From: Pavel Boldin To: "Xie, Huawei" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v5 3/4] vhost: using EVENTFD_COPY2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2015 18:35:30 -0000 Huawei, Thomas, Please find an updated patchset in the appropriate mail thread. With best regards, Pavel On Mon, Oct 26, 2015 at 3:45 AM, Xie, Huawei wrote: > On 10/21/2015 8:16 PM, Pavel Boldin wrote: > > Xie, > > > > Please find my comments intermixed below. > > > > On Tue, Oct 20, 2015 at 12:52 PM, Xie, Huawei > > wrote: > > > > Thanks Pavel for this work. > > This is what we think is the better implementation for eventfd > > proxy, in > > our last review. > > Could you add an additional patch to remove the old implementation? > > > > I'm not really sure if we should do it -- imagine upgrading from one > > version of DPDK to another. > > Given the current implementation there is a backward compatibility. > I couldn't image the case any one would run old dpdk app with the new > dpdk module. However I am ok you leave it here, :), we could remove this > in next release. > Could you finish rebasing the patch before end of next week, otherwise > it will lose chance of being merged. > > > > > > > > Again, please run checkpatch.pl against > > your patch. > > > > Oops. Thanks for pointing out. > > > > > > On 8/29/2015 2:51 AM, Pavel Boldin wrote: > > > > [...] > > > + > > > +int > > > +eventfd_init(void) > > > +{ > > > + if (eventfd_link > 0) > > 0 could be valid fd. Change it to: > > > > Got it. Thanks. > > > > > > if (eventfd_link >= 0) > > Change elsewhere if i miss it. > > > +int > > > +eventfd_free(void) > > > +{ > > > + if (eventfd_link > 0) > > same as above: > > if (eventfd_link >= 0) > > > > [...] > > > > > > -- > > Sincerely, > > Pavel > >