From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pboldin@mirantis.com>
Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 042D95A73
 for <dev@dpdk.org>; Fri, 27 Mar 2015 13:36:47 +0100 (CET)
Received: by wgra20 with SMTP id a20so97486623wgr.3
 for <dev@dpdk.org>; Fri, 27 Mar 2015 05:36:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com; s=google;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=xlAuCmPr+M93iQD4kkpA+elP8CP9xWFwJ64MJk4RkXc=;
 b=gBDFnE+sm/II5ZJ6aGt5u1dij2aPfUfoqL7g3wctDFid41qiH1+wuJwU3eznViBVuy
 QVhaAithKBenoXf5WrJqufacDKnugFt9tS6x/ml0dAQl5c2Vw8Ozr99aFMW8EiQ2DZwk
 aFuExKwctAZbFYQeUuwud0N82NZVMaOMF4eWE=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=xlAuCmPr+M93iQD4kkpA+elP8CP9xWFwJ64MJk4RkXc=;
 b=YcJPAIizC9wXJG5fzUPDH27o3CRVeBvuTMy+QI+nZxXpfTT6nMwa4A/3Beb37cngoV
 f7jplXLHSvv0OLV3W8PmYgjU236honUkxobTmhNEswYZLcFTPyw1i+2FAalSTfS6bQvX
 xucaaYbbqX6RvmlGbTF6RJSZ9vP03LOIwQ0a4e12bDMRFw7axYkgv3bdJpTDQiI5WQ0d
 ZFM/uAY6Uo/hNcyqfIjw/oLQl1aDfn00Q3dABIvgCiN4Chf7Y6j1k95eKp/+NxUHMgGO
 v4RM73P/Z7nAJHH/PhIo1Ev3qTuk/fh/6kRyEeJufimNvBzSzyjMXy5XHGWnpejqDw/k
 P3Hw==
X-Gm-Message-State: ALoCoQn7rTbqBH9BZxtJ4u2NFIEYBmhGdESU273Kk3pKS3P2LXaBCaT4sffQemN/rt0Zjnugpq+3
MIME-Version: 1.0
X-Received: by 10.180.104.35 with SMTP id gb3mr56245010wib.60.1427459806823;
 Fri, 27 Mar 2015 05:36:46 -0700 (PDT)
Received: by 10.194.76.7 with HTTP; Fri, 27 Mar 2015 05:36:46 -0700 (PDT)
In-Reply-To: <15186425.TaoBqciV4t@xps13>
References: <1427115225-14489-1-git-send-email-pboldin@mirantis.com>
 <C37D651A908B024F974696C65296B57B0F3FB942@SHSMSX101.ccr.corp.intel.com>
 <15186425.TaoBqciV4t@xps13>
Date: Fri, 27 Mar 2015 14:36:46 +0200
Message-ID: <CACf4_B9ims0bL3fqk5Pm6sTHkm7pdHcTgFNXLvKYZf5Gip9LDg@mail.gmail.com>
From: Pavel Boldin <pboldin@mirantis.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vhost: Fix `struct file' leakage in
	`eventfd_link'
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Mar 2015 12:36:47 -0000

On Fri, Mar 27, 2015 at 1:10 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:

> > > Due to increased `struct file's reference counter subsequent call
> > > to `filp_close' does not free the `struct file'. Prepend `fput' call
> > > to decrease the reference counter.
> > >
> > > Signed-off-by: Pavel Boldin <pboldin@mirantis.com>
> >
> > Acked-by Huawei Xie <huawei.xie@intel.com>
>
> Applied, thanks
>

What should I do with the refactoring patch in your opinion?

Should I split it in parts to ease review?

Pavel