From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pboldin@mirantis.com>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id B02AB8D8D
 for <dev@dpdk.org>; Wed, 21 Oct 2015 14:16:31 +0200 (CEST)
Received: by wijp11 with SMTP id p11so91973508wij.0
 for <dev@dpdk.org>; Wed, 21 Oct 2015 05:16:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com; s=google;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=Xbo8+xuN6lQlAnBmVTfGR9XQ0M5+0OJpFlMnczeungg=;
 b=V8XDX8G4aWZ2sC9M5a7INf9ytKDbmytBriQnKmO1LJZTvePrV7V/rMZrpH67ZU5X8T
 gFJoVxTUVPAnPBIEkcbpTSUTS0aeHu0BaVEpMUmOBEbjNfGsvXqexFMo9E8HvGrFdjhm
 r1r2q2v1XExHZuCG0YoY19gIsMYttt7ysHzls=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc:content-type;
 bh=Xbo8+xuN6lQlAnBmVTfGR9XQ0M5+0OJpFlMnczeungg=;
 b=mLIT55tvoClulWxqPq0Yw8zCwjaVI5nNAprJIkxaiLx5aQUtbO49jt6NvtdajSG6l6
 gr6g1RxaJWMhMWTVrQ9VIUp4MJ8z8lDG3zqRUCI3o7A+wRHMvea8kzVVE2sg/BBntJss
 ApZC2SMlcLx0e6N5LPOejHp2kGsw/pfu+i6Nnba53mLx33NgZY/JpzVfnKbM6+2NnEd6
 Tq6oS+dqp1X6Q+QeDjLmYK3kaGeZuEAgcOx7HOF6TBLEWef3DHjoPQVKPAy5PqgAM/Gn
 N9gXr4fDF6T9yjvfjEtkcoFBzDw9j9ItPptTMlApV4yPH3OjitZL25UcS+U55MOKY0eb
 maSQ==
X-Gm-Message-State: ALoCoQmJwkpAlj4bzLKvxhhOf1bkOb8iVmvTrbt3ymeswuWYSu2RXr+SramayDxPGepsl9bQpDux
MIME-Version: 1.0
X-Received: by 10.180.188.169 with SMTP id gb9mr10164384wic.44.1445429791486; 
 Wed, 21 Oct 2015 05:16:31 -0700 (PDT)
Received: by 10.194.127.199 with HTTP; Wed, 21 Oct 2015 05:16:31 -0700 (PDT)
In-Reply-To: <C37D651A908B024F974696C65296B57B4B12F6BE@SHSMSX101.ccr.corp.intel.com>
References: <1429184910-30186-2-git-send-email-pboldin@mirantis.com>
 <1440787880-7079-3-git-send-email-pboldin@mirantis.com>
 <C37D651A908B024F974696C65296B57B4B12F6BE@SHSMSX101.ccr.corp.intel.com>
Date: Wed, 21 Oct 2015 15:16:31 +0300
Message-ID: <CACf4_B_c6Pfp6pYO8EeC1Q3b5Ww6thhV8Xp0wPjwJYYbQ=2ccg@mail.gmail.com>
From: Pavel Boldin <pboldin@mirantis.com>
To: "Xie, Huawei" <huawei.xie@intel.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 3/4] vhost: using EVENTFD_COPY2
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Oct 2015 12:16:31 -0000

Xie,

Please find my comments intermixed below.

On Tue, Oct 20, 2015 at 12:52 PM, Xie, Huawei <huawei.xie@intel.com> wrote:

> Thanks Pavel for this work.
> This is what we think is the better implementation for eventfd proxy, in
> our last review.
> Could you add an additional patch to remove the old implementation?
>
I'm not really sure if we should do it -- imagine upgrading from one
version of DPDK to another.
Given the current implementation there is a backward compatibility.


>
> Again, please run checkpatch.pl against your patch.
>
Oops. Thanks for pointing out.


> On 8/29/2015 2:51 AM, Pavel Boldin wrote:
>
> [...]
> > +
> > +int
> > +eventfd_init(void)
> > +{
> > +     if (eventfd_link > 0)
> 0 could be valid fd. Change it to:
>
Got it. Thanks.


>     if (eventfd_link >= 0)
> Change elsewhere if i miss it.
> > +int
> > +eventfd_free(void)
> > +{
> > +     if (eventfd_link > 0)
> same as above:
>     if (eventfd_link >= 0)
>
> [...]
>

--
Sincerely,
 Pavel