From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f170.google.com (mail-ua0-f170.google.com [209.85.217.170]) by dpdk.org (Postfix) with ESMTP id DD0C95A44 for ; Wed, 4 Jan 2017 15:43:48 +0100 (CET) Received: by mail-ua0-f170.google.com with SMTP id i68so247330203uad.0 for ; Wed, 04 Jan 2017 06:43:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=o4Cl1uuhx0agABIm6WlH7znS+2yJqpFciVOi02ZOTts=; b=Ule8f5kexnq1YXHbR6tK2uLHkucpXmOVY39VsaZqowXPJJFnvd1vkWvP7vfAe3h2VQ T5CGwai9NuiDmjGqqFyhcL9VzXntxhn0k9XcKVUjhmkD8/BmSnrlOE3mR0Y7fWXrVmLl Av3FBYNhlzp1wcxbUdGTmhLDvI5rim9Bahb3kXKevC1HzFvu1X1sWowNrAA8A7grROu3 YxmSwstdYRSE1eIdmFwCn5gGEwN+r/QuGxe7kfF9FVD62nBgP3TYkonOt4LMDjXxzHry JmBYo8KPzw4PZO2gezNb0Ic3thpcZt6zIlG6T+CGp/42aTwR7aqPlgLQBGrkdYW7t1QQ hPuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=o4Cl1uuhx0agABIm6WlH7znS+2yJqpFciVOi02ZOTts=; b=c5FVj3gTh4AXAgrge1rPm6k1NEeW5mV0vog5rapT4LWbJrI0Az2hMubPGnqGFTG4tM 2Jeb96pGcX1NiqEY6EaazqZZiCIYq+EQ0HxGoLcrxzOm9631OhnZ4pj6re1h2aukXLVU popXT3WrIWsHzmcaqpXVl2gxURjgQHTlA561DXilspdhbuN3Okw7CQadExL+MLWpUXJu ILMt9fsW8ha+JmsS2b7Kf6FvxOlxitrEPDAGKVbdWgz3NmmTRVdLI2KodxzxfsMU9tsm TrM45yN3bfY2abrik0rZaEi9Bkxb4HkhKAPtxke8txzuN58bB1PD3H03pndTM+gAJOiU P7HQ== X-Gm-Message-State: AIkVDXLpgT3PlACpwRKBV5cTvbLJx9zmqHoSJyiJQi9TrQ1bM5OtDLIb/G8iR7KP61qNrJkJF79hbd4FINtFC/f3 X-Received: by 10.159.48.65 with SMTP id i1mr50090699uab.12.1483541028074; Wed, 04 Jan 2017 06:43:48 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.46.3 with HTTP; Wed, 4 Jan 2017 06:43:47 -0800 (PST) In-Reply-To: References: <1482243237-28625-1-git-send-email-alejandro.lucero@netronome.com> From: Alejandro Lucero Date: Wed, 4 Jan 2017 15:43:47 +0100 Message-ID: To: Ferruh Yigit Cc: dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] nfp: add support for new metadata api X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 14:43:49 -0000 Hi Ferruh, On Wed, Jan 4, 2017 at 3:15 PM, Ferruh Yigit wrote: > On 12/20/2016 2:13 PM, Alejandro Lucero wrote: > > NFP is a smart programmable NIC and firmware is deployed for specific > > system needs, like offloading OVS, vRouter, contrack or eBPF into the > > hardware. This often requires to give metadata to the host within > > packets delivered. Last NFP firmware implementations support richer > > metadata api facilitating interaction between firmware and host code. > > > > Old way of handling metadata needs to be still there for supporting > > old firmware. > > > > Signed-off-by: Alejandro Lucero > > --- > > <...> > > > + > > + } else if (NFP_DESC_META_LEN(rxd)) { > > + meta_offset = (uint8_t *)mbuf->buf_addr; > > + meta_info = rte_be_to_cpu_32(*(uint32_t *)meta_offset); > > + meta_offset += 4; > > + /* NFP PMD just supports metadata for hashing */ > > + switch (meta_info & NFP_NET_META_FIELD_MASK) { > > + case NFP_NET_META_HASH: > > + meta_info >>= NFP_NET_META_FIELD_SIZE; > > + hash = rte_be_to_cpu_32(*(uint32_t *)meta_offset); > > + hash_type = meta_info && NFP_NET_META_FIELD_MASK; > > I already applied this patch but above "&&" looks wrong. > Most probably intention is "bitwise AND" (&), do you want me fix this as > "&" or remove the patch completely to replace with new version? > > Yes, that is wrong. I wonder how related tests did not fail. I'll check that right now. Maybe it is better to wait for another patch version or at least to be sure that simple change is good enough. Let me to peer into those tests and re-run them with that fix applied. > Thanks, > ferruh > >