From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f180.google.com (mail-ua0-f180.google.com [209.85.217.180]) by dpdk.org (Postfix) with ESMTP id 12375FB40 for ; Tue, 20 Dec 2016 12:02:54 +0100 (CET) Received: by mail-ua0-f180.google.com with SMTP id b56so13123168uaa.0 for ; Tue, 20 Dec 2016 03:02:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=2P2pwoeCtezd5H7SeurpUmqJh8fgTFt6ITRW56E6NCw=; b=L48gqMQhWVpPsdVU33xO51ZXcmjPOjLQXj+syERdWRBawrwcrNZZp03+guWREBF+Co FKkrbT6+fhE6w+wcEvvyu83HSTnIVqMhbVI1XEac+utVdVwTZqECa3t1vv3OmkGE/naG F+X/Sq+4EZHFHQcCOHo+YxSssS+xxuCVcCSNasZYU9h+vzvSjU4B/6FenYNurTwZT6po KKrKNJCJxIAvlKscxIgoE1u30YnWkSlVSn9BHdEf2R7vPXriCRiQuisu78iuzp/63pS2 epFGH4+R7qoLSoZudZse6ScZwoX/wYHz0IItzpT1ypoZ23qkGTwZL6xiREV8zyblNX6U TpMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2P2pwoeCtezd5H7SeurpUmqJh8fgTFt6ITRW56E6NCw=; b=cyjjwSm+j672hliv+L/JRAtTg98987BEJeSgp3cnhV/NgRzjOJ6dUi7j0zQaOj1Oq9 cMWunAo6wxQA4ZLdzR8RKQZoppRJeXwyYSr6y5nUwaOZOj9UbKjU3P0w1nlFA0ZL69pd Tex4ijLzu7vwOG3K1Vb4ULQvd/chZQ1C02daXX2nzFfKDfAKxJ9GW3xh22l608349y3u qFxS9HwqwEjr/838kzS5BA3vyvQXlxy4ojONmpwcZ2nqvIGnGetbbwIZ/aXkRADX4tAg tCodwEr6W8ipQrU3Y/47P1aQ9QBDkT1J4XLxAg8/qqFPqImJyJDVx/g/rkO+rihT4FVD ju4g== X-Gm-Message-State: AKaTC00y/nt/Ef1r0YbMHy+FOAw9wHTZliqYgpfwnBm2eY+EHVKb3V3jG4tPZFo0BmlTCyfOlryzPbBJa1ND4qVE X-Received: by 10.176.74.26 with SMTP id q26mr15926443uae.100.1482231774302; Tue, 20 Dec 2016 03:02:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.46.3 with HTTP; Tue, 20 Dec 2016 03:02:53 -0800 (PST) In-Reply-To: References: <1482149104-40805-1-git-send-email-alejandro.lucero@netronome.com> <3dd84942-5c7b-5f3f-2760-a71f97dfcd6a@intel.com> From: Alejandro Lucero Date: Tue, 20 Dec 2016 11:02:53 +0000 Message-ID: To: Ferruh Yigit Cc: dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] nfp: extend speed capabilities advertised X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 11:02:55 -0000 On Tue, Dec 20, 2016 at 10:29 AM, Alejandro Lucero < alejandro.lucero@netronome.com> wrote: > > > On Tue, Dec 20, 2016 at 10:25 AM, Ferruh Yigit > wrote: > >> On 12/19/2016 6:00 PM, Alejandro Lucero wrote: >> > I forgot one thing: to update the features file with this new one. >> > >> > I will wait for your feedback regarding the discussed problem for >> > sending another version. >> >> I think it is good to go, please send updated version. >> >> > OK > > >> > >> >> <...> >> >> > >> > Sorry, confused. Is it like following: >> > >> > " >> > For new FW, there is no problem, it supports the range between >> > 1G - 50G, >> > and reports correct current speed. >> > >> > With old FW, device still can be set to speed range between 1G - >> > 50G, >> > but it doesn't report current speed correct, and DPDK driver >> reports >> > back to application as device current speed is 40G, without >> really >> > knowing the current speed. >> > " >> > >> > >> > Yes, that is. Should then I do anything else or the patch is right >> > for you now? >> >> So, this patch is correct. >> >> But for the previous patch "net/nfp: report link speed using hardware >> info", it would be nice to add above information into source as comment >> and into commit log. >> If you can, would you mind sending a new version of that patch? >> >> > Would it be better to report ETH_SPEED_NUM_NONE instead of ETH_SPEED_NUM_40G for old firmware? I will add a comment about why, but I think this is better for the user not getting (sometimes) the right speed. > I'll do it. > > Thanks! > > >> Thanks, >> ferruh >> >> > >> <...> >> > >