From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by dpdk.org (Postfix) with ESMTP id 391B21B161 for ; Fri, 5 Oct 2018 19:00:20 +0200 (CEST) Received: by mail-ed1-f50.google.com with SMTP id c26-v6so4541015edt.3 for ; Fri, 05 Oct 2018 10:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+oxLoSFdyzxIdE6Nc3dXpeKi7fnCnpwJtNA5B2DltPE=; b=ClIWVOQ9BNobhfoB7vk971wuVRst/qr1c03RI2zNoW/XG9ScOniP9YeOBUJtj3O90w wA2pSh+/4b/Izpf4bB4bzCjf4bLxTCLrxJ9hJswlgPrQZAkZXh4y4Xow5LccUiDm+0hq rSlSbS75ARP3B3mp11W7KzjAbtzIkhlslmK6RplQo9VoDsR6Y2hwZhj7drIQD+W+628r bXFOzPxeNNSckGvdEWh3ewQpqbMgvi7YGXbkX7Q8J4xH/CKdT5fEa7ho9cC5QwfEsvHg XqZAuRraJxLFoZAYfq3Ts2sN/UjXW/sX4rNVp6ITL0p5eyK7dToqhYfLOLCquCWzp6Dv 4khg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+oxLoSFdyzxIdE6Nc3dXpeKi7fnCnpwJtNA5B2DltPE=; b=HJY71Oha5luyYlohrziR3bvuxuSwAtyjd+XqHlGdJUk93JXZVedOuX0kDxoWnIzt4y be005fiVCEGV3nAkZ8UiOYyZ62AuA680CtgnE3Eb3mXocLDfIDFzlg0JOo0TnaDYUAck PhXcFU09x7KwtTdimeqpbXzG0MhdF2xL6G/f1pKwxpMGbuwYZ6E7XmnSJREfUhgyz1NZ r4hkXuq4+VSlLhp13vqoaaoVsghWpljtuZWMep2KMzmq4yzW+47vALZhY25lrIa/G/Qy 1aDIKFNz75DZYsI3yE2xRO8Bz0LzDshjT/hKTrLzTzFSkqOJNUCnN9mT22a8HFHMaxD7 ZUEA== X-Gm-Message-State: ABuFfohC7uCYLm/afuzIF7v6S7EbRmdiiEntfNiK17pzDuqp1Cp/BBZu 2/h1gWpxcoBOI+6T2lyA+trXg3D9rDGknJcmc+GDzaHD X-Google-Smtp-Source: ACcGV63EY8/Q0+ycN1SMk9wVI8jGFDSZv9Ui84BweCCcAltSD4+U6fQ30M2FxCpElbVBW640R94rv+ec0KBs1qzXims= X-Received: by 2002:a50:ef03:: with SMTP id m3-v6mr10858437eds.136.1538758819779; Fri, 05 Oct 2018 10:00:19 -0700 (PDT) MIME-Version: 1.0 References: <1538756211-9359-1-git-send-email-alejandro.lucero@netronome.com> <745d26fa-3215-4c16-15d5-31f9a6922d82@solarflare.com> In-Reply-To: <745d26fa-3215-4c16-15d5-31f9a6922d82@solarflare.com> From: Alejandro Lucero Date: Fri, 5 Oct 2018 18:00:08 +0100 Message-ID: To: Andrew Rybchenko Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add field for device data per process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 17:00:20 -0000 On Fri, Oct 5, 2018 at 5:37 PM Andrew Rybchenko wrote: > On 10/5/18 7:16 PM, Alejandro Lucero wrote: > > Primary and secondary processes share a per-device private data. With > current design it is not possible to have data per-device per-process. > This is required for handling properly the CPP interface inside the NFP > PMD with multiprocess support. > > There is also at least another PMD driver, tap, with similar > requirements for per-process device data. > > v2: > - changing library version > - report shared library change in release notes > > Signed-off-by: Alejandro Lucero > --- > doc/guides/rel_notes/release_18_11.rst | 1 + > lib/librte_ethdev/Makefile | 2 +- > lib/librte_ethdev/meson.build | 2 +- > lib/librte_ethdev/rte_ethdev_core.h | 8 +++++++- > 4 files changed, 10 insertions(+), 3 deletions(-) > > diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst > index c806dc6..32ab754 100644 > --- a/doc/guides/rel_notes/release_18_11.rst > +++ b/doc/guides/rel_notes/release_18_11.rst > @@ -189,6 +189,7 @@ Shared Library Versions > librte_acl.so.2 > + librte_cfgfile.so.2 > librte_cmdline.so.2 > + + librte_ethdev.so.2 > > > It is a comment section. Actual library version is librte_ethdev.so.10 > below. > So, it should add + sign and change to so.11 > > I has the + sign but you are right about the version number. I will fix that. Thanks > > This section is a comment. Do not overwrite or remove it. > ========================================================= > diff --git a/lib/librte_ethdev/Makefile b/lib/librte_ethdev/Makefile > index d720dd2..e27bcd5 100644 > --- a/lib/librte_ethdev/Makefile > +++ b/lib/librte_ethdev/Makefile > @@ -16,7 +16,7 @@ LDLIBS += -lrte_mbuf -lrte_kvargs > > EXPORT_MAP := rte_ethdev_version.map > > -LIBABIVER := 10 > +LIBABIVER := 11 > > SRCS-y += ethdev_private.c > SRCS-y += rte_ethdev.c > diff --git a/lib/librte_ethdev/meson.build b/lib/librte_ethdev/meson.build > index 172e302..6783013 100644 > --- a/lib/librte_ethdev/meson.build > +++ b/lib/librte_ethdev/meson.build > @@ -2,7 +2,7 @@ > # Copyright(c) 2017 Intel Corporation > > name = 'ethdev' > -version = 10 > +version = 11 > allow_experimental_apis = true > sources = files('ethdev_private.c', > 'ethdev_profile.c', > diff --git a/lib/librte_ethdev/rte_ethdev_core.h b/lib/librte_ethdev/rte_ethdev_core.h > index 33d12b3..0d28fd9 100644 > --- a/lib/librte_ethdev/rte_ethdev_core.h > +++ b/lib/librte_ethdev/rte_ethdev_core.h > @@ -539,7 +539,13 @@ struct rte_eth_dev { > eth_rx_burst_t rx_pkt_burst; /**< Pointer to PMD receive function. */ > eth_tx_burst_t tx_pkt_burst; /**< Pointer to PMD transmit function. */ > eth_tx_prep_t tx_pkt_prepare; /**< Pointer to PMD transmit prepare function. */ > - struct rte_eth_dev_data *data; /**< Pointer to device data */ > + /** > + * Next two fields are per-device data but *data is shared between > + * primary and secondary processes and *process_private is per-process > + * private. The second one is managed by PMDs if necessary. > + */ > > > I think above is wrong from doxygen point of view. 'data' member already > has > documentation. I'm not sure, so it should be checked. > > I though doxygen would use just the comment after the fields declaration. Not sure how to handle this. Should I remove the comment and just leave the next two lines? > + struct rte_eth_dev_data *data; /**< Pointer to device data. */ > + void *process_private; /**< Pointer to per-process device data. */ > const struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */ > struct rte_device *device; /**< Backing device */ > struct rte_intr_handle *intr_handle; /**< Device interrupt handle */ > > >