From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f44.google.com (mail-oi0-f44.google.com [209.85.218.44]) by dpdk.org (Postfix) with ESMTP id 3B6855A31 for ; Fri, 27 Nov 2015 08:51:10 +0100 (CET) Received: by oiww189 with SMTP id w189so57791458oiw.3 for ; Thu, 26 Nov 2015 23:51:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=hCbz9BUuPr08fOBRgbaEIu7zP+dNtDZtmMLYquuJTGY=; b=zzxt/L60Xewo37GNgGllasFV0qbX/TT/Qd2f0GyVBHYmfDcI38m49Z0a9HKVOvq80w sZPlvDxTbN//rmgq+Wsu/HygZkU5U3cc1Lw477QOyFwc2ncVocMpvNg6DO3JMPwbiERy iyDSTM62no5EtlypDd7ng8XeSp8bQKSJ9TggwBLQ5kNLLBzxuBw+n+sQdjGoAiK7ToNO J+1MxFiUFwZCwmc3T6IE1iIT5MQ8JE5VhfSgArJQJlmZ4axivftC+4EGiceqM/DWA74W X782QOoZjWHoW4pwk50M7xJ4Hag16LV7GBHFzdU7kE//LTFdM/zZpCQJA5vRm59OqDon rKug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=hCbz9BUuPr08fOBRgbaEIu7zP+dNtDZtmMLYquuJTGY=; b=ZAFvBua8oN8mFUdtFEdePB/D4eMLymsvoaIsEDdYJhYUR22wrOYzSkcXw5dE8V4RPr /SlhXCHBJECmIdxQH4LVGXkWAxD5+xZv51IdgEw7ue1kaPtOBHAdhAXfduTlUmTWwB+x lVRtqE+WS8bFHC2ANlnzQRdsVmhpVzfYFZUkbOfgl9A+RLHCs02LjLHSdr64dBU36JUt AmvYePSB0eVtLPcXXNdgLluAs+uQjkawYdXM7gfKY9ysZ2ZyCVWP85CgGgNJ74jNr3hR mhHcZ36VwsHxs+6lCuQ0KSA36gDSpcfNx7cXPEsV5zot9GAXs2Wb4CD9ixBT1sijQiib TJzw== X-Gm-Message-State: ALoCoQlWXCOF7zbTTYBeUR11SInu2LArTPijb+w01vIFzDChPofF/7fwTYcNRoy5Wsos+nJq1kbw MIME-Version: 1.0 X-Received: by 10.202.90.137 with SMTP id o131mr30429078oib.83.1448610669640; Thu, 26 Nov 2015 23:51:09 -0800 (PST) Received: by 10.76.150.99 with HTTP; Thu, 26 Nov 2015 23:51:09 -0800 (PST) In-Reply-To: <20151126101449.3f450a14@xeon-e3> References: <1448531369-8808-1-git-send-email-alejandro.lucero@netronome.com> <1448531369-8808-2-git-send-email-alejandro.lucero@netronome.com> <20151126101449.3f450a14@xeon-e3> Date: Fri, 27 Nov 2015 07:51:09 +0000 Message-ID: From: Alejandro Lucero To: Stephen Hemminger Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev Subject: Re: [dpdk-dev] [PATCH v9 1/9] nfp: basic initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2015 07:51:10 -0000 I converted (almost) all the Linux typedefs. This one went under the radar. We do not have such thing like ixgbe/base but maybe it makes sense. Should I send a new patchset version for fixing this "minor nit"? Thanks On Thu, Nov 26, 2015 at 6:14 PM, Stephen Hemminger < stephen@networkplumber.org> wrote: > On Thu, 26 Nov 2015 09:49:21 +0000 > Alejandro Lucero wrote: > > > +static inline void > > +nfp_qcp_ptr_add(__u8 *q, enum nfp_qcp_ptr ptr, uint32_t val) > > +{ > > + uint32_t off; > > Minor nit. why mix use of Linux specific basic size typedefs (__u8) > with Posix standard values (uint32_t). The DPDK style is to use > the Posix types except in kernel drivers or code that is coming > from unified drivers (ie ixgbe/base) >