From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alejandro.lucero@netronome.com>
Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67])
 by dpdk.org (Postfix) with ESMTP id 54D66322C
 for <dev@dpdk.org>; Sat, 31 Mar 2018 18:53:36 +0200 (CEST)
Received: by mail-wm0-f67.google.com with SMTP id l9so19598552wmh.2
 for <dev@dpdk.org>; Sat, 31 Mar 2018 09:53:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=netronome-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=YrUjUeEZTNWBnKuA++wbp1Gsz9yVoV836Oj7B9/39zU=;
 b=y+mWGJrg6U2g86rjrH+ACS3xeC3SHUxbT+gzTbhvpn2ehvMJy/dEh162oT+K1/ei4u
 Mart02dgz8Z0YlPMTrNsBOxzy3V+NG6TYdxrnL7I/UjBDxAK7uYKP8tW7BlVEiyBIrdI
 yNTjonTzB0o6Ex9p5UL3hOlV0H9V/sHlvDp/Fl2ZQKX/6XqqrzcnfFqkMtq6bhVUJyLj
 eIbSc4uUq9I52/60FY3Fum4dO5EijDCj+eJwFB7/qLNREFd5q54qmEbOBUYpNls71sd6
 OdelUN84fiDDhpA7j4owaN/7kzwEBWne62etLC4Wl+IcZbEKjp2PE953asU4l9Le0FgW
 NDog==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=YrUjUeEZTNWBnKuA++wbp1Gsz9yVoV836Oj7B9/39zU=;
 b=R/Y9OY9oSG4AcFQTqZGdXg1Y6sAXjkBf9Lc3vSWFH5S9TEDw3wNWiOuEn79765LJOY
 tIU3YFoM+ggyh5UDAagD3guPZSWjgE1poblqw2KMjnbDfqWaR2fjBK5Va986QO/NEqlz
 t7XmxCglX+70QJY2sYVAS7ir5GfiTapZGwmWt7t99n8RoEBh1C9CvdmAhZD5H1i7jCIC
 npxIb6OGYwSnVWxMrAoeu+xgNgQB8kX7f78Iyok6zIEHzfZt0LUI8pIEMVU8W5Je1BWu
 UfPZMJDCQ3GFb5CqVgfniih1uOOWA7dh3kYTbfzQrnzM5yaSfo8khnZrsui5rlyaoqSS
 l7kw==
X-Gm-Message-State: AElRT7FKT+QfwoLCUIxlkk99kytUjePBjaBbThBWjCf5QleAuPOuSV8M
 kgYXtkVGeyY2BMYGg2lmIn55TDHJAoH67Z/h1AhonA==
X-Google-Smtp-Source: AIpwx4/sGFAFK4xkA0HOyCNOVqPFy/TVrTZI0yTJpOOqAwfu9qU14VSR2fpUqq61O5NtJNuGAnlRrHtrpGKszfe9OeM=
X-Received: by 10.80.179.230 with SMTP id t35mr6934893edd.173.1522515216003;
 Sat, 31 Mar 2018 09:53:36 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.80.201.8 with HTTP; Sat, 31 Mar 2018 09:53:35 -0700 (PDT)
In-Reply-To: <1c209b93-bdba-cff7-cb70-4971e80997d0@intel.com>
References: <1521124237-47243-1-git-send-email-alejandro.lucero@netronome.com>
 <1c209b93-bdba-cff7-cb70-4971e80997d0@intel.com>
From: Alejandro Lucero <alejandro.lucero@netronome.com>
Date: Sat, 31 Mar 2018 17:53:35 +0100
Message-ID: <CAD+H990MftyWwLSCzfK07PzwsgY1rSA+5JdSPGDKywHbNBP3HQ@mail.gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH] net/nfp: support new HW offloads API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 31 Mar 2018 16:53:36 -0000

On Tue, Mar 27, 2018 at 7:25 PM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:

> On 3/15/2018 2:30 PM, Alejandro Lucero wrote:
> > In next 18.05 the old hw offload API will be removed. This patch adds
> > support for just the new hw offload API.
> >
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
>
> <...>
>
> > -     if (rxmode->enable_scatter) {
> > +     if (!(rxmode->offloads & DEV_RX_OFFLOAD_CRC_STRIP))
> > +             PMD_INIT_LOG(INFO, "HW does strip CRC. No configurable!");
>
> Also this behavior is changing, not providing CRC_STRIP will be by default
> stripping [2], this check should be removed.
>
> [2]
> https://dpdk.org/ml/archives/dev/2018-March/093489.
> htmlhttps://dpdk.org/ml/archives/dev/2018-March/093489.html
>
> <...>
>
> > +     dev_conf = &dev->data->dev_conf;
> > +     rxmode = &dev_conf->rxmode;
> > +
> > +     if (rx_conf->offloads != rxmode->offloads) {
> > +             RTE_LOG(ERR, PMD, "queue %u rx offloads not as port
> offloads\n",
> > +                               queue_idx);
> > +             RTE_LOG(ERR, PMD, "\tport: %" PRIx64 "\n",
> rxmode->offloads);
> > +             RTE_LOG(ERR, PMD, "\tqueue: %" PRIx64 "\n",
> rx_conf->offloads);
> > +             return -EINVAL;
> > +     }
>
> The offload API is changing [1], this check is no more valid. If PMD is not
> supporting queue specific offload app will not send port offloads here.
>
> [1]
> https://dpdk.org/ml/archives/dev/2018-March/092978.html
>
> <...>
>
> > +     dev_conf = &dev->data->dev_conf;
> > +     txmode = &dev_conf->txmode;
> > +
> > +     if (tx_conf->offloads != txmode->offloads) {
> > +             RTE_LOG(ERR, PMD, "queue %u tx offloads not as port
> offloads",
> > +                               queue_idx);
> > +             return -EINVAL;
> > +     }
> > +
>
> Same as above.
>

Thank you for the review.

I will remove those checks and send a new path version.