From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id D76801B69B for ; Fri, 11 Jan 2019 13:15:21 +0100 (CET) Received: by mail-io1-f68.google.com with SMTP id b23so11999284ios.10 for ; Fri, 11 Jan 2019 04:15:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I80RtMkBuTNsT2Wy6qv/Fm3H7V6nZ4J4D446czYsuTc=; b=OOnOG/imyPQsjX3hrFhuN/vNtgkgMSjxyZNkb3ZMk5v0z1Axlt5ajBdjkqryGdp38B fMJGxDnoaahd8R9FeiDlEkFMDidD3gn3HhJSqDxCdQLImU6U+yZfTjUPpGBBdPPMUCC7 fZJrgN31KHs/fODkQNhufkPtqcTyzs6ONsO82JYoyw7tIsYihKP1iBrMjCEkqVopHNLB WeAL+fdY3SbQa/4Ulr2wb4LCZBQdRlZams82sOfHceq7uPsyyz+496E8sqN9EkodMC7P cjPBed4zqytOuTGpKkjFaMYQUKIYKhLh7uxC3FVJuYxLA9ppxYeBIkgDCF+SldXWT5cG qatg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I80RtMkBuTNsT2Wy6qv/Fm3H7V6nZ4J4D446czYsuTc=; b=DrW21i437jH+XrVPIbQ1xqLvjHBqDryMgEmbds/mzu0LFBPnRCcBOYQKGifa6ALsNc D+PxMJjtoTHUovq3n3SgH7EImGjKHhWvNTHDn/B7gus+T3JPY3XEZmNZvSOSo7bz7AdM ACErAVkC+/xF3tvBlmi7jIbB7H9HTXBE4LDDI9anjCmr9Idl+YcCbTpXXGRKhvD0SPrH nWbNQQsEQ9yfhO+/Obbn30zTf5jghRxoOSNyhFAWvl4/1Brd+cUOWCRPMRC7uoRQ78lF JLffWhZkDsgMeRH0RrhqlYiU8AaCgvGTnDvON47rC/Z/pkf/Oyh7nB/UEkKeIGpHB2d6 qlAA== X-Gm-Message-State: AJcUukdwpozdFhD7ulbiwOSE7zX+5Z0x+jZPEHv9q9wNyXn7veTxYA0L 3+2c79trxD+d6XeR77M+p9EEMcN6w8TU7nkFuAkaUg== X-Google-Smtp-Source: ALg8bN5Lwy39btTS3bquZdqQL6dMTBS+/sS2pCVKipfFwwgqmP6MBKHrdMPaZCFVPsUE2F8rCDVpDsRUNLCbF/i4TcU= X-Received: by 2002:a5d:844d:: with SMTP id w13mr8806746ior.17.1547208921137; Fri, 11 Jan 2019 04:15:21 -0800 (PST) MIME-Version: 1.0 References: <20190103085621.23611-1-alejandro.lucero@netronome.com> <09fd5132-905b-bbe0-1178-392595027353@intel.com> <9afed691-6710-7efd-09e7-ae927cc091a8@intel.com> <9ffc5c5b-ce11-331d-b82c-ccbdab4d5350@intel.com> In-Reply-To: <9ffc5c5b-ce11-331d-b82c-ccbdab4d5350@intel.com> From: Alejandro Lucero Date: Fri, 11 Jan 2019 12:15:10 +0000 Message-ID: To: Ferruh Yigit Cc: dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2019 12:15:22 -0000 On Fri, Jan 11, 2019 at 11:48 AM Ferruh Yigit wrote: > On 1/10/2019 11:55 AM, Alejandro Lucero wrote: > > > > > > On Wed, Jan 9, 2019 at 4:15 PM Ferruh Yigit > > wrote: > > > > On 1/9/2019 2:20 PM, Alejandro Lucero wrote: > > > > > > > > > On Wed, Jan 9, 2019 at 10:54 AM Ferruh Yigit < > ferruh.yigit@intel.com > > > > > >> > wrote: > > > > > > On 1/3/2019 8:56 AM, Alejandro Lucero wrote: > > > > The Netronome's Network Flow Processor chip is highly > programmable > > > > with the goal of processing packets at high speed. > Processing units > > > > and other chip components are available from the host > through the > > > > PCIe CPP(Command Push Pull bus) interface. The NFP PF PMD > configures > > > > a CPP handler for setting up and working with vNICs, perfor= m > actions > > > > like link up or down, or accessing extended stats from the > MAC > > component. > > > > > > > > There exist NFP host tools which access the NFP components > for > > > > programming and debugging but they require the CPP > interface. When the > > > > PMD is bound to the PF, the DPDK app owns the CPP interface= , > so these > > > > host tools can not access the NFP through other means like > NFP kernel > > > > drivers. > > > > > > > > This patch adds a CPP bridge using the rte_service API whic= h > can be > > > > enabled by a DPDK app. Interestingly, DPDK clients like OVS > will not > > > > enable specific service cores, but this can be performed > with a > > > > secondary process specifically enabling this CPP bridge > service and > > > > therefore giving access to the NFP to those host tools. > > > > > > Hi Alejandro, > > > > > > > > > Hi Ferruh, > > > > > > > > > Getting a few build errors, more details below. > > > > > > > > > > > Signed-off-by: Alejandro Lucero < > alejandro.lucero@netronome.com > > > > > > >> > > > <...> > > > > > > > + /* Obtain target's CPP ID and offset in target */ > > > > + cpp_id =3D (offset >> 40) << 8; > > > > > > With icc, i686 getting [1], it seems 'off_t' is 32bits long o= n > 32bit > > build. > > > > > > [1] > > > error #63: shift count is too large > > > > > > > > > We do not support 32 bits. I thought our PMD was not built in tha= t > case. > > > > If PMD doesn't support 32 bits, above is OK, I will update my scrip= t > > accordingly. > > > > > > > > > > > <...> > > > > > > > + if (err !=3D (int)len) { > > > > + printf("%s: error when > receiving, %d > > of %lu\n", > > > > + __func__, err, count)= ; > > > > > > Giving build error for 32bits [3], and can you please use > logging > > macros instead > > > of printf? > > > > > > > > > Sure. > > > > > > > > > [3] > > > error: format =E2=80=98%lu=E2=80=99 expects argument of type = =E2=80=98long unsigned > int=E2=80=99, but > > argument 4 > > > has type =E2=80=98size_t=E2=80=99 {aka =E2=80=98unsigned int= =E2=80=99} [-Werror=3Dformat=3D] > > > > > > <...> > > > > > > > + /* Obtain target's CPP ID and offset in target */ > > > > + cpp_id =3D (offset >> 40) << 8; > > > > > > Same as above [1]. > > > > > > <...> > > > > > > > + if (err !=3D (int)len) { > > > > + printf("%s: error when > sending: %d of > > %lu\n", > > > > + __func__, err, count)= ; > > > > > > Same build error with above [3]. > > > > > > <...> > > > > > > > +nfp_cpp_bridge_serve_ioctl(int sockfd, struct nfp_cpp *cpp= ) > > > > +{ > > > > + int cmd, err; > > > > + uint32_t ident_size, tmp; > > > > + > > > > + /* Reading now the IOCTL command */ > > > > + err =3D recv(sockfd, &cmd, 4, 0); > > > > + if (err !=3D 4) { > > > > + printf("%s: read error from socket\n", > __func__); > > > > + return -EIO; > > > > + } > > > > + > > > > + /* Only supporting NFP_IOCTL_CPP_IDENTIFICATION */ > > > > + if (cmd !=3D NFP_IOCTL_CPP_IDENTIFICATION) { > > > > > > Giving build error with ppc_64-power8-linuxapp-gcc [2]. > > > > > > > > > We do not support power architecture. > > > > Yes but issue seems not exactly ppc issue, more like signed - > unsigned > > comparison. Can you please check if is there any valid issue here? > > > > > > This is a funny one. NFP_IOCTL_CPP_IDENTIFICATION is not zero, and cmd > could be > > anything. > > And it does work with other compilers! > > > > Talking with a compiler guy in the office, and it is hard to know why t= he > > compiler is triggering an error here. I suspect this is some sort of > endianness > > mess, and he thinks the compiler could be assuming the cmd variable > after recv > > call is always negative or positive, and the macro always being the > opposite in > > powerpc, so the comparison is always true, what is what the error > message says. > > > > Anyway, it is not clear how to fix this. Maybe defining cmd as uint32_t > could > > help. Any change we can test this before sending another patch version? > > I am using a cross compiler for ppc, it is freely available, you should b= e > able > to get and test with it, or I can test for you if you prefer. > > Ok. I got a cross compiler now. Any reference about how to use it with DPDK= ? > > > > > > > > > > > > > > > [2] > > > error: comparison is always true due to limited range of data > type > > > [-Werror=3Dtype-limits] > > > > > > >