DPDK patches and discussions
 help / color / mirror / Atom feed
From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: dev <dev@dpdk.org>
Subject: [dpdk-dev] ret_pktmbuf_pool_init problem with opaque_arg
Date: Fri, 9 Jan 2015 14:12:10 +0000	[thread overview]
Message-ID: <CAD+H9911EO_0J_GRt34j-ugOSqeJo-QobNYc_cMe+52kvXLEfw@mail.gmail.com> (raw)

Inside this function mbuf_data_room_size is set to a default value if
opaque_arg is null and it should be set to the value pointed by opaque_arg
if not null. Current implementation is using not the value but with the
pointer itself. I think this:

        roomsz = (uint16_t)(uintptr_t)opaque_arg;

should be something like this:

        roomsz = *(uint16_t *)opaque_arg;

             reply	other threads:[~2015-01-09 14:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 14:12 Alejandro Lucero [this message]
2015-01-09 14:28 ` Olivier MATZ
2015-01-09 14:38   ` Alejandro Lucero
2015-01-09 22:42 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAD+H9911EO_0J_GRt34j-ugOSqeJo-QobNYc_cMe+52kvXLEfw@mail.gmail.com \
    --to=alejandro.lucero@netronome.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).