From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f49.google.com (mail-oi0-f49.google.com [209.85.218.49]) by dpdk.org (Postfix) with ESMTP id 40AF247CE for ; Tue, 29 Mar 2016 09:16:50 +0200 (CEST) Received: by mail-oi0-f49.google.com with SMTP id h6so10084010oia.2 for ; Tue, 29 Mar 2016 00:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=1hQMZL9UjCzGUmFL5dse2OYwMJS4R4bYbWoHbCNe8sE=; b=lrpG+BYmSUIXaPhjdQx7c7U7/S9QDNjZ8jG2HI3c0HlfGxak4zz2sTiKjfiij9cbEB NSUUIlIuw56/TcqimiLoiAD76lrUoAm1yR57MJsa0FTiW6C74PwEiuVo/Z/Aw710iNYg 81u76212RmyNFy37O4/BPWrzNaSEkWoOFprQskvYa/B5n1kyy+lgnGWgq0OALStfT6pB BXhwVktbxSrNovgVs6DWApErgq1IFGrE2kzOLDr5yAsM0t0sse+uX1FuWy93jAIm0pxx KyqZKIcUYHtKJiaYY3j45OKI0PGOcKJ/oWkkR55g1C1Fy3Ccac9R3WlFM+fRouueX/eM r2vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=1hQMZL9UjCzGUmFL5dse2OYwMJS4R4bYbWoHbCNe8sE=; b=dvLB1GEwTiFgRFFMM6OMjmqHfQfAZBK19vFaQsxiDa3oY2wGM0awScUoAgcbLs1dVk uyygGuZ6l1hV5SO/7AaZQ+Q3MH+kJU6nLx9sFQywF+G1Nv1JG00yTzFOQUE/sbDsaalk UfUsBvy4OUjsbdMxlCgloBvkQcoaj2A10qcNz253kq8/aqPugZbMbTwVbJofR84DXxxH GjZkN0Q7HvxDBRLuQXaoCX0bwTLYvH+ufWVnjd/15E+HSkj6wHoa/VqC6rw5FSwQVsmW oYqrk1cZSR0xX+Eyvz5T4RhAUl6WoWa1NXs2E7JN1MJnSJActSHJkzfv7pnYvorf6DqN /F6Q== X-Gm-Message-State: AD7BkJI9MQ3t7dBDcl401GCtcU8iy/SOj4As22CyWdqvP/XvjCiPHeSr9NeiYG39tR5g7zOml9dgzyIWyfOdMuEO MIME-Version: 1.0 X-Received: by 10.157.37.124 with SMTP id j57mr283036otd.135.1459235809608; Tue, 29 Mar 2016 00:16:49 -0700 (PDT) Received: by 10.76.28.6 with HTTP; Tue, 29 Mar 2016 00:16:49 -0700 (PDT) In-Reply-To: <20160325123117.GD18028@bricha3-MOBL3> References: <1458748296-15017-1-git-send-email-stephen@networkplumber.org> <20160325123117.GD18028@bricha3-MOBL3> Date: Tue, 29 Mar 2016 08:16:49 +0100 Message-ID: From: Alejandro Lucero To: Bruce Richardson Cc: dev , Stephen Hemminger Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] nfp: copy pci info from pci to ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Mar 2016 07:16:50 -0000 Hi guys, Sorry for the delay but I was on a Easter break. That patch is OK for me. In fact, I had one patch ready for upstreaming with this change needed for supporting hotplug. I was waiting for some feedback from one internal project needing this hotplug functionality before submitting. Regards On Fri, Mar 25, 2016 at 12:31 PM, Bruce Richardson < bruce.richardson@intel.com> wrote: > On Wed, Mar 23, 2016 at 08:51:36AM -0700, Stephen Hemminger wrote: > > The NFP driver (unlike other PCI devices) was not copying the pci info > > from the pci_dev to the eth_dev. This would make the driver_name be > > null (and other unset fields) when application uses dev_info_get. > > > > This was found by code review; do not have the hardware. > > > > Signed-off-by: Stephen Hemminger > > --- > Alejandro, > > any review or ack on this patch for nfp driver? > > Regards, > /Bruce >