From: Alejandro Lucero <alejandro.lucero@netronome.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Tetsuya Mukawa <mtetsuyah@gmail.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>, dpdk-dev <dev@dpdk.org>,
Beilei Xing <beilei.xing@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] Remaining old offloading API usage in PMDs
Date: Mon, 21 May 2018 15:16:31 +0100 [thread overview]
Message-ID: <CAD+H991tQCqYYx4WGye3Yd_OD3szWy_VRtwcK-=Bs8DosYtZjQ@mail.gmail.com> (raw)
In-Reply-To: <8fe6b45b-7fb3-0551-39ec-02ba94ef16cb@intel.com>
I completely missed this last bit in the NFP driver.
I will send a patch today.
By the way, will it go into 18.05? I ask because I have another patch
fixing a problem which would be good to have in 18.05 as well.
On Mon, May 21, 2018 at 1:38 PM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:
> On 5/11/2018 11:45 AM, Ferruh Yigit wrote:
> > Some PMDs are still using old offloading API related variables, thanks
> to Andrew
> > for reporting it.
> >
> > Maintainers of related PMDs are cc'ed.
> > Please check following list and provide a fix ASAP for it, thanks.
> >
> >
> > # git grep header_split drivers/
> > drivers/net/i40e/i40e_rxtx_vec_common.h: if
> (rxmode->header_split == 1)
> >
> > # git grep hw_vlan_filter drivers/
> > drivers/net/i40e/i40e_vf_representor.c: if
> > (ethdev->data->dev_conf.rxmode.hw_vlan_filter)
> > drivers/net/vhost/rte_eth_vhost.c: if (rxmode->hw_vlan_filter)
> >
> > # git grep hw_vlan_strip drivers/
> > drivers/net/dpaa2/dpaa2_rxtx.c: if
> > (dev->data->dev_conf.rxmode.hw_vlan_strip)
> > drivers/net/i40e/i40e_vf_representor.c: if
> > (ethdev->data->dev_conf.rxmode.hw_vlan_strip)T
> > drivers/net/vhost/rte_eth_vhost.c: internal->vlan_strip =
> > rxmode->hw_vlan_strip;
> >
> > # git grep hw_vlan_extend drivers/
> > drivers/net/i40e/i40e_rxtx_vec_common.h: if
> (rxmode->hw_vlan_extend == 1)
> >
> > # git grep hw_strip_crc drivers/
> > drivers/net/nfp/nfp_net.c: rxq->crc_len = (uint8_t)
> > ((dev->data->dev_conf.rxmode.hw_strip_crc) ? 0
> > drivers/net/sfc/sfc_rx.c: rxmode->hw_strip_crc = 1;
> >
>
> Reminder of this one.
>
next prev parent reply other threads:[~2018-05-21 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 10:45 Ferruh Yigit
2018-05-14 11:01 ` Shreyansh Jain
2018-05-21 12:38 ` Ferruh Yigit
2018-05-21 14:16 ` Alejandro Lucero [this message]
2018-05-21 14:33 ` Ferruh Yigit
2018-05-22 14:12 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD+H991tQCqYYx4WGye3Yd_OD3szWy_VRtwcK-=Bs8DosYtZjQ@mail.gmail.com' \
--to=alejandro.lucero@netronome.com \
--cc=arybchenko@solarflare.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=maxime.coquelin@redhat.com \
--cc=mtetsuyah@gmail.com \
--cc=qi.z.zhang@intel.com \
--cc=shreyansh.jain@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).