From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 1CFE61B1A3 for ; Mon, 21 May 2018 16:16:32 +0200 (CEST) Received: by mail-wm0-f66.google.com with SMTP id j4-v6so25691510wme.1 for ; Mon, 21 May 2018 07:16:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=tlV3gOE6r2JTvJO97L89CXgs4JXYimzGgA6+87GbmTU=; b=EM9Y+1BcQANMzkydNrOVWC1I9zv6a3b2phOk6giVsJkELn4hD7lFm45porUJvJhs2c Elgjd5zytEhes2v5mhpNwyuMYR6cPFoayUGBxp6VCGI55Emr15tEv98JbMngSHgQU0iP RIJHSU0CSrneOnBF7dBwrtmIgrNOgu5R1SqjnIrUP8UsMNzRuqIqt8SiulWtG+XgZegL DefcMOk+tsZN6No/iJI3T+/NZRTVbVsHWuBUpY0SEz+jur468R9PPKsd2NXPeLedEbux BINH7hP/sD9SqtJEhEaGZGRRRv4bN9hZ1aNCOeybtbTb46h6BA9Rx9CRr2cI5qZUg7Ec +emA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tlV3gOE6r2JTvJO97L89CXgs4JXYimzGgA6+87GbmTU=; b=iqJsphPAub0iET0e7GOa+ZCgSffQKm4slorGz/IsEqPnYqLr+47PfCCoIJXjoXdkuL qEOZE/B4l2fdEHzlIL5hE+O3AhLmp2Wad7VEoboOZ9fGCSJXYhKEb1gE0b3a5GmtOgkj TzhSvn1RpIc/4cYSZabI3OT94/OdNM/zgTiUW7vhrJqLxnh90furB7c7LT7AaEqIwx/W TzYv0j9u5vJUKhUlqwolpfWL4oGtM2iddWNMWINtwAv4MRU05u0iApAtQdE4spGXLgVg FGw7149RIM1G3bY/khpT8kPjdNkcJ6Q0hVo+ekTmyrB0Vy6ekSNpxJwb24nmtb7GLQ3b DwWA== X-Gm-Message-State: ALKqPwc4x40sBPJwikWD1o1hVyU1I4PiuAj4E00nj2CW+KoFaFvg/Kzw aXPqWmbx/TSEibeo0rWm+FpT+oK4qHFzCgUxQeIMqw== X-Google-Smtp-Source: AB8JxZqUVKuGelbkqB6cWRhNMlKZYF2vILpLaq03Q+1Kp4us7Rl3LU2qOJ40MHWAi3I/WvV/FVUg62MQJK5UESfNYYE= X-Received: by 2002:aa7:d0d2:: with SMTP id u18-v6mr23292082edo.97.1526912191910; Mon, 21 May 2018 07:16:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.80.212.155 with HTTP; Mon, 21 May 2018 07:16:31 -0700 (PDT) In-Reply-To: <8fe6b45b-7fb3-0551-39ec-02ba94ef16cb@intel.com> References: <9a1b4500-d354-bdef-45d3-7d6eeacfb54b@intel.com> <8fe6b45b-7fb3-0551-39ec-02ba94ef16cb@intel.com> From: Alejandro Lucero Date: Mon, 21 May 2018 15:16:31 +0100 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , Andrew Rybchenko , Tetsuya Mukawa , Maxime Coquelin , Hemant Agrawal , Shreyansh Jain , dpdk-dev , Beilei Xing , Qi Zhang Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Remaining old offloading API usage in PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 May 2018 14:16:32 -0000 I completely missed this last bit in the NFP driver. I will send a patch today. By the way, will it go into 18.05? I ask because I have another patch fixing a problem which would be good to have in 18.05 as well. On Mon, May 21, 2018 at 1:38 PM, Ferruh Yigit wrote: > On 5/11/2018 11:45 AM, Ferruh Yigit wrote: > > Some PMDs are still using old offloading API related variables, thanks > to Andrew > > for reporting it. > > > > Maintainers of related PMDs are cc'ed. > > Please check following list and provide a fix ASAP for it, thanks. > > > > > > # git grep header_split drivers/ > > drivers/net/i40e/i40e_rxtx_vec_common.h: if > (rxmode->header_split == 1) > > > > # git grep hw_vlan_filter drivers/ > > drivers/net/i40e/i40e_vf_representor.c: if > > (ethdev->data->dev_conf.rxmode.hw_vlan_filter) > > drivers/net/vhost/rte_eth_vhost.c: if (rxmode->hw_vlan_filter) > > > > # git grep hw_vlan_strip drivers/ > > drivers/net/dpaa2/dpaa2_rxtx.c: if > > (dev->data->dev_conf.rxmode.hw_vlan_strip) > > drivers/net/i40e/i40e_vf_representor.c: if > > (ethdev->data->dev_conf.rxmode.hw_vlan_strip)T > > drivers/net/vhost/rte_eth_vhost.c: internal->vlan_strip = > > rxmode->hw_vlan_strip; > > > > # git grep hw_vlan_extend drivers/ > > drivers/net/i40e/i40e_rxtx_vec_common.h: if > (rxmode->hw_vlan_extend == 1) > > > > # git grep hw_strip_crc drivers/ > > drivers/net/nfp/nfp_net.c: rxq->crc_len = (uint8_t) > > ((dev->data->dev_conf.rxmode.hw_strip_crc) ? 0 > > drivers/net/sfc/sfc_rx.c: rxmode->hw_strip_crc = 1; > > > > Reminder of this one. >