From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it1-f195.google.com (mail-it1-f195.google.com [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id 06BDE1B163 for ; Mon, 14 Jan 2019 19:01:06 +0100 (CET) Received: by mail-it1-f195.google.com with SMTP id z7so817424iti.0 for ; Mon, 14 Jan 2019 10:01:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C1iZ04bGCxIquGVRT8MYNTXbBx17rwrLbkGL/mVn5hk=; b=Widh6apV2B5yw+BJNEuZPR2KOc7jolo6hczRxTYVQ0EelflAukPKH3XJA5VRsurJaf 4p69mtv/OTYDwBep/ASLqwrFWyTDVmD/vckdGagbiErv8jQYYIhi+IoXNXsRw5eKZWLK Sp6dzILHKlD2D9KxerbR3tf1OeGIgCG+7ToFdo8peWrMsxHp91boKmXYjGy663gJYMoE EAKrat+PkL5EYIyt1iHQB0iI2glv2Gc8gzCjNKelN3aK815S6FQ4Qlu+ReXoaeKdWdWK 648wlaUkqZODBZk/788oihTl4HOwhphlcCIUIT8RGnnxiomMs2JoTMxpPuoaDM4jU2eY hhRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C1iZ04bGCxIquGVRT8MYNTXbBx17rwrLbkGL/mVn5hk=; b=OkkJZEeKj1VJnInXWoYKkqmV25kq23z4E0oIA3YHfKdT8clFbU+CaK8ILv53ZbAKsN andQuf2zdjpnd9Z0kRcGN7vxpvr7ogluK1aiJakzKZ9iohXmc+PvzMmRej65ZPMuIaVP GafJl855xLB/OuYTbivXg5t6/bIGXmsA5DoMJzBtNlmLec9hsffCub92Zs3hRZo6TaSG KdLtiQl/RyEQ6hKf68rod1+BWDDJD+wFNXT7sH3xhX9nyIS1xV5EX9cDYgAK209alwuB 4yOWvbthHNfwWI9UT+1751iZAcXIHxnLvnfV5G0rqSw3xFdPA/8mICpRA68Rbc7Fpfoa 4xRQ== X-Gm-Message-State: AJcUukfGLugIJdPttf/3C4khoDLweZ+dfIE97nxxYMQ5giYwUD07io/k W834LU8M2gKoc52vyFjp4RL9Vqm7waOG4ZQIIRYlonDc X-Google-Smtp-Source: ALg8bN73wGR8+kqTri/Xysj5KhOgRGjHXrws+cPvntLUkjL/pc1bnE0Uv8SH+wlEkI/io1OoiSAyKO3z48EID8RXybE= X-Received: by 2002:a24:1495:: with SMTP id 143mr210898itg.13.1547488866322; Mon, 14 Jan 2019 10:01:06 -0800 (PST) MIME-Version: 1.0 References: <20190111132553.10683-1-alejandro.lucero@netronome.com> <1051920a-7b6b-f68e-7556-be74c160a477@intel.com> <1753333.lH3haCoHOP@xps> <9a8fff63-7a8b-a100-a725-98e8c0e9cf2b@intel.com> In-Reply-To: <9a8fff63-7a8b-a100-a725-98e8c0e9cf2b@intel.com> From: Alejandro Lucero Date: Mon, 14 Jan 2019 18:00:55 +0000 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 18:01:07 -0000 On Mon, Jan 14, 2019 at 10:40 AM Ferruh Yigit wrote: > On 1/13/2019 9:41 PM, Thomas Monjalon wrote: > > 11/01/2019 17:42, Ferruh Yigit: > >> On 1/11/2019 1:25 PM, Alejandro Lucero wrote: > >>> The Netronome's Network Flow Processor chip is highly programmable > >>> with the goal of processing packets at high speed. Processing units > >>> and other chip components are available from the host through the > >>> PCIe CPP(Command Push Pull bus) interface. The NFP PF PMD configures > >>> a CPP handler for setting up and working with vNICs, perform actions > >>> like link up or down, or accessing extended stats from the MAC > component. > >>> > >>> There exist NFP host tools which access the NFP components for > >>> programming and debugging but they require the CPP interface. When the > >>> PMD is bound to the PF, the DPDK app owns the CPP interface, so these > >>> host tools can not access the NFP through other means like NFP kernel > >>> drivers. > >>> > >>> This patch adds a CPP bridge using the rte_service API which can be > >>> enabled by a DPDK app. Interestingly, DPDK clients like OVS will not > >>> enable specific service cores, but this can be performed with a > >>> secondary process specifically enabling this CPP bridge service and > >>> therefore giving access to the NFP to those host tools. > >>> > >>> v2: > >>> - Avoid printfs for debugging > >>> - fix compilation problems for powerpc > >>> > >>> Signed-off-by: Alejandro Lucero > >> > >> Applied to dpdk-next-net/master, thanks. > > > > It does not compile with 32-bit toolchain. > > > > Please check the occurences of %lu, thanks. > > Hi Thomas, > > We aware the build error, but let it because nfp doesn't support 32-bit. > > But I just recognized that it is enabled by default on 32-bit default > configs, > we should disable them. > > > Hi Alejandro, > > Can you please disable nfp driver explicitly on > 'defconfig_i686-native-linuxapp-*' config files, perhaps also on > 'defconfig_x86_x32-native-linuxapp-gcc' too? > > I will drop the existing patch from next-net. > > Ok. I'll do asap. > And if it is possible to fix the build error, specially if it is just for > %lu of > the logging, I prefer the fix against the config update, but it is up to > you. > > I did not see any logging error/warning when compiling nor any when using checkpatch. I have used a gcc 7.3.1 (Ubuntu) and a 8.2.1 (RH). What are you using for triggering such error? > Thanks, > ferruh >