* [dpdk-dev] [PATCH] net/nfp: fix possible resource leak
@ 2018-04-17 5:59 Yangchao Zhou
2018-04-17 9:07 ` Alejandro Lucero
0 siblings, 1 reply; 3+ messages in thread
From: Yangchao Zhou @ 2018-04-17 5:59 UTC (permalink / raw)
To: dev; +Cc: alejandro.lucero
Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
---
drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
index ad6ce72..f2fcc4a 100644
--- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
+++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
@@ -816,6 +816,7 @@ struct nfp6000_area_priv {
if (fscanf(fp, "0x%lx 0x%lx 0x%lx", &start, &end, &flags) == 0) {
printf("error reading resource file for bar size\n");
+ fclose(fp);
return -1;
}
--
1.7.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/nfp: fix possible resource leak
2018-04-17 5:59 [dpdk-dev] [PATCH] net/nfp: fix possible resource leak Yangchao Zhou
@ 2018-04-17 9:07 ` Alejandro Lucero
2018-04-17 14:07 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Alejandro Lucero @ 2018-04-17 9:07 UTC (permalink / raw)
To: Yangchao Zhou; +Cc: dev
Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>
On Tue, Apr 17, 2018 at 6:59 AM, Yangchao Zhou <zhouyates@gmail.com> wrote:
> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> ---
> drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> index ad6ce72..f2fcc4a 100644
> --- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> +++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c
> @@ -816,6 +816,7 @@ struct nfp6000_area_priv {
>
> if (fscanf(fp, "0x%lx 0x%lx 0x%lx", &start, &end, &flags) == 0) {
> printf("error reading resource file for bar size\n");
> + fclose(fp);
> return -1;
> }
>
> --
> 1.7.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/nfp: fix possible resource leak
2018-04-17 9:07 ` Alejandro Lucero
@ 2018-04-17 14:07 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-04-17 14:07 UTC (permalink / raw)
To: Alejandro Lucero, Yangchao Zhou; +Cc: dev
On 4/17/2018 10:07 AM, Alejandro Lucero wrote:
>
> On Tue, Apr 17, 2018 at 6:59 AM, Yangchao Zhou <zhouyates@gmail.com> wrote:
Fixes: c7e9729da6b5 ("net/nfp: support CPP")
>> Signed-off-by: Yangchao Zhou <zhouyates@gmail.com>
> Acked-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-17 14:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-17 5:59 [dpdk-dev] [PATCH] net/nfp: fix possible resource leak Yangchao Zhou
2018-04-17 9:07 ` Alejandro Lucero
2018-04-17 14:07 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).