From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f51.google.com (mail-vk0-f51.google.com [209.85.213.51]) by dpdk.org (Postfix) with ESMTP id 57E4C2BE6 for ; Tue, 3 May 2016 13:14:27 +0200 (CEST) Received: by mail-vk0-f51.google.com with SMTP id m188so18780337vka.1 for ; Tue, 03 May 2016 04:14:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=8GnlSw0Ght5BVQ82c/ikRnTEDe5F/qLv54XdfU6fMIc=; b=nOOglxTxQKK7wh2MNIGNyYGVIOuiZlI+x+vyR0VY+HnbZHTju8XLO94+unokKaAhiu niRuUBMHEbLZLsRvqSCXWwd7xJuLNnlXwjy2SLsKt5whbs++6b4t5YfV6OpRW2wF4ZHB Opd6LOu9qc0sgDh1zEbndqw8qtUIswVtCTolZJ+L3evZD2NOfTYsg9QfCQ3l8SkHYP82 zgUubBU0KQwCtEmGuUJJoi5/oCIOAlcRpcRxx4Iw0gigDEzo+haw2WeGDtBAqA5R6kN1 jbSStaUKf43hWK0/7wRdvm7pDL5gcAPhp1KnpKCMIcx3UhGm5fR1KtepTot/hiXHgYeT VAtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=8GnlSw0Ght5BVQ82c/ikRnTEDe5F/qLv54XdfU6fMIc=; b=Jg4/N3oA8icRgG5QlhD/bun7+TfhsBnj4O/Ak9PAk2BNlJOy659flOi2YoJeAtTFq/ 6guxYm/LGIvJjGzH1F9kiTnhH26RfzN4zdQ3nfeazYqLYRPk3VBP4cOQ/Zqx589qYKTM JmSz9G8gKk+U16tLUA6VMGxmCDLo3A9bol4Q4RboXDRZKTLxRlp+JAs232faFis82W68 z8gnYs2N1CbCQ6CyhVfARqp3j/gpZ0nXkmHsZlcdmDnrShE/QcCNZuy2PY+9L7VsVita ybPx75alyKPrlrA9/REGr+V30AgvtIARMGjT7ssukeFTC3u4l0r8grQGM65Ivei821I8 7WZQ== X-Gm-Message-State: AOPr4FU3pD/YW/7D9RAdjBnk5HD/odFI/2unCnLaYmN4qViLzK5tc2O9KiDo6ADeq92wu1V/MCp3nM4C8yHYmu6p MIME-Version: 1.0 X-Received: by 10.31.182.17 with SMTP id g17mr619159vkf.110.1462274066762; Tue, 03 May 2016 04:14:26 -0700 (PDT) Received: by 10.103.112.129 with HTTP; Tue, 3 May 2016 04:14:26 -0700 (PDT) In-Reply-To: <20160503110148.GC20328@bricha3-MOBL3> References: <1461672855-44715-1-git-send-email-alejandro.lucero@netronome.com> <20160503110148.GC20328@bricha3-MOBL3> Date: Tue, 3 May 2016 12:14:26 +0100 Message-ID: From: Alejandro Lucero To: Bruce Richardson Cc: dev Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] nfp: avoiding concurrency when hardware reconfig X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2016 11:14:27 -0000 Hi Bruce, Sorry about this. I sent a v2 for this patch but not in the same thread: http://www.dpdk.org/ml/archives/dev/2016-April/037996.html On Tue, May 3, 2016 at 12:01 PM, Bruce Richardson < bruce.richardson@intel.com> wrote: > On Tue, Apr 26, 2016 at 01:14:15PM +0100, Alejandro Lucero wrote: > > Some apps calling some functions from different threads at the > > same time could lead to reconfig problems. Reconfig mechanism is > > based on a hardware queue where incrementing a counter signals the > > firmware to do the reconfig. If there are two increments before the > > first one has been processed the firmware will stop and a device > > reset is necessary. > > > > Signed-off-by: Alejandro Lucero > > --- > > drivers/net/nfp/nfp_net.c | 8 ++++++++ > > drivers/net/nfp/nfp_net_pmd.h | 1 + > > 2 files changed, 9 insertions(+) > > > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > > index bc0a3d8..ba0ee04 100644 > > --- a/drivers/net/nfp/nfp_net.c > > +++ b/drivers/net/nfp/nfp_net.c > > @@ -58,6 +58,7 @@ > > #include "nfp_net_pmd.h" > > #include "nfp_net_logs.h" > > #include "nfp_net_ctrl.h" > > +#include > > Hi Alejandro, > > I think this header addition is in the wrong place in the code. When I > apply > this patch to next-net and try a recompile I get the error: > > CC nfp_net.o > In file included from > /home/bruce/next-net/dpdk-next-net/drivers/net/nfp/nfp_net.c:58:0: > /home/bruce/next-net/dpdk-next-net/drivers/net/nfp/nfp_net_pmd.h:409:2: > error: unknown type name =E2=80=98rte_spinlock_t=E2=80=99 > rte_spinlock_t reconfig_lock; > ^ > > You either need to put the spinlock include before the nfp_net_pmd.h > include > or, perhaps better, put the spinlock include inside the nfp_net_pmd heade= r > file > since that is where the spinlock variable is being defined. > > /Bruce > >