From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f181.google.com (mail-ua0-f181.google.com [209.85.217.181]) by dpdk.org (Postfix) with ESMTP id E44BF2BDD for ; Tue, 6 Dec 2016 15:51:33 +0100 (CET) Received: by mail-ua0-f181.google.com with SMTP id 51so383393046uai.1 for ; Tue, 06 Dec 2016 06:51:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zp27aGf/jSP4p0UIfkv5Ba5sPH27ZYuhCq2Lya1ImWg=; b=cMZrECOwdv4AJK2po4ruzKeGC0zOtvx2U5WwDm6JdSbqPUDsCoiKKh4/wAjRFgR+7j DVHQfT1mFxPIEZ+d+evdZflYWbm7l3ZghBX8UTTAHqSACngyPH8OHiNTj1pG00Bivkml 2dRk2uSdmGp2Pp3OiBwrDck3o99NwgjAxtUk6Jh3eP0ncEVfNnCu6asjsRrQdt7L0Rz5 PookBOK5d6g7KpJKZiN8HXe6EPwOVF3RMQ+/pqrdA5uOWpfQljUOF47TeVRZt9KZswYJ JliXlc+zchELYQ0rU0J8FEhR1i0jcwtXdjvPXt5JWfs+lxhzzzos12IC/zH3riITG1Dt dtiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zp27aGf/jSP4p0UIfkv5Ba5sPH27ZYuhCq2Lya1ImWg=; b=Rtf8r8E7ENaP8C1Vo39YSo9Qb8Vg7o9r0Lrd3i7Eevl45Doo31Ek1Cmw5pqHX03Etd pXsHXR68++jRooC+ntQA2zBLyDGgNsXmSMCDMwfJpNaHEtxR4OIwwD/Tqi6H0EKKQS+0 m9gpEkRsrMpkieaMnPFOj2Wd/2tQu9EIiPCcbiEFP5AYZob0hHFoiDcpM9jIAwbzSPwi z1+GBsdVFA2XI2C4/1HoliqqfnklVjktQfXBX+G7vn0j68eHY1b8aCF/xWV3vplj9apo 6s0d4tKMCy5erV2XloycThtlFnCJctmg+4SMtul0HlKnETQpjiBqNNAARwBQPga/t1X6 ANUw== X-Gm-Message-State: AKaTC0298ArPCGCQcGfLIgyBMtYe61zmKS6UbPOwgR2ueUFoziUZstXRXNWA+t54fflzLQKcdQWEO1kDeqgUuA+K X-Received: by 10.176.71.134 with SMTP id v6mr40356134uac.174.1481035893240; Tue, 06 Dec 2016 06:51:33 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.46.3 with HTTP; Tue, 6 Dec 2016 06:51:32 -0800 (PST) In-Reply-To: References: <1480666653-35544-1-git-send-email-alejandro.lucero@netronome.com> <3133b0c5-672d-de7d-1690-815c7603e581@intel.com> From: Alejandro Lucero Date: Tue, 6 Dec 2016 14:51:32 +0000 Message-ID: To: "Mcnamara, John" Cc: "Yigit, Ferruh" , "dev@dpdk.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] nfp: add doc about supported features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Dec 2016 14:51:34 -0000 Then I guess I should send another version of this patch. On Tue, Dec 6, 2016 at 12:46 PM, Mcnamara, John wrote: > > -----Original Message----- > > From: Yigit, Ferruh > > Sent: Tuesday, December 6, 2016 12:08 PM > > To: Alejandro Lucero ; dev@dpdk.org; > > Mcnamara, John > > Subject: Re: [dpdk-dev] [PATCH] nfp: add doc about supported features > > > > On 12/2/2016 8:17 AM, Alejandro Lucero wrote: > > > Signed-off-by: Alejandro Lucero > > > --- > > > doc/guides/nics/features/nfp.ini | 25 +++++++++++++++++++++++++ > > > 1 file changed, 25 insertions(+) > > > > > > diff --git a/doc/guides/nics/features/nfp.ini > > b/doc/guides/nics/features/nfp.ini > > > index d967151..dd78233 100644 > > > --- a/doc/guides/nics/features/nfp.ini > > > +++ b/doc/guides/nics/features/nfp.ini > > > @@ -4,3 +4,28 @@ > > > ; Refer to default.ini for the full list of available PMD features. > > > ; > > > [Features] > > > +SR-IOV = Y > > > +Link status = Y > > > +Link status event = Y > > > +Rx interrupt = N > > > > Hi John, > > > > Do we support 'N'? Since this is the first 'N' in the table. > > > > I guess not having a value implies feature is not supported. > > N or any other single letter is supported. > > The nice thing about it is that it is explicitly NO rather than implicitly > NO. However, if all the nics filled in the NOes then the table might be > hard to read. > > So, for consistency it is probably best to just let the unsupported > features be blank. > > >