From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f172.google.com (mail-ua0-f172.google.com [209.85.217.172]) by dpdk.org (Postfix) with ESMTP id 06823FB1B for ; Tue, 20 Dec 2016 11:29:07 +0100 (CET) Received: by mail-ua0-f172.google.com with SMTP id 44so5171836uak.1 for ; Tue, 20 Dec 2016 02:29:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vYhjqtjXfkcHFrGPU1260fbmKgsI7dtcrwzjfEDd7Vo=; b=Hts0XDpUbDm9dckDPFEmzfRCeqOZLLtflrYpjGXI2PdgBdm1b8GEKuGqIM8Q4f/1rm iGzgYJqWdjUcCjnQ4D8I5fpa5sacxWCwXL1z5CYXGiDSdPAm6HMPWsLVLjlYarBiZ357 4Psi23nwoSUozohBLIrINk6Mylc0bOIkeNul9K1iqjy5Y2KrX63zzVrpzEOvEh4Y/GLb 1Jno+FslQeBxENC1xghiBo4HKQng5DdYkP+P/CtnTbnTOrebOR8yqB3CA9o6ScqrEze8 s7hLyzyzil25JRj/YWZjgsuPD39pNd4AXXWrvFabQIiGIyyVkWHaqJZaoA+AyWCFOHTS HhWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vYhjqtjXfkcHFrGPU1260fbmKgsI7dtcrwzjfEDd7Vo=; b=m/gfH8Nt07s6dH+LfHgZ9DDU0ZXchSWuSUtibNhP/Vo70yhTwj2dqMJ8wQDII4dS6M UH96mCd0pH07vDxBp8shFC424oN8IeZMHH0vr5uZpa/UflU0SEMSvTpfzJDVcZXKgwX8 URy0iIUGXwkAt7ggk9RxPU/yl9zPuJ/LEFFZD/i/F31RVBrhNsmaLh/O/8oIi4GrrAUs CglSjYuoNOpLKRnHOJY/C1es2InZ4BREVnTaQ7YWQc711DH1eTTNTTtTj6JVozNcGPDE sfnSyxLzc31S0gMr7nXGy3Hm1QoqbtFPeU+13YNOrOPxyl0k+mb4EGCdN58Y1cklemT3 hv4w== X-Gm-Message-State: AIkVDXK0lEYHPiu2FoXvPeAa1zE+TgeWaxeOjrGa1SXWjO42vcGucs9ejJwQvcU4bifg1kNk3Tr7kg5WsOP1qYJp X-Received: by 10.176.6.231 with SMTP id g94mr16082251uag.91.1482229746487; Tue, 20 Dec 2016 02:29:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.46.3 with HTTP; Tue, 20 Dec 2016 02:29:06 -0800 (PST) In-Reply-To: References: <1482149104-40805-1-git-send-email-alejandro.lucero@netronome.com> <3dd84942-5c7b-5f3f-2760-a71f97dfcd6a@intel.com> From: Alejandro Lucero Date: Tue, 20 Dec 2016 10:29:06 +0000 Message-ID: To: Ferruh Yigit Cc: dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] nfp: extend speed capabilities advertised X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 10:29:07 -0000 On Tue, Dec 20, 2016 at 10:25 AM, Ferruh Yigit wrote: > On 12/19/2016 6:00 PM, Alejandro Lucero wrote: > > I forgot one thing: to update the features file with this new one. > > > > I will wait for your feedback regarding the discussed problem for > > sending another version. > > I think it is good to go, please send updated version. > > OK > > > > <...> > > > > > Sorry, confused. Is it like following: > > > > " > > For new FW, there is no problem, it supports the range between > > 1G - 50G, > > and reports correct current speed. > > > > With old FW, device still can be set to speed range between 1G - > > 50G, > > but it doesn't report current speed correct, and DPDK driver > reports > > back to application as device current speed is 40G, without > really > > knowing the current speed. > > " > > > > > > Yes, that is. Should then I do anything else or the patch is right > > for you now? > > So, this patch is correct. > > But for the previous patch "net/nfp: report link speed using hardware > info", it would be nice to add above information into source as comment > and into commit log. > If you can, would you mind sending a new version of that patch? > > I'll do it. Thanks! > Thanks, > ferruh > > > > <...> >