From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f51.google.com (mail-vk0-f51.google.com [209.85.213.51]) by dpdk.org (Postfix) with ESMTP id 18B31FA59 for ; Mon, 19 Dec 2016 17:18:24 +0100 (CET) Received: by mail-vk0-f51.google.com with SMTP id 137so122354658vkl.0 for ; Mon, 19 Dec 2016 08:18:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ur4IT1Hk5uZZZub9ZZuB8bCsGkwYc1AlsalCB+JcFRE=; b=SxEcvZrQD0dv8mXRLDxiO0DCc5/uL9DwKVUEGIKOgje0KhAWohw1vnh2xYmmdeqM8J w9/sl4UJMPTFSUYzXIWEQu7nLmv21/zQSkAIvb/Ayn13sWd6yfpMaw8w3FfN8cO2mZ7M WmMaLI5ImN7D4ZEEHdVMennSSQ/IGHWDDWdtYIPKo4DDbKnJ16AZX8dJEnK3D706UCfP PdVhezpFiGKnKq1vAQ6wN4Jo+0tkbTNZmetX4d15WgoOIoSboqGpVFt6AH4Ev3VmN8Zb FlVVhE4RpLYOoGNyBzr3M4KFxK/ANsLErIsTuU/cPRBbrd2HOmmARqifr3pYDyVvVq/9 xtuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ur4IT1Hk5uZZZub9ZZuB8bCsGkwYc1AlsalCB+JcFRE=; b=kPIo1haVvYzaywD9zcCbV8rjLb5tAwV2yMquICT2JagCggsFHezFGYlgrzfQuzS422 PMuIQvab5tcM8TydeC6Pu9yBICt5xf1wc7+Hn3bQXnS1233B76j6DAcmQCLhuPw74y34 tyTMQAokcswmD0mdS/Bsig7AOwzbrJlUqiP2hti0OCvWvjBRIZfUOCgFryl/PT1YgC5W 9QSsaLh9FNcBDRE0vxZVDvL/57Ik2d3vCdV7YfsE52o5uo6u/1Mok8Gq0Z3251tseAW9 7erKr73rxOpeUCXUEbAEog33JnwY6zdBpbRJ6LO62rGidlElkD8QI0OUQ4LjLHtkfD0J e0+g== X-Gm-Message-State: AIkVDXKooY2dxImjhHSTazAmq71Oj125m/50/ptOhbzK9lMEXrlhmVKqLDyotG2SV3sDNRxMcOzFVOeoXng2b0NU X-Received: by 10.31.133.133 with SMTP id h127mr6319561vkd.26.1482164303510; Mon, 19 Dec 2016 08:18:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.46.3 with HTTP; Mon, 19 Dec 2016 08:18:22 -0800 (PST) In-Reply-To: <3dd84942-5c7b-5f3f-2760-a71f97dfcd6a@intel.com> References: <1482149104-40805-1-git-send-email-alejandro.lucero@netronome.com> <3dd84942-5c7b-5f3f-2760-a71f97dfcd6a@intel.com> From: Alejandro Lucero Date: Mon, 19 Dec 2016 16:18:22 +0000 Message-ID: To: Ferruh Yigit Cc: dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] nfp: extend speed capabilities advertised X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 16:18:24 -0000 On Mon, Dec 19, 2016 at 3:05 PM, Ferruh Yigit wrote: > On 12/19/2016 3:02 PM, Alejandro Lucero wrote: > > > > > > On Mon, Dec 19, 2016 at 2:36 PM, Ferruh Yigit > > wrote: > > > > Hi Alejandro, > > > > > > Hi, > > > > > > On 12/19/2016 12:05 PM, Alejandro Lucero wrote: > > > NFP supports more speeds than just 40 and 100GB, which were > > > what was advertised before. > > > > > > Signed-off-by: Alejandro Lucero > > > > --- > > > drivers/net/nfp/nfp_net.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > > > index 27afbfd..77015c4 100644 > > > --- a/drivers/net/nfp/nfp_net.c > > > +++ b/drivers/net/nfp/nfp_net.c > > > @@ -1077,7 +1077,9 @@ static void nfp_net_read_mac(struct > nfp_net_hw *hw) > > > dev_info->reta_size = NFP_NET_CFG_RSS_ITBL_SZ; > > > dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ; > > > > > > - dev_info->speed_capa = ETH_LINK_SPEED_40G | > ETH_LINK_SPEED_100G; > > > + dev_info->speed_capa = ETH_SPEED_NUM_1G | ETH_LINK_SPEED_10G > | > > > + ETH_SPEED_NUM_25G | ETH_SPEED_NUM_40G > | > > > + ETH_SPEED_NUM_50G | > ETH_LINK_SPEED_100G; > > > > Does all devices driver by this driver supports all these speeds? > > > > I am aware of at least one exception to this, from previous patch > [1], > > should we take that into account? > > > > > > So we have different NFP devices and different firmwares. > > NFP by design support all those speeds, but the PMD relies on the > > firmware for being able to know which is the current configured speed > > after link negotiation. PMD development was done with a specific > > firmware, and I was told to just report such speed by default. Last > > firmware versions give that speed info, but old firmware versions do not. > > > > So, all devices support such a speed range, indeed PMD works with any of > > them, but reported speed is always 40G with old firmware. This is a > > firmware limitation but we have to support old and new firmware. > > But this information to the application will be wrong for some (old) FW. > What do you think checking the FW version here and report capability > based on what FW supports? > > The driver advertises the right speed range supported. The problem is with the report about the current link speed configured. Maybe, is the right thing to do here to not report the current link speed because the driver really does not know about it? If you agree with this, I'm afraid the just accepted patch about the link report needs to be modified. > > > > > > > > Also other than that exception, can you please confirm all other > devices > > support all above speeds? > > > > [1] > > + if ((NFD_CFG_MAJOR_VERSION_of(hw->ver) < 4) || > > + ((NFD_CFG_MINOR_VERSION_of(hw->ver) == 4) && > > + (NFD_CFG_MINOR_VERSION_of(hw->ver) == 0))) > > + link.link_speed = ETH_SPEED_NUM_40G; > > > > > > > } > > > > > > static const uint32_t * > > > > > > > > >