From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by dpdk.org (Postfix) with ESMTP id AAD5B5F21 for ; Thu, 1 Nov 2018 11:48:37 +0100 (CET) Received: by mail-ed1-f66.google.com with SMTP id e5-v6so16168000eds.6 for ; Thu, 01 Nov 2018 03:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bHvY85ofbBfpz3q29MC8k9dCB7Ph4WiCcWeWo361l5k=; b=yyYd3UiAKtJv40JX/ZW1NFaeLSgf1dxloQvL9mhDHJRaR2tXJLMoTUFO3EPgLQzyMa A5BX6jlQG/m7qwI62KitqqWKhlHiXhHJ/JQ0TK61BPkSP+kMu/IaEMi653vspWQ2Qze3 eeNSneIn7WY5qJRgR8Lg0l42EhjjE5idHTK3/A9GJnEOauKJreUxei2vlmaql/H8s5jU n+7CnBbTb4xkFDQuq8Gz//1f8rAI+qOzopHMlU3FrkclhyTNON1UX2cMf9U7iLG/7+rw WXDKKnILuv8DYoCOkjZ7YZ+lZNnvUcAVyz+oPfVwkXBEdAAF73ZQydU2CIGpuBctWWAk 2cEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bHvY85ofbBfpz3q29MC8k9dCB7Ph4WiCcWeWo361l5k=; b=fAzUSid1S4Adc/OXESuBReNTG7TlBspe++vpc4UbXnCQMM6KOHOr+1uanFD+PRk9ve iAd+VqgJkTHHqFtR3oMoazNvOsBRmISieNS2j/2wGIfdX2rk25LVDjcmptlDXEh4cYe8 sOKOzqzCsqB1D5df8qn6qX9wpfTvQ0lt6akOUUkl0KGin+YwZvQNHkt+YwkD0zZ+V/OH vkpqa5y3NZ/IfaJfEptmx837sRPn+S8bfH0tIwvtA6bDidPvYZXA1uTv4MQPnL6H45RC rt9Av6doTha+TX3FcosjwUg+KScl+jSC/909S7p86X3NQVH66TByoee10vCA4/hypIpM zXJg== X-Gm-Message-State: AGRZ1gJJvAX24RflheEm3pby8uZxVdZpe4FkOCZek/hkVAlQOgSrsBtr lWeLsVj1ZI8L9QhWNifOLAE9VQhrOwISIwY8V9HNAA== X-Google-Smtp-Source: AJdET5eFJZoQZrwp8gdswlyIVMfM7VBsZEVfatIrBMNA4jWWII3X6XbJwoxqUKHXcoOCBHbFcYzC8pfXsloOu1YSPMU= X-Received: by 2002:a50:86e7:: with SMTP id 36-v6mr4605514edu.104.1541069317330; Thu, 01 Nov 2018 03:48:37 -0700 (PDT) MIME-Version: 1.0 References: <20181031172931.11894-1-alejandro.lucero@netronome.com> <20181031172931.11894-4-alejandro.lucero@netronome.com> <2be201f7-308f-53e1-715a-6c37b92de10b@intel.com> In-Reply-To: <2be201f7-308f-53e1-715a-6c37b92de10b@intel.com> From: Alejandro Lucero Date: Thu, 1 Nov 2018 10:48:26 +0000 Message-ID: To: "Burakov, Anatoly" Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 3/7] mem: add function for setting DMA mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Nov 2018 10:48:37 -0000 On Thu, Nov 1, 2018 at 10:11 AM Burakov, Anatoly wrote: > On 31-Oct-18 5:29 PM, Alejandro Lucero wrote: > > This patch adds the possibility of setting a dma mask to be used > > once the memory initialization is done. > > > > This is currently needed when IOVA mode is set by PCI related > > code and an x86 IOMMU hardware unit is present. Current code calls > > rte_mem_check_dma_mask but it is wrong to do so at that point > > because the memory has not been initialized yet. > > > > Signed-off-by: Alejandro Lucero > > --- > > lib/librte_eal/common/eal_common_memory.c | 10 ++++++++++ > > lib/librte_eal/common/include/rte_memory.h | 10 ++++++++++ > > lib/librte_eal/rte_eal_version.map | 1 + > > 3 files changed, 21 insertions(+) > > > > diff --git a/lib/librte_eal/common/eal_common_memory.c > b/lib/librte_eal/common/eal_common_memory.c > > index e0f08f39a..24b72fcb0 100644 > > --- a/lib/librte_eal/common/eal_common_memory.c > > +++ b/lib/librte_eal/common/eal_common_memory.c > > @@ -480,6 +480,16 @@ rte_mem_check_dma_mask(uint8_t maskbits) > > return 0; > > } > > > > +/* set dma mask to use when memory initialization is done */ > > +void __rte_experimental > > +rte_mem_set_dma_mask(uint8_t maskbits) > > +{ > > + struct rte_mem_config *mcfg = > rte_eal_get_configuration()->mem_config; > > + > > + mcfg->dma_maskbits = mcfg->dma_maskbits == 0 ? maskbits : > > + RTE_MIN(mcfg->dma_maskbits, maskbits); > > +} > > + > > /* return the number of memory channels */ > > unsigned rte_memory_get_nchannel(void) > > { > > diff --git a/lib/librte_eal/common/include/rte_memory.h > b/lib/librte_eal/common/include/rte_memory.h > > index ad3f3cfb0..eff028db1 100644 > > --- a/lib/librte_eal/common/include/rte_memory.h > > +++ b/lib/librte_eal/common/include/rte_memory.h > > @@ -466,6 +466,16 @@ unsigned rte_memory_get_nrank(void); > > /* check memsegs iovas are within a range based on dma mask */ > > int __rte_experimental rte_mem_check_dma_mask(uint8_t maskbits); > > > > +/** > > + * * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > I think there's a copy-paste error here (extra star and indent before > warning). > I will fix this. Thanks. > > > + * > > + * Set dma mask to use once memory initialization is done. > > + * Previous function rte_mem_check_dma_mask can not be used > > + * safely until memory has been initialized. > > IMO this really requires a big bold warning saying that this function > must only be called early during initialization, before memory is > initialized, and not to be called in user code. > > what about adding a new EAL variable for keeping memory initialization status? It would be something like "uninit" until is changed to "done" after the memory initialization is completed. That variable would help to avoid effective calls to set the dma mask after initialization. > > + */ > > +void __rte_experimental rte_mem_set_dma_mask(uint8_t maskbits); > > + > > /** > > * Drivers based on uio will not load unless physical > > * addresses are obtainable. It is only possible to get > > diff --git a/lib/librte_eal/rte_eal_version.map > b/lib/librte_eal/rte_eal_version.map > > index ef8126a97..ae24b5c73 100644 > > --- a/lib/librte_eal/rte_eal_version.map > > +++ b/lib/librte_eal/rte_eal_version.map > > @@ -296,6 +296,7 @@ EXPERIMENTAL { > > rte_devargs_remove; > > rte_devargs_type_count; > > rte_mem_check_dma_mask; > > + rte_mem_set_dma_mask; > > Same, this needs to be alphabetic. > > > rte_eal_cleanup; > > rte_fbarray_attach; > > rte_fbarray_destroy; > > > > > -- > Thanks, > Anatoly >