From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it1-f194.google.com (mail-it1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id A71C61B147 for ; Mon, 14 Jan 2019 20:26:33 +0100 (CET) Received: by mail-it1-f194.google.com with SMTP id h193so1059199ita.5 for ; Mon, 14 Jan 2019 11:26:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+1/AR459zoqFZDsRnrb9xToUnY3pPLapye3QtuAnD6g=; b=czXgDlTV2lsA56DAsXtz66eRNhP7S7sv/Wm6kYXTquoEPDLLilVHdjucb4fzt4bYAn deuAFX6+O8A3/KoFBI8+oDHT7SZ/JE5SQhGAhmzTuLPxkgXd9CO5bl8bBFW7UCnjv5Zi NRNSrLxeMMxq+/CvwwuGEAVt3c8Gzq6Z2nXDX1hroiKJUGiBe/dwg+nPiL8QJIZzcsCt aINWjLnLAG3/BgQJtwuR4/OXCWFy22A9kho0O+xILayaD9IGZlVEmM5JXtM33AeOf7X/ E0UUheHJHjJfYqqujiw6SYx1r9RVBtVlXasTAdEHk010WnegMMXIFcRXprsjfk8RPwvG VAyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+1/AR459zoqFZDsRnrb9xToUnY3pPLapye3QtuAnD6g=; b=NUBwNHzOTkO3G7NftdwVyZQzznFXK6VN7+1HQ8NdxwEDsb+ymjsLTQ1nOIPTLYszZ6 TkduB2g1nPE3hAuTghIqQvaqKNL/sBDylDiZ9gt3FRoqjFPgelw7nnKCRgiT7eJFWURX 1hsiTDGLn10UAq8qMBj6Lxt2W9/2eWdOdHbiZKEbGE1OvbJy+CVqi7B7ctMEooRUQJIF 1UDVk/k+ysqann9AFBqMN9F3baebked4I6QjVDGmTRB+wlY5mjn3JSuBQFa9axS/0uSZ V3XvNlGNwWEM69d7GA1ts74/H0vwvpATcSVzgrEd1B9DdHmpiMyhE4Qhqtu80n7SKulw mLPg== X-Gm-Message-State: AJcUukc2d7VGQp5KA80FhyaqBLl4HS2JWE7ty0Leuq4qvD5x/bZ0KsO8 5tyHpX71Ow+LZe6r6k4Qpb0t8tYs5e4Z1TP1C+HnOr9/ X-Google-Smtp-Source: ALg8bN5XhG1WJQpgn/nr24oNP8dAMPuGE+EYKdxVrCESCpv1P504JnA1Zd/my6Him+7ulU8L2ESToTXeS7woYBhWFUg= X-Received: by 2002:a02:b697:: with SMTP id i23mr2861jam.119.1547493992986; Mon, 14 Jan 2019 11:26:32 -0800 (PST) MIME-Version: 1.0 References: <20190111132553.10683-1-alejandro.lucero@netronome.com> <2981184f-f2ef-b475-53af-e530a9551e60@intel.com> <11471688.z4v4DX61lF@xps> In-Reply-To: <11471688.z4v4DX61lF@xps> From: Alejandro Lucero Date: Mon, 14 Jan 2019 19:26:22 +0000 Message-ID: To: Thomas Monjalon Cc: Ferruh Yigit , dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/nfp: add CPP bridge as service X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2019 19:26:33 -0000 On Mon, Jan 14, 2019 at 6:54 PM Thomas Monjalon wrote: > 14/01/2019 19:29, Alejandro Lucero: > > On Mon, Jan 14, 2019 at 6:22 PM Ferruh Yigit > wrote: > > > > > On 1/14/2019 6:00 PM, Alejandro Lucero wrote: > > > > > > > > > > > > On Mon, Jan 14, 2019 at 10:40 AM Ferruh Yigit < > ferruh.yigit@intel.com > > > > > wrote: > > > > > > > > On 1/13/2019 9:41 PM, Thomas Monjalon wrote: > > > > > 11/01/2019 17:42, Ferruh Yigit: > > > > >> On 1/11/2019 1:25 PM, Alejandro Lucero wrote: > > > > >>> The Netronome's Network Flow Processor chip is highly > > > programmable > > > > >>> with the goal of processing packets at high speed. Processing > > > units > > > > >>> and other chip components are available from the host > through the > > > > >>> PCIe CPP(Command Push Pull bus) interface. The NFP PF PMD > > > configures > > > > >>> a CPP handler for setting up and working with vNICs, perform > > > actions > > > > >>> like link up or down, or accessing extended stats from the > MAC > > > component. > > > > >>> > > > > >>> There exist NFP host tools which access the NFP components > for > > > > >>> programming and debugging but they require the CPP interface. > > > When the > > > > >>> PMD is bound to the PF, the DPDK app owns the CPP interface, > so > > > these > > > > >>> host tools can not access the NFP through other means like > NFP > > > kernel > > > > >>> drivers. > > > > >>> > > > > >>> This patch adds a CPP bridge using the rte_service API which > can > > > be > > > > >>> enabled by a DPDK app. Interestingly, DPDK clients like OVS > will > > > not > > > > >>> enable specific service cores, but this can be performed > with a > > > > >>> secondary process specifically enabling this CPP bridge > service > > > and > > > > >>> therefore giving access to the NFP to those host tools. > > > > >>> > > > > >>> v2: > > > > >>> - Avoid printfs for debugging > > > > >>> - fix compilation problems for powerpc > > > > >>> > > > > >>> Signed-off-by: Alejandro Lucero < > alejandro.lucero@netronome.com > > > > > > > > > >> > > > > >> Applied to dpdk-next-net/master, thanks. > > > > > > > > > > It does not compile with 32-bit toolchain. > > > > > > > > > > Please check the occurences of %lu, thanks. > > > > > > > > Hi Thomas, > > > > > > > > We aware the build error, but let it because nfp doesn't support > > > 32-bit. > > > > > > > > But I just recognized that it is enabled by default on 32-bit > > > default configs, > > > > we should disable them. > > > > > > > > > > > > Hi Alejandro, > > > > > > > > Can you please disable nfp driver explicitly on > > > > 'defconfig_i686-native-linuxapp-*' config files, perhaps also on > > > > 'defconfig_x86_x32-native-linuxapp-gcc' too? > > > > > > > > I will drop the existing patch from next-net. > > > > > > > > > > > > Ok. I'll do asap. > > > > > > > > > > > > And if it is possible to fix the build error, specially if it is > > > just for %lu of > > > > the logging, I prefer the fix against the config update, but it > is > > > up to you. > > > > > > > > > > > > I did not see any logging error/warning when compiling nor any when > using > > > > checkpatch. I have used a gcc 7.3.1 (Ubuntu) and a 8.2.1 (RH). What > are > > > you > > > > using for triggering such error? > > > > > > Using 'i686-native-linuxapp-gcc' config, which is for 32-bit, gives > > > following > > > build error [1] with this patch. > > > > > > > > OK. But after the patch I have just sent for removing NFP PMD from 32 > bits > > builds, nothing is really needed then. Right? > > > > If so, should I send the patch again about the CPP bridge or you can redo > > it? > > I will re-apply it on master. > > > Great. Thanks!