Re: [dpdk-dev] [PATCH v2 16/18] doc: update NFP with PF support information

[Alejandro Lucero <alejandro.lucero@netronome.com>]

Hi John,

Thanks for your review. I will modify the doc in next patch set version.

I'll wait until Ferruh give me the green light for sending the new version.


On Mon, Sep 4, 2017 at 3:20 PM, Mcnamara, John <john.mcnamara@intel.com>
wrote:

>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Alejandro Lucero
> > Sent: Friday, September 1, 2017 3:12 PM
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 16/18] doc: update NFP with PF support
> > information
> >
> > NFP PMD has now support for both, PF and VFs. This patch updates the
> guide
> > and give some information about implications.
> >
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
>
>
> Minor comments below.
>
> >..
> > -The NFP Linux kernel drivers (including the required PF driver for the
> > -NFP) are available on Github at
> > +The NFP Linux netdev kernel driver for VFs is part of vanilla kernel
> > +since kernel vesion 4.5, and support for the PF since kernel version
>
> s/vesion/version/
>
>
> > -DPDK runs in userspace and PMDs uses the Linux kernel UIO interface to -
> > allow access to physical devices from userspace. The NFP PMD requires
> -the
> > **igb_uio** UIO driver, available with DPDK, to perform correct -
> > initialization.
> > +NFP PMD needs to be used along with UIO **igb_uio** or VFIO (vfio-pci)
> > +Linux kernel driver.
>
>
> Probably better to fixed-width quote these as``igb_uio`` or ``vfio-pci``,
> here and in other places.
>
>
> > +Using the PF
> > +------------
> > +
> > +NFP PMD has support for using the NFP PF as another DPDK port, but it
> > +has not
>
> s/but it has not/but it does not have/
>
>
> > +possible to use the PMD with the VFs if the PF is being used by DPDK,
> > +this is, NFP PF bound to igb_uio or vfio-pci kernel drivers. Future
>
>
> s/this is, NFP PF/that is, with the NFP PF/
>
> > +DPDK version will have a PMD able to work with the PF and VFs at the
> > +same time and with the PF implementing VF management along wih other PF-
>
> s/wih/with/
>
>
> > +Depending on the Netronome's product installed in the system, firmware
>
> s/Netronome's/Netronome/
>
> > +files should be available under /lib/firmware/netronome. DPDK PMD
> > +supporting the PF requires a specific link,
> > +/lib/firmware/netronome/nic_dpdk_default.nffw, which should be created
> > automatically with Netronome's Agilio products installation.
>
> Fixed-width quote the file paths: ``/lib/firmware/netronome``, etc.
>
> > +
> > +PF multiport support
> > +--------------------
> > +
> > +Some NFP cards support several physical ports with just one single PCI
> > device.
> > +DPDK core is designed with the 1:1 relationship between PCI devices and
> > +DPDK ports, so NFP PMD PF support requires to handle the multiport case
>
> s/to handle/handling/
>
> > specifically.
> > +During NFP PF initialization, the PMD will extract the information
> > +about the number of PF ports from the firmware and will create as many
> > +DPDK ports as needed.
> > +
> > +Because the unusual relationship between a single PCI device and
> > +several DPDK ports, there are some limitations when using more than one
> > +PF DPDK ports: there is no support for RX interrrupts and it is not
>
> s/interrrupts/interrupts/
>
>
> Reviewed-by: John McNamara <john.mcnamara@intel.com>
>
>
>