From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f172.google.com (mail-ua0-f172.google.com [209.85.217.172]) by dpdk.org (Postfix) with ESMTP id 20A7EF962 for ; Mon, 19 Dec 2016 16:02:12 +0100 (CET) Received: by mail-ua0-f172.google.com with SMTP id y13so57218607uay.1 for ; Mon, 19 Dec 2016 07:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZknI4CoA857QjlHPFwJn+9PdAXE5zxPGKS2I6JPd0RY=; b=OD/tNQMDGL9JB8oh3xRkU6BwDJonw0gp0lBC1mN14yKHI9Xz1cEBvKNv0dVlkHTl7f SyzgOOFVvv2XPu9IaTi4q7lu9unCJgItCrYVdAE6MUkegmSI4M4BdWOn+YtnPOa44u57 hHk55UnB1K6L7SgKXZ0O/JVLV9aUm+qBriK/hAw20LhtgVnWtit1upWF/kMIK9wQja+o 89S777fmdb4ai+1n9ptRfsgZ3fM+Q42EsA3/sbCq1RPdLEVLJL05P0Mzyw4oYlRq6Zct 5sOg78iOnouYhMlIO6LIVYx+9pyjJPRLQIo7Ew341eO1lrOVtp3mdM2oJqz03xGEkwl6 kz4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZknI4CoA857QjlHPFwJn+9PdAXE5zxPGKS2I6JPd0RY=; b=KvQhqOFh9Oi81nVdwHN/JV6h0VaVyjQlOpcWkCTLvo8MvHvSqEKtMCYqVecaoSYX4S gxRacL+C98KuEUlqTz5uVZ/Ktu1KOtw0g5E2pZZ0higdjtUdt+rxgA5WBJu/MIP1qYsF YV3SFfEi5uv42c44yJ5tvmbq0dALBkmR9lmbuxgf90AiZOm5cfMRQ+xK4OuJznsHOgm9 FImQ7OipTiaJ+SpPdc5ybLLgIRu9xxDnZ89nj+RTVXUIjHQYKtawdrldp//RfO1xixaA YhtlW+gl/XTBgcJn9vUa+kpWs954V5adee8aEhR6rzp5m42+v4CWNNBBrAHaPhDmpMdQ ulBQ== X-Gm-Message-State: AIkVDXImcspiFTHoAvRrR/lJS2F1zLxR/rdWDexvW0jHgZg2jMMSXHCTL25U3vpAspgS2EcMwqsXaq7vvjwwtkv5 X-Received: by 10.159.48.65 with SMTP id i1mr13097034uab.12.1482159731522; Mon, 19 Dec 2016 07:02:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.46.3 with HTTP; Mon, 19 Dec 2016 07:02:11 -0800 (PST) In-Reply-To: References: <1482149104-40805-1-git-send-email-alejandro.lucero@netronome.com> From: Alejandro Lucero Date: Mon, 19 Dec 2016 15:02:11 +0000 Message-ID: To: Ferruh Yigit Cc: dev Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] nfp: extend speed capabilities advertised X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 15:02:12 -0000 On Mon, Dec 19, 2016 at 2:36 PM, Ferruh Yigit wrote: > Hi Alejandro, > > Hi, > On 12/19/2016 12:05 PM, Alejandro Lucero wrote: > > NFP supports more speeds than just 40 and 100GB, which were > > what was advertised before. > > > > Signed-off-by: Alejandro Lucero > > --- > > drivers/net/nfp/nfp_net.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c > > index 27afbfd..77015c4 100644 > > --- a/drivers/net/nfp/nfp_net.c > > +++ b/drivers/net/nfp/nfp_net.c > > @@ -1077,7 +1077,9 @@ static void nfp_net_read_mac(struct nfp_net_hw *hw) > > dev_info->reta_size = NFP_NET_CFG_RSS_ITBL_SZ; > > dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ; > > > > - dev_info->speed_capa = ETH_LINK_SPEED_40G | ETH_LINK_SPEED_100G; > > + dev_info->speed_capa = ETH_SPEED_NUM_1G | ETH_LINK_SPEED_10G | > > + ETH_SPEED_NUM_25G | ETH_SPEED_NUM_40G | > > + ETH_SPEED_NUM_50G | ETH_LINK_SPEED_100G; > > Does all devices driver by this driver supports all these speeds? > > I am aware of at least one exception to this, from previous patch [1], > should we take that into account? > > So we have different NFP devices and different firmwares. NFP by design support all those speeds, but the PMD relies on the firmware for being able to know which is the current configured speed after link negotiation. PMD development was done with a specific firmware, and I was told to just report such speed by default. Last firmware versions give that speed info, but old firmware versions do not. So, all devices support such a speed range, indeed PMD works with any of them, but reported speed is always 40G with old firmware. This is a firmware limitation but we have to support old and new firmware. > Also other than that exception, can you please confirm all other devices > support all above speeds? > > [1] > + if ((NFD_CFG_MAJOR_VERSION_of(hw->ver) < 4) || > + ((NFD_CFG_MINOR_VERSION_of(hw->ver) == 4) && > + (NFD_CFG_MINOR_VERSION_of(hw->ver) == 0))) > + link.link_speed = ETH_SPEED_NUM_40G; > > > > } > > > > static const uint32_t * > > > >