From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 73E93A0548; Thu, 1 Apr 2021 18:05:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E0D0406FF; Thu, 1 Apr 2021 18:05:44 +0200 (CEST) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by mails.dpdk.org (Postfix) with ESMTP id 6638140696 for ; Thu, 1 Apr 2021 18:05:42 +0200 (CEST) Received: by mail-lf1-f52.google.com with SMTP id o10so3583287lfb.9 for ; Thu, 01 Apr 2021 09:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8IjoOgT/JxScE1+MrGWeSCBPXFA57CW5OVFOAHR0JiY=; b=dG9GXfF3njN77JR02qfd2VZrhHdEIvRqnYpNn5Fxb7HvrPiRbxTvVPOLM/oBtEAR+T 6KuTvhSd3zE7ghcuIHGbiV+pclz9UAKKI9fIua4mD60+okpNjy2mUhGg2jcxau+CPW8b lGiACvXBpmejlDHBAzBnjbeX6wYyytsYGL0eY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8IjoOgT/JxScE1+MrGWeSCBPXFA57CW5OVFOAHR0JiY=; b=RWIvWHofGptoZVNCtq4d1lwoY0QvEEvRzaGohxFdgmTdMC3kDJ1rlmQkS6GVcDN9om i2+GNWuT48fso7bkgcL1VMXAMFpiEuwrYiw9UWo35i+aG7qat1K5l7bKxuAle9icl8wq LA+N1gKKpUt13BRWWbRhpu7S2KM3tExdGUbaA6dmYI5NAcbHXSrsjcrWWpKU/MxC9cyd zZBEp2jmFOMKXz6/peh7U8yYRwQbMpy2bnn5K4bXolFrfxlh8RxhDibSQwRkbibTpDPC MzxuhuNGP0hyVYEfWp788nzK0rOVjWZqfv+gSow3+YD6r3PJTEpE1LklUXLDjgKZJVpo dSoA== X-Gm-Message-State: AOAM533bHU91pj5JaIWzRoZluNEXKez/t69O4m+Z0tFJdheLZS4ZuvGM qlVcErMmhLPLSuiQbqtnA4ZiTa787b/KApKUyrACpQ== X-Google-Smtp-Source: ABdhPJygOP6RYqYe90JBt8MP6+H1c8/0EUqJl7VWf3TTwyC9H0gcNfJmP7bI1LNyZdzS8ZaaUk29tKvDLSUI3TBvgMs= X-Received: by 2002:ac2:5f19:: with SMTP id 25mr6101712lfq.328.1617293141940; Thu, 01 Apr 2021 09:05:41 -0700 (PDT) MIME-Version: 1.0 References: <20210322072257.2017227-1-keiichiw@chromium.org> <20210322072257.2017227-2-keiichiw@chromium.org> In-Reply-To: From: Keiichi Watanabe Date: Fri, 2 Apr 2021 01:05:30 +0900 Message-ID: To: "Kinsella, Ray" Cc: Ferruh Yigit , dev@dpdk.org, Dylan Reid , Chirantan Ekbote , Maxime Coquelin , Chenbo Xia , Neil Horman , David Marchand Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v2 1/2] vhost: Add API to get negotiated protocol features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks for the review! Should I send the updated version of the patch series? Or, can I ask you to make the follow up changes as a maintainer? Keiichi On Thu, Apr 1, 2021 at 5:42 PM Kinsella, Ray wrote: > > > On 31/03/2021 17:45, Ferruh Yigit wrote: > > On 3/22/2021 7:22 AM, Keiichi Watanabe wrote: > >> Add rte_vhost_get_negotiated_protocol_features, which returns a set of > >> enabled protocol features. > >> > >> Signed-off-by: Keiichi Watanabe > > > > <...> > > > >> diff --git a/lib/librte_vhost/version.map b/lib/librte_vhost/version.map > >> index 9183d6f2f..95c4c0990 100644 > >> --- a/lib/librte_vhost/version.map > >> +++ b/lib/librte_vhost/version.map > >> @@ -63,6 +63,7 @@ EXPERIMENTAL { > >> rte_vhost_va_from_guest_pa; > >> rte_vhost_extern_callback_register; > >> rte_vhost_driver_set_protocol_features; > >> + rte_vhost_get_negotiated_protocol_features; > >> rte_vhost_set_inflight_desc_split; > >> rte_vhost_set_inflight_desc_packed; > >> rte_vhost_set_last_inflight_io_split; > > > > Added the release version that experimental API is added as comment in > next-net, like following: > > > > +++ b/lib/librte_vhost/version.map > > @@ -76,4 +76,7 @@ EXPERIMENTAL { > > rte_vhost_async_channel_unregister; > > rte_vhost_submit_enqueue_burst; > > rte_vhost_poll_enqueue_completed; > > + > > + # added in 21.05 > > + rte_vhost_get_negotiated_protocol_features; > > }; > > > > > > We are doing this already in many libraries [1], this helps us easily > observe how long an API is staying as experimental in a library. > > Good idea. > > > [1]: > https://git.dpdk.org/dpdk/tree/lib/librte_eal/version.map?h=v21.02#n407 >