DPDK patches and discussions
 help / color / mirror / Atom feed
From: Keiichi Watanabe <keiichiw@chromium.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "Kinsella, Ray" <mdr@ashroe.eu>,
	dev@dpdk.org, Dylan Reid <dgreid@chromium.org>,
	 Chirantan Ekbote <chirantan@chromium.org>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	 Chenbo Xia <chenbo.xia@intel.com>,
	Neil Horman <nhorman@tuxdriver.com>,
	 David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] vhost: Add API to get negotiated protocol features
Date: Fri, 2 Apr 2021 01:38:56 +0900
Message-ID: <CAD90VcadhZzHYkbgO2YDgmvshB8wM9KZKthEb8CnP42ZVNDqbQ@mail.gmail.com> (raw)
In-Reply-To: <1d758e29-e9cd-1adb-02c0-b23d26a4878d@intel.com>

On Fri, Apr 2, 2021 at 1:28 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 4/1/2021 5:05 PM, Keiichi Watanabe wrote:
> > Thanks for the review!
> > Should I send the updated version of the patch series? Or, can I ask you
> to make
> > the follow up changes as a maintainer?
> >
>
> No new version is required, already updated in the next-net [1] repo.
>

Oh, you already added the version number there. Cool!
Thank you!

Keiichi



>
> [1] https://git.dpdk.org/next/dpdk-next-net/
>
> > Keiichi
> >
> > On Thu, Apr 1, 2021 at 5:42 PM Kinsella, Ray <mdr@ashroe.eu
> > <mailto:mdr@ashroe.eu>> wrote:
> >
> >
> >
> >     On 31/03/2021 17:45, Ferruh Yigit wrote:
> >      > On 3/22/2021 7:22 AM, Keiichi Watanabe wrote:
> >      >> Add rte_vhost_get_negotiated_protocol_features, which returns a
> set of
> >      >> enabled protocol features.
> >      >>
> >      >> Signed-off-by: Keiichi Watanabe <keiichiw@chromium.org
> >     <mailto:keiichiw@chromium.org>>
> >      >
> >      > <...>
> >      >
> >      >> diff --git a/lib/librte_vhost/version.map
> b/lib/librte_vhost/version.map
> >      >> index 9183d6f2f..95c4c0990 100644
> >      >> --- a/lib/librte_vhost/version.map
> >      >> +++ b/lib/librte_vhost/version.map
> >      >> @@ -63,6 +63,7 @@ EXPERIMENTAL {
> >      >>       rte_vhost_va_from_guest_pa;
> >      >>       rte_vhost_extern_callback_register;
> >      >>       rte_vhost_driver_set_protocol_features;
> >      >> +    rte_vhost_get_negotiated_protocol_features;
> >      >>       rte_vhost_set_inflight_desc_split;
> >      >>       rte_vhost_set_inflight_desc_packed;
> >      >>       rte_vhost_set_last_inflight_io_split;
> >      >
> >      > Added the release version that experimental API is added as
> comment in
> >     next-net, like following:
> >      >
> >      > +++ b/lib/librte_vhost/version.map
> >      > @@ -76,4 +76,7 @@ EXPERIMENTAL {
> >      >         rte_vhost_async_channel_unregister;
> >      >         rte_vhost_submit_enqueue_burst;
> >      >         rte_vhost_poll_enqueue_completed;
> >      > +
> >      > +       # added in 21.05
> >      > +       rte_vhost_get_negotiated_protocol_features;
> >      >  };
> >      >
> >      >
> >      > We are doing this already in many libraries [1], this helps us
> easily
> >     observe how long an API is staying as experimental in a library.
> >
> >     Good idea.
> >
> >      > [1]:
> >
> https://git.dpdk.org/dpdk/tree/lib/librte_eal/version.map?h=v21.02#n407
> >     <
> https://git.dpdk.org/dpdk/tree/lib/librte_eal/version.map?h=v21.02#n407>
> >
>
>

  reply	other threads:[~2021-04-01 16:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22  7:22 [dpdk-dev] [PATCH v2 0/2] " Keiichi Watanabe
2021-03-22  7:22 ` [dpdk-dev] [PATCH v2 1/2] " Keiichi Watanabe
2021-03-25 14:16   ` Maxime Coquelin
2021-03-31 16:45   ` Ferruh Yigit
2021-04-01  8:42     ` Kinsella, Ray
2021-04-01 16:05       ` Keiichi Watanabe
2021-04-01 16:28         ` Ferruh Yigit
2021-04-01 16:38           ` Keiichi Watanabe [this message]
2021-03-22  7:22 ` [dpdk-dev] [PATCH v2 2/2] examples/vhost_blk: Check protocol features before getting inflight info Keiichi Watanabe
2021-03-25 14:18   ` Maxime Coquelin
2021-03-31  6:45 ` [dpdk-dev] [PATCH v2 0/2] vhost: Add API to get negotiated protocol features Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAD90VcadhZzHYkbgO2YDgmvshB8wM9KZKthEb8CnP42ZVNDqbQ@mail.gmail.com \
    --to=keiichiw@chromium.org \
    --cc=chenbo.xia@intel.com \
    --cc=chirantan@chromium.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dgreid@chromium.org \
    --cc=ferruh.yigit@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=mdr@ashroe.eu \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git