From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DB6BA09E4; Thu, 1 Apr 2021 18:39:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 260F7406FF; Thu, 1 Apr 2021 18:39:10 +0200 (CEST) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mails.dpdk.org (Postfix) with ESMTP id 0765540696 for ; Thu, 1 Apr 2021 18:39:08 +0200 (CEST) Received: by mail-lf1-f45.google.com with SMTP id q29so3759628lfb.4 for ; Thu, 01 Apr 2021 09:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=11lijfYXLmiE4d4IgDW1WXMBItcSkYs7ar0znGTcdu4=; b=TZtuHFqnE8CQ8qLq832/11xZVhV4P/YHPjqyEaJTi776joT6965iAAkWhVMVk/offt MG3YVNVhvDAmkChWgSBhJEKjOk6JZ34KgBKZYT5rfMVCN6ApuC5/HQ2YuCHfSDwDcKwj KawS8YISF1ndASJ5Wxs2wIrTYCfZY24ek4kNE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=11lijfYXLmiE4d4IgDW1WXMBItcSkYs7ar0znGTcdu4=; b=H8W/OW7Dj/eDMFwbNPOQ14tRZf1T2eVl0t171BKd6uyEv9TWZ8mxnzj7GhP+zsB1h/ qAFLPJzv4zGjCfE3ddjSCNAngm6IErAK8HCO6ztuo+95LXXIhFifNc0J90haM5rBhTPS RLVBC3Ncrfw8dS0xon98BUo4sLoJWQnWpY2YcD1RLMto7767KsSgnhNvO6V+qPDaLWN+ XhLsqDlbWYSqzmTSRoNNm+4TB+jS1s/W5feBEhHVOauI7AB25GN2mQI0TAcyGVAuAGad Vm4S5Gze3/8WImKHwewHiVFVmSeQmvhLBQkeWa2FfMVpblhaRbbERbsUsX9oQ7bB+Zda Vh9g== X-Gm-Message-State: AOAM53372Nnj9yW74Gnf16EggUY6znM7IjbrvjKbXUTkt4mOzLtqO6W4 qOqa3CIHNq8S3K+eXRkSKiSAlaTDsgRmh9Aqb0mNHw== X-Google-Smtp-Source: ABdhPJxxibBaP4s16pi50boZqpe/zOhuz8AhxbeCB/pNMm0BEH45pXw2twEOzLUXXOPUsI7QvWucQ/N9LVd3tLe2BE0= X-Received: by 2002:ac2:5e3b:: with SMTP id o27mr5908696lfg.392.1617295148542; Thu, 01 Apr 2021 09:39:08 -0700 (PDT) MIME-Version: 1.0 References: <20210322072257.2017227-1-keiichiw@chromium.org> <20210322072257.2017227-2-keiichiw@chromium.org> <1d758e29-e9cd-1adb-02c0-b23d26a4878d@intel.com> In-Reply-To: <1d758e29-e9cd-1adb-02c0-b23d26a4878d@intel.com> From: Keiichi Watanabe Date: Fri, 2 Apr 2021 01:38:56 +0900 Message-ID: To: Ferruh Yigit Cc: "Kinsella, Ray" , dev@dpdk.org, Dylan Reid , Chirantan Ekbote , Maxime Coquelin , Chenbo Xia , Neil Horman , David Marchand Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v2 1/2] vhost: Add API to get negotiated protocol features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Apr 2, 2021 at 1:28 AM Ferruh Yigit wrote: > On 4/1/2021 5:05 PM, Keiichi Watanabe wrote: > > Thanks for the review! > > Should I send the updated version of the patch series? Or, can I ask you > to make > > the follow up changes as a maintainer? > > > > No new version is required, already updated in the next-net [1] repo. > Oh, you already added the version number there. Cool! Thank you! Keiichi > > [1] https://git.dpdk.org/next/dpdk-next-net/ > > > Keiichi > > > > On Thu, Apr 1, 2021 at 5:42 PM Kinsella, Ray > > wrote: > > > > > > > > On 31/03/2021 17:45, Ferruh Yigit wrote: > > > On 3/22/2021 7:22 AM, Keiichi Watanabe wrote: > > >> Add rte_vhost_get_negotiated_protocol_features, which returns a > set of > > >> enabled protocol features. > > >> > > >> Signed-off-by: Keiichi Watanabe > > > > > > > > <...> > > > > > >> diff --git a/lib/librte_vhost/version.map > b/lib/librte_vhost/version.map > > >> index 9183d6f2f..95c4c0990 100644 > > >> --- a/lib/librte_vhost/version.map > > >> +++ b/lib/librte_vhost/version.map > > >> @@ -63,6 +63,7 @@ EXPERIMENTAL { > > >> rte_vhost_va_from_guest_pa; > > >> rte_vhost_extern_callback_register; > > >> rte_vhost_driver_set_protocol_features; > > >> + rte_vhost_get_negotiated_protocol_features; > > >> rte_vhost_set_inflight_desc_split; > > >> rte_vhost_set_inflight_desc_packed; > > >> rte_vhost_set_last_inflight_io_split; > > > > > > Added the release version that experimental API is added as > comment in > > next-net, like following: > > > > > > +++ b/lib/librte_vhost/version.map > > > @@ -76,4 +76,7 @@ EXPERIMENTAL { > > > rte_vhost_async_channel_unregister; > > > rte_vhost_submit_enqueue_burst; > > > rte_vhost_poll_enqueue_completed; > > > + > > > + # added in 21.05 > > > + rte_vhost_get_negotiated_protocol_features; > > > }; > > > > > > > > > We are doing this already in many libraries [1], this helps us > easily > > observe how long an API is staying as experimental in a library. > > > > Good idea. > > > > > [1]: > > > https://git.dpdk.org/dpdk/tree/lib/librte_eal/version.map?h=v21.02#n407 > > < > https://git.dpdk.org/dpdk/tree/lib/librte_eal/version.map?h=v21.02#n407> > > > >