From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 48DA95946 for ; Thu, 21 May 2015 16:59:37 +0200 (CEST) Received: by wibt6 with SMTP id t6so17104409wib.0 for ; Thu, 21 May 2015 07:59:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=mwO+h01hdr2k7kedKORMzj8kLYsDIYodoU1bff6Fmqk=; b=FAIAu96KHb8Zs0cgbnAuxaoLYu5XKHugYGAGUtu3cHm9bMTobqvrBgCNu8E13XMFOO jMS7DvqxO7Qf5L2dlUMnQFZKvTTRlEqynLs5iGC1M2cOj6dlKyEyCjST3EXYnDusmoko NWaja+8FTDfLneSXpWSPdeg0hEzA6Sc3Hw9QZiiGfLrbjjkNjQhg8C1jcRK3vuJWxrSR /QW+Tcj/TUd9jcp7UwoGWkoEDACf3AHcJtvckPJrb1LXYYO3Kq2B5YdJglxWLgBjGh5I 7qkBkuoDEQ7eVoRG/+L5P0vkeTJrGGKj4bYG/ePFq07CH9Rf0kilnWW0WHaW3wmCDKIf QNqg== X-Gm-Message-State: ALoCoQlvrs4001Ov9pUXv3XdiJ1iWCtLoHeJVhrwnRrLi6z5a6uBykwBB2QSx3N+161s0edyPMrq MIME-Version: 1.0 X-Received: by 10.194.157.228 with SMTP id wp4mr5924080wjb.79.1432220377048; Thu, 21 May 2015 07:59:37 -0700 (PDT) Received: by 10.194.36.193 with HTTP; Thu, 21 May 2015 07:59:36 -0700 (PDT) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891263236AF3D@IRSMSX108.ger.corp.intel.com> References: <1430396143-10936-1-git-send-email-michalx.k.jastrzebski@intel.com> <2017641.P0ts6fjbPO@xps13> <3EB4FA525960D640B5BDFFD6A3D891263236A93E@IRSMSX108.ger.corp.intel.com> <1677593.4Cv3TcNdFE@xps13> <3EB4FA525960D640B5BDFFD6A3D891263236AF3D@IRSMSX108.ger.corp.intel.com> Date: Thu, 21 May 2015 09:59:36 -0500 Message-ID: From: Jay Rolette To: "Dumitrescu, Cristian" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] pipeline: add statistics for librte_pipeline ports and tables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 May 2015 14:59:37 -0000 On Thu, May 21, 2015 at 8:33 AM, Dumitrescu, Cristian < cristian.dumitrescu@intel.com> wrote: > > > The problem I see with this approach is that you cannot turn off debug > > > messages while still having the statistics collected. We should allow > > > people to collects the stats without getting the debug messages. How do > > > we do this? > > > > By setting build-time log level to debug, you would enable stats and > debug > > messages. Then you can adjust the log messages level with the run-time > > option --log-level. > > This is a really clever trick! I have to say it took me some time to make > sure I got it right :) > So when RTE_LOG_LEVEL (build time option) is set to DEBUG (i.e. 8), then > we get both the stats and the debug messages, but then we can adjust the > level of debug messages at run-time through the --log-level EAL option. > I can work with this option, thank you! > > There is one more simple proposal that came to my mind late last night: > how about single config file option RTE_COLLECT_STATS=y/n that should be > used by all the libs across the board to indicate whether stats should be > enabled or not? > This is logically very similar to the solution above, as they both look at > a single option in the config file, but maybe it is also more intuitive for > people. > > I will go with your choice. Which one do you pick? > As Stephen said previously, any real DPDK app needs stats. You can't support network products operationally without them. What's the point of making them optional other than trying to juice benchmarks? Jay