From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rolette@infiniteio.com>
Received: from mail-vk0-f41.google.com (mail-vk0-f41.google.com
 [209.85.213.41]) by dpdk.org (Postfix) with ESMTP id B8E8FC45A
 for <dev@dpdk.org>; Thu, 28 Jan 2016 14:24:51 +0100 (CET)
Received: by mail-vk0-f41.google.com with SMTP id e185so23377591vkb.1
 for <dev@dpdk.org>; Thu, 28 Jan 2016 05:24:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=infiniteio-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :content-type; bh=VDw6G9Fzd4ZudJJGb6rbp5EYPAu3ZBp2TeD/Csok4jY=;
 b=ZC6B1OlWL/JrWmXtPglSGOnaEHy8R28IybUjTM/0YWCavnIlcRv8QXQTFgwblbzeMk
 MkdcXX1Hit0/saf5DWCUNAtB78HpDDPq0u87LbeVI9uFdOtU++ATATxEbJZULyJ90Fdh
 dv2i1jdBu5+JTsKtRsrc9au3yKXklQuPCcYjxhRNVOL18HoQaOdo6w3s0ji+nQ59lUUU
 4Lad6+QUQFOsyNn8FnJFQ1merobuRstbbN67dJUJsNjvXOobJbyaNOBNjVxPMB8iG2Wn
 2XjOovEOOI96MCMRkPF8VBcSaS3Fb9Df/zpoJ1SBhhUIM4d+VykyDEjEZFC7zNFy+/W9
 ibKw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:content-type;
 bh=VDw6G9Fzd4ZudJJGb6rbp5EYPAu3ZBp2TeD/Csok4jY=;
 b=FL2cfux2O7bAFunX6mfEsXqWcqVnwQRxIFcm5fkDvNdHKmEm7LJy71X9B5TYuUtmsH
 //USPpsSVltvVCLfUO8Mvj0TIeGPzxzWGH14RDFRKsCIlMN72jmOO3qRRjD/tbjuNwmV
 rphtIWAn54QhBImGFHep2e0lc5VXMJvbMcw1qr1rqY/hTovOTrXr/Q6Fi5V8gO5N8pgR
 gLY+Amar9NpB2TGcuvmfyny9hkUmVf4C4pCB1ePzCi54Z4ymc4QgT+NE49m1cK2JPFsl
 1z4aphb0oNyorzy1QQp3mzGUGL8i/f08db5La9Jt5v2SGOhzSvZAYTMFMaf/eqj3I87Q
 c9HQ==
X-Gm-Message-State: AG10YOSt4Gi1dLLqEVLSmcSmdCP9Ej+TiC+KY8j8MTQYzaANu1yaOrDUe5DcBlw1k5qNpxj5i/8MYLRgnK2I/w==
MIME-Version: 1.0
X-Received: by 10.31.166.208 with SMTP id p199mr2097963vke.122.1453987491317; 
 Thu, 28 Jan 2016 05:24:51 -0800 (PST)
Received: by 10.103.96.3 with HTTP; Thu, 28 Jan 2016 05:24:51 -0800 (PST)
In-Reply-To: <20160128131500.GA16492@sivlogin002.ir.intel.com>
References: <1453911849-16562-1-git-send-email-ferruh.yigit@intel.com>
 <1453911849-16562-3-git-send-email-ferruh.yigit@intel.com>
 <56A9F827.1060403@intel.com>
 <20160128131500.GA16492@sivlogin002.ir.intel.com>
Date: Thu, 28 Jan 2016 07:24:51 -0600
Message-ID: <CADNuJVqLWLpkdLpKfogttQOpJJJP2P_iX9iF59RYcCATuGSLWg@mail.gmail.com>
From: Jay Rolette <rolette@infiniteio.com>
To: Remy Horton <remy.horton@intel.com>, DPDK <dev@dpdk.org>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH 2/3] rte_ctrl_if: add control interface
	library
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jan 2016 13:24:52 -0000

On Thu, Jan 28, 2016 at 7:15 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:

> On Thu, Jan 28, 2016 at 11:14:47AM +0000, Remy Horton wrote:
> > On 27/01/2016 16:24, Ferruh Yigit wrote:
> >
> > > +   default:
> > > +           ret = -95 /* EOPNOTSUPP */;
> > > +           break;
> >
> > Is this intentional? -EOPNOTSUPP is -122 (-95 is -ENOTSOCK)..
> >
> Return value is not significant, callee just checks for negative value,
> I can remove comment to prevent confusion.
>

No, please fix the return value. Return values are significant when you are
trying to debug or understand the intent of the code.

Jay