From: Jay Rolette <rolette@infiniteio.com>
To: David Marchand <david.marchand@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 12/17] e1000: use the right debug macro
Date: Tue, 2 Sep 2014 13:29:30 -0500 [thread overview]
Message-ID: <CADNuJVqR1J08Vj8BiiiJqQC7yVY_bxBSynbyYx7XkF+FaHQgWg@mail.gmail.com> (raw)
In-Reply-To: <1409567080-27083-13-git-send-email-david.marchand@6wind.com>
On Mon, Sep 1, 2014 at 5:24 AM, David Marchand <david.marchand@6wind.com>
wrote:
> - We should not use DEBUGOUT* / DEBUGFUNC macros in non-shared code.
> These macros come as compat wrappers for shared code.
> - We should avoid calling RTE_LOG directly as pmd provides a wrapper for
> logs.
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
> lib/librte_pmd_e1000/em_rxtx.c | 32 ++++++++++++++++++--------------
> lib/librte_pmd_e1000/igb_ethdev.c | 9 +++++----
> lib/librte_pmd_e1000/igb_pf.c | 5 +++--
> lib/librte_pmd_e1000/igb_rxtx.c | 16 +++++++---------
> 4 files changed, 33 insertions(+), 29 deletions(-)
>
> diff --git a/lib/librte_pmd_e1000/em_rxtx.c
> b/lib/librte_pmd_e1000/em_rxtx.c
> index f254858..01efa50 100644
> --- a/lib/librte_pmd_e1000/em_rxtx.c
> +++ b/lib/librte_pmd_e1000/em_rxtx.c
> @@ -1211,18 +1211,21 @@ eth_em_tx_queue_setup(struct rte_eth_dev *dev,
> DEFAULT_TX_RS_THRESH);
>
> if (tx_free_thresh >= (nb_desc - 3)) {
> - RTE_LOG(ERR, PMD, "tx_free_thresh must be less than the "
> - "number of TX descriptors minus 3.
> (tx_free_thresh=%u "
> - "port=%d queue=%d)\n", (unsigned
> int)tx_free_thresh,
> - (int)dev->data->port_id, (int)queue_idx);
> + PMD_INIT_LOG(ERR, "tx_free_thresh must be less than the "
> + "number of TX descriptors minus 3. "
> + "(tx_free_thresh=%u port=%d queue=%d)\n",
> + (unsigned int)tx_free_thresh,
> + (int)dev->data->port_id, (int)queue_idx);
> return -(EINVAL);
> }
> if (tx_rs_thresh > tx_free_thresh) {
> - RTE_LOG(ERR, PMD, "tx_rs_thresh must be less than or equal
> to "
> - "tx_free_thresh. (tx_free_thresh=%u
> tx_rs_thresh=%u "
> - "port=%d queue=%d)\n", (unsigned
> int)tx_free_thresh,
> - (unsigned int)tx_rs_thresh,
> (int)dev->data->port_id,
> - (int)queue_idx);
> + PMD_INIT_LOG(ERR, "tx_rs_thresh must be less than or equal
> to "
> + "tx_free_thresh. (tx_free_thresh=%u "
> + "tx_rs_thresh=%u port=%d queue=%d)\n",
> + (unsigned int)tx_free_thresh,
> + (unsigned int)tx_rs_thresh,
> + (int)dev->data->port_id,
> + (int)queue_idx);
> return -(EINVAL);
> }
>
> @@ -1233,10 +1236,10 @@ eth_em_tx_queue_setup(struct rte_eth_dev *dev,
> * accumulates WTHRESH descriptors.
> */
> if (tx_conf->tx_thresh.wthresh != 0 && tx_rs_thresh != 1) {
> - RTE_LOG(ERR, PMD, "TX WTHRESH must be set to 0 if "
> - "tx_rs_thresh is greater than 1. (tx_rs_thresh=%u "
> - "port=%d queue=%d)\n", (unsigned int)tx_rs_thresh,
> - (int)dev->data->port_id, (int)queue_idx);
> + PMD_INIT_LOG(ERR, "TX WTHRESH must be set to 0 if "
> + "tx_rs_thresh is greater than 1.
> (tx_rs_thresh=%u "
> + "port=%d queue=%d)\n", (unsigned
> int)tx_rs_thresh,
> + (int)dev->data->port_id, (int)queue_idx);
> return -(EINVAL);
> }
>
> @@ -1366,7 +1369,8 @@ eth_em_rx_queue_setup(struct rte_eth_dev *dev,
> * EM devices don't support drop_en functionality
> */
> if (rx_conf->rx_drop_en) {
> - RTE_LOG(ERR, PMD, "drop_en functionality not supported by
> device\n");
> + PMD_INIT_LOG(ERR, "drop_en functionality not supported by "
> + "device\n");
> return (-EINVAL);
> }
>
> diff --git a/lib/librte_pmd_e1000/igb_ethdev.c
> b/lib/librte_pmd_e1000/igb_ethdev.c
> index 3187d92..b45eb24 100644
> --- a/lib/librte_pmd_e1000/igb_ethdev.c
> +++ b/lib/librte_pmd_e1000/igb_ethdev.c
> @@ -400,7 +400,7 @@ igb_reset_swfw_lock(struct e1000_hw *hw)
> * So force the release of the faulty lock.
> */
> if (e1000_get_hw_semaphore_generic(hw) < 0) {
> - DEBUGOUT("SMBI lock released");
> + PMD_DRV_LOG(DEBUG, "SMBI lock released");
> }
> e1000_put_hw_semaphore_generic(hw);
>
> @@ -416,7 +416,8 @@ igb_reset_swfw_lock(struct e1000_hw *hw)
> if (hw->bus.func > E1000_FUNC_1)
> mask <<= 2;
> if (hw->mac.ops.acquire_swfw_sync(hw, mask) < 0) {
> - DEBUGOUT1("SWFW phy%d lock released",
> hw->bus.func);
> + PMD_DRV_LOG(DEBUG, "SWFW phy%d lock released",
> + hw->bus.func);
> }
> hw->mac.ops.release_swfw_sync(hw, mask);
>
> @@ -428,7 +429,7 @@ igb_reset_swfw_lock(struct e1000_hw *hw)
> */
> mask = E1000_SWFW_EEP_SM;
> if (hw->mac.ops.acquire_swfw_sync(hw, mask) < 0) {
> - DEBUGOUT("SWFW common locks released");
> + PMD_DRV_LOG(DEBUG, "SWFW common locks released");
> }
> hw->mac.ops.release_swfw_sync(hw, mask);
> }
> @@ -707,7 +708,7 @@ igb_vmdq_vlan_hw_filter_enable(struct rte_eth_dev *dev)
> static int
> rte_igbvf_pmd_init(const char *name __rte_unused, const char *params
> __rte_unused)
> {
> - DEBUGFUNC("rte_igbvf_pmd_init");
> + PMD_INIT_FUNC_TRACE();
>
> rte_eth_driver_register(&rte_igbvf_pmd);
> return (0);
> diff --git a/lib/librte_pmd_e1000/igb_pf.c b/lib/librte_pmd_e1000/igb_pf.c
> index 3d405f0..76033ad 100644
> --- a/lib/librte_pmd_e1000/igb_pf.c
> +++ b/lib/librte_pmd_e1000/igb_pf.c
> @@ -404,7 +404,7 @@ igb_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t
> vf)
>
> retval = e1000_read_mbx(hw, msgbuf, mbx_size, vf);
> if (retval) {
> - RTE_LOG(ERR, PMD, "Error mbx recv msg from VF %d\n", vf);
> + PMD_INIT_LOG(ERR, "Error mbx recv msg from VF %d\n", vf);
> return retval;
> }
>
> @@ -432,7 +432,8 @@ igb_rcv_msg_from_vf(struct rte_eth_dev *dev, uint16_t
> vf)
> retval = igb_vf_set_vlan(dev, vf, msgbuf);
> break;
> default:
> - RTE_LOG(DEBUG, PMD, "Unhandled Msg %8.8x\n", (unsigned)
> msgbuf[0]);
> + PMD_INIT_LOG(DEBUG, "Unhandled Msg %8.8x\n",
> + (unsigned) msgbuf[0]);
> retval = E1000_ERR_MBX;
> break;
> }
> diff --git a/lib/librte_pmd_e1000/igb_rxtx.c
> b/lib/librte_pmd_e1000/igb_rxtx.c
> index 977c4a2..3aa9609 100644
> --- a/lib/librte_pmd_e1000/igb_rxtx.c
> +++ b/lib/librte_pmd_e1000/igb_rxtx.c
> @@ -1210,17 +1210,15 @@ eth_igb_tx_queue_setup(struct rte_eth_dev *dev,
> * driver.
> */
> if (tx_conf->tx_free_thresh != 0)
> - RTE_LOG(WARNING, PMD,
> - "The tx_free_thresh parameter is not "
> - "used for the 1G driver.\n");
> + PMD_INIT_LOG(WARNING, "The tx_free_thresh parameter is not
> "
> + "used for the 1G driver.\n");
> if (tx_conf->tx_rs_thresh != 0)
> - RTE_LOG(WARNING, PMD,
> - "The tx_rs_thresh parameter is not "
> - "used for the 1G driver.\n");
> + PMD_INIT_LOG(WARNING, "The tx_rs_thresh parameter is not "
> + "used for the 1G driver.\n");
> if (tx_conf->tx_thresh.wthresh == 0)
> - RTE_LOG(WARNING, PMD,
> - "To improve 1G driver performance, consider
> setting "
> - "the TX WTHRESH value to 4, 8, or 16.\n");
> + PMD_INIT_LOG(WARNING, "To improve 1G driver performance, "
> + "consider setting the TX WTHRESH value to 4,
> 8, "
> + "or 16.\n");
>
> /* Free memory prior to re-allocation if needed */
> if (dev->data->tx_queues[queue_idx] != NULL) {
> --
> 1.7.10.4
>
> Reviewed-by: Jay Rolette <rolette@infiniteio.com>
next prev parent reply other threads:[~2014-09-02 18:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 10:24 [dpdk-dev] [PATCH v2 00/17] cleanup logs in main PMDs David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 01/17] ixgbe: use the right debug macro David Marchand
2014-09-02 13:43 ` Jay Rolette
2014-09-02 14:16 ` David Marchand
2014-09-02 14:21 ` Thomas Monjalon
2014-09-02 17:57 ` Jay Rolette
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 02/17] ixgbe/base: add a _RAW macro for use by shared code David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 03/17] ixgbe: clean log messages David Marchand
2014-09-02 15:19 ` Jay Rolette
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 04/17] ixgbe: always log init messages David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 05/17] ixgbe: add a message when forcing scatter mode David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 06/17] ixgbe: add log messages when rx bulk mode is not usable David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 07/17] i40e: use the right debug macro David Marchand
2014-09-02 18:25 ` Jay Rolette
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 08/17] i40e/base: add a _RAW macro for use by shared code David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 09/17] i40e: clean log messages David Marchand
2014-09-02 18:20 ` Jay Rolette
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 10/17] i40e: always log init messages David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 11/17] i40e: add log messages when rx bulk mode is not usable David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 12/17] e1000: use the right debug macro David Marchand
2014-09-02 18:29 ` Jay Rolette [this message]
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 13/17] e1000/base: add a _RAW macro for use by shared code David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 14/17] e1000: clean log messages David Marchand
2014-09-02 19:05 ` Jay Rolette
2014-09-02 19:19 ` David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 15/17] e1000: always log init messages David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 16/17] e1000: add a message when forcing scatter mode David Marchand
2014-09-02 19:20 ` David Marchand
2014-09-01 10:24 ` [dpdk-dev] [PATCH v2 17/17] eal: set log level from command line David Marchand
2014-09-12 12:32 ` [dpdk-dev] [PATCH v2 00/17] cleanup logs in main PMDs Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADNuJVqR1J08Vj8BiiiJqQC7yVY_bxBSynbyYx7XkF+FaHQgWg@mail.gmail.com \
--to=rolette@infiniteio.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).