From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f51.google.com (mail-vk0-f51.google.com [209.85.213.51]) by dpdk.org (Postfix) with ESMTP id 6B2958E66 for ; Fri, 2 Oct 2015 15:25:28 +0200 (CEST) Received: by vkao3 with SMTP id o3so59558403vka.2 for ; Fri, 02 Oct 2015 06:25:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Q6IJEitWKmD6zYIz9v/c7PMn9tz/9hFel/OwtW2To+o=; b=KOwVgKkjZIGN/lMKkIVeU1CmRAxb+XjTsONf2ThcrW8S0xAIsEY2su1lbZTfY7Gvvm z3x85/7796lJC9sToH7z8wyA+5FGWmc8r2KRXzhophRMinaVLvFjIPt5wdAabfmvpsbw HePAu6XZoM0owgl8wZSip0CFtMOD6qb0/OSrrZHV1kpuDY1lhRMI9YIz+BBUoZqFmX3B y5EuHsHLH/AzRi/K/e8hKwKkwhF3TeZ0d+GA8sbYJS9+SWPOvQgOKZowXZdrE5Sa4Hya 32ewkE5FcBef85pXGduvuqPojd0wMPS2fewrcUj95tW908+KEVq2SR2eif6j2rqAF3Ak jQ5Q== X-Gm-Message-State: ALoCoQmqXSrN5Q137nQPoYwGL41g9CRz3NyULDmjZO6cEcc+27NN3huYq8N4Zq8TAc4vFGlWN24c MIME-Version: 1.0 X-Received: by 10.31.50.16 with SMTP id y16mr10264636vky.75.1443792327829; Fri, 02 Oct 2015 06:25:27 -0700 (PDT) Received: by 10.103.69.17 with HTTP; Fri, 2 Oct 2015 06:25:27 -0700 (PDT) In-Reply-To: <1443790078-15834-1-git-send-email-maryam.tahhan@intel.com> References: <1443790078-15834-1-git-send-email-maryam.tahhan@intel.com> Date: Fri, 2 Oct 2015 08:25:27 -0500 Message-ID: From: Jay Rolette To: Maryam Tahhan Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: DPDK Subject: Re: [dpdk-dev] [PATCH] ethdev: distinguish between drop and error stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2015 13:25:28 -0000 Can you improve the comments on these counters? If you didn't happen to follow this thread, there's no way to reasonably figure out what the difference is from looking at the code without chasing it all the way down and cross-referencing the NIC datasheet. Thanks, Jay On Fri, Oct 2, 2015 at 7:47 AM, Maryam Tahhan wrote: > Make a distniction between dropped packets and error statistics to allow > a higher level fault management entity to interact with DPDK and take > appropriate measures when errors are detected. It will also provide > valuable information for any applications that collects/extracts DPDK > stats, such applications include Open vSwitch. > After this patch the distinction is: > ierrors = Total number of packets dropped by hardware (malformed > packets, ...) Where the # of drops can ONLY be <= the packets received > (without overlap between registers). > Rx_pkt_errors = Total number of erroneous received packets. Where the # > of errors can be >= the packets received (without overlap between > registers), this is because there may be multiple errors associated with > a packet. > > Signed-off-by: Maryam Tahhan > --- > lib/librte_ether/rte_ethdev.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h > index 8a8c82b..53dd55d 100644 > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -200,8 +200,9 @@ struct rte_eth_stats { > /**< Deprecated; Total of RX packets with CRC error. */ > uint64_t ibadlen; > /**< Deprecated; Total of RX packets with bad length. */ > - uint64_t ierrors; /**< Total number of erroneous received > packets. */ > + uint64_t ierrors; /**< Total number of dropped received packets. > */ > uint64_t oerrors; /**< Total number of failed transmitted > packets. */ > + uint64_t ipkterrors; /**< Total number of erroneous received > packets. */ > uint64_t imcasts; > /**< Deprecated; Total number of multicast received packets. */ > uint64_t rx_nombuf; /**< Total number of RX mbuf allocation > failures. */ > -- > 2.4.3 > >