From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f177.google.com (mail-ua0-f177.google.com [209.85.217.177]) by dpdk.org (Postfix) with ESMTP id 53A8E11DE for ; Tue, 17 Jan 2017 19:44:49 +0100 (CET) Received: by mail-ua0-f177.google.com with SMTP id 35so109532493uak.1 for ; Tue, 17 Jan 2017 10:44:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=infinite-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KtwLFYLs4XouS+juefijI/zGSqZkI3f+Key9QDwwds8=; b=VVi+59PZ27CvTJPZJeHD5lFh3QLfnV5IE+jqQPYMiy0NoJqLJHMewM4OgQRufJnKYm tBYzKRaD7Y3JplmzVjKwCYKoQ/GKqc65P7UEeI+9Lm2oWsyHJFZZml9I62nreRJD1HfX V/7lBy5jA95khqxqoYy+OnOJB1/oIQ7IAqkvvDQk+EEbBZwC3TLXUGAJiZMtRvq1uSIk E4ipVzSJmZL79wXnJUC7GTKodbeAZ90jIMXKUB2C9jISYte2goqUtqnUU62yf6mV83Em 3v9GUBzXEsvFieKhAUIZOsyXUJLX1CdyGTEfGbYGo87W8uH0Rc8j77O5kJxiMF6G2HnW WQAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KtwLFYLs4XouS+juefijI/zGSqZkI3f+Key9QDwwds8=; b=ud4NmZjA0yCDrttDhH3QRWefvn9ptibqn4F8qrimE7la0JSSKUnPiGVStLUovg1dyy 62RTMk9DNRHwR9Rr9mHsbDbCl2bYgePi/EqGWewdFpLgMabbsdEHjQzekjfgaYOOi0n4 e0lMUxKCf9KZcxX7V2Ik8TizKKWYDZR41BzlWHc4yfaxOrOf+iLvBP3807y/M8rotGsi qjls7ffrhXNNmfKJGNJPFsh+deDNOerwtFrVHvL0JSM3x+b2Xwogbp5PDV8OV3c1yu2k 3nxBInc6FpARuuNFzcF9eupog9NUPxCft677exYCHFkLLvBHCJkuRI0H47XAQVCLgSk3 +RTA== X-Gm-Message-State: AIkVDXKgGkThfwpC0VcSQ3abhtbsPp8C4ys8k6e2XuFWfajU2iImJ8RKS4nuRwSlbe1ueasjH8pwxQ9reW6/ig== X-Received: by 10.176.83.218 with SMTP id l26mr17322085uaa.69.1484678688852; Tue, 17 Jan 2017 10:44:48 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.104.76 with HTTP; Tue, 17 Jan 2017 10:44:48 -0800 (PST) In-Reply-To: <20170117180147.11247-2-ferruh.yigit@intel.com> References: <20170117180147.11247-1-ferruh.yigit@intel.com> <20170117180147.11247-2-ferruh.yigit@intel.com> From: Jay Rolette Date: Tue, 17 Jan 2017 12:44:48 -0600 Message-ID: To: Ferruh Yigit Cc: DPDK Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/2] config: disable KNI ethtool by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 18:44:49 -0000 On Tue, Jan 17, 2017 at 12:01 PM, Ferruh Yigit wrote: > KNI ethtool support (KNI control path) is not commonly used, > and it tends to break the build with new version of the Linux kernel. > > KNI ethtool feature is disabled by default. KNI datapath is not effected > from this update. > > It is possible to enable feature explicitly with config option: > "CONFIG_RTE_KNI_KMOD_ETHTOOL=y" > > Signed-off-by: Ferruh Yigit > Is there a test case somewhere to detect when it gets broken or is the intent to let it bit-rot unless someone enables that option and subsequently discovers it broken? I know we don't do this for every config option, but given the fact that this tends to get broken frequently, it seems riskier. Jay > --- > config/common_linuxapp | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/config/common_linuxapp b/config/common_linuxapp > index d4c4f0c..2483dfa 100644 > --- a/config/common_linuxapp > +++ b/config/common_linuxapp > @@ -38,7 +38,6 @@ CONFIG_RTE_EXEC_ENV_LINUXAPP=y > CONFIG_RTE_EAL_IGB_UIO=y > CONFIG_RTE_EAL_VFIO=y > CONFIG_RTE_KNI_KMOD=y > -CONFIG_RTE_KNI_KMOD_ETHTOOL=y > CONFIG_RTE_LIBRTE_KNI=y > CONFIG_RTE_LIBRTE_VHOST=y > CONFIG_RTE_LIBRTE_PMD_VHOST=y > -- > 2.9.3 > >