From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B693A0C43; Thu, 30 Sep 2021 19:42:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B783410EA; Thu, 30 Sep 2021 19:42:06 +0200 (CEST) Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by mails.dpdk.org (Postfix) with ESMTP id 68FFC40DDA for <dev@dpdk.org>; Thu, 30 Sep 2021 18:28:19 +0200 (CEST) Received: by mail-yb1-f181.google.com with SMTP id i84so14509896ybc.12 for <dev@dpdk.org>; Thu, 30 Sep 2021 09:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oneconvergence.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=v/Hf+1Zj5cvvc76Wa21K72UIeE2e1SoU2T8NHbRkK2o=; b=RL9PWF6R/LhzagQZ59Nkfa+Tb1RrWYs2rKsQBg0vKdrhqSiauPHe5bslpMh8NDOouz vfZzpPyWavvnvqCOCFBIwlrphRPHmZZvqdkb/ocwW/+db2cNw8ZdK7+UPHQC3ymthMPV N8dUE99UMoaJlYBYJKtqIbFpH6oOBGh7q+OhY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v/Hf+1Zj5cvvc76Wa21K72UIeE2e1SoU2T8NHbRkK2o=; b=MNPGpG/XDRI66AvT4DlHjhS0SXGNaUKGr6pUMJ7pCdsGC/LDLr+ayGEGL7iZJ1VZtO lVhRKCYvKxhDUWiIXFwG99dRwQ3BMgJCA8mIJCuDDk+ZpgQIHByFq5e4rmDcA7yA+SY0 yUolHwXFWbcnF9ci00sFI1KQtrlBGDCYqWM7k1CWcRU6zcitux4HDoQL9qWQa1FqB6kK qGBp0uRtEYclBIP/3tvZb/Tf7kKZ3o3NGMvDWkdB7QoE7EYfQZo4qetxALI+rlskUX5W q2mzn0WjjWT2DJjitkS2Jpl/X9vItoIHNhizlNvIzvRg+wvd+nuV9wMPdHHjzRyWP5Bi Ee7w== X-Gm-Message-State: AOAM532/ezqRXW4cqIfw/UDykTkI8nc+06FCyGa2lqPm6sclbzlljEJ2 T5KnPW/XJ/Izh9gMamjgLbimiS6cJK7M3Au5X+8XxQ== X-Google-Smtp-Source: ABdhPJxnwRX5JLw7Ezgdc0kprXGljyQRVmCBV2TohcHXOCEFc6fPnF3Ou7qlP5F8+opmvXxQAnLZ8i1i53tFwB0eY3M= X-Received: by 2002:a25:4fc3:: with SMTP id d186mr126788ybb.119.1633019298550; Thu, 30 Sep 2021 09:28:18 -0700 (PDT) MIME-Version: 1.0 References: <20210927133450.10653-1-srikanth.k@oneconvergence.com> <2862022.4b9u9FZ0aI@thomas> <CADccbPQoEmEwazZfN0cjJ_-HjUqpS2t5htvvUUAmNO-D4iYTKg@mail.gmail.com> <3498914.nWIOhJD1b8@thomas> In-Reply-To: <3498914.nWIOhJD1b8@thomas> From: Srikanth K <srikanth.k@oneconvergence.com> Date: Thu, 30 Sep 2021 21:57:42 +0530 Message-ID: <CADccbPQ0sEvBScaQEmqfwx79qS0ku2g6gsNF6Zm_FrnCeeLR+Q@mail.gmail.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, dev@dpdk.org, Vag Singh <vag.singh@oneconvergence.com>, Anand Thulasiram <avelu@juniper.net>, asafp@nvidia.com, shys@nvidia.com X-Mailman-Approved-At: Thu, 30 Sep 2021 19:42:05 +0200 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH 00/19] MLX5 FreeBSD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Sure, I will follow the Windows support approach. Regarding the patches organization, they were arranged logically to the best of my knowledge. The approach followed is to take Linux PMD code and replace the Linux dependent part with the FreeBSD compatible code. All the removals are of this Linux dependent code. For the same reason, FreeBSD meson support is added in the last patch or otherwise Linux code would break compilation in FreeBSD. The patches status is still "New" on the DPDK site, please let me know when I can submit the next version. Regards, Srikanth On Wed, Sep 29, 2021 at 9:50 PM Thomas Monjalon <thomas@monjalon.net> wrote: > 29/09/2021 17:56, Srikanth K: > > Hi Thomas, > > > > PFA the test report. It covers all the features that were tested across > > various platforms. > > > > The features mentioned in the test report depend on a modified FreeBSD > > OFED. There is an ongoing review of these changes by the FreeBSD > community. > > https://reviews.freebsd.org/p/vag.singh_oneconvergence.com/ > > OK, this dependency is very important to notify in this patchset. > For next version, please add it in the cover letter. > > The supported features (MTU, MAC, VLAN, RSS, fragments, jumbo, stats > and trust mode) should be listed in the cover letter as well as > in the mlx5 documentation. Please follow what was done for Windows. > > About the patches organization, please do not fix or remove something > which was added in a previous patch. You need to have logical steps > done in each patch without going backward. > Please start with enabling compilation in first patch, > so each step can be tested. > > Thanks > > >