From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f173.google.com (mail-lb0-f173.google.com [209.85.217.173]) by dpdk.org (Postfix) with ESMTP id 6DC5A8E80 for ; Tue, 13 Oct 2015 11:10:44 +0200 (CEST) Received: by lbbk10 with SMTP id k10so12167975lbb.0 for ; Tue, 13 Oct 2015 02:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=TAZd+3+duN8P5mmRUfZEVlcvlR+VwAFmsbAElMmoTAM=; b=QZfwAbpQdumZbLmJJl8g79A1MxSvQbc0J4GhNqmLt7tcHVieluNOTs62npEmaEpybG mQLsjo7h+AwvyxbC5fI1ffelTR1J9m23B56D+67noG6wr9/XGMHZsUcLsScZtyZEJCzj t0sREpAIibjEJ2f/pOqK/eLVoRCPxlfRE0lIb+faURRCJpeP9fj2fZOcaKSuJFMZR9gV ccTfOmKI7R7NcDzKuBQDRC6ewRHOZjuo3RlieanpXrS+bv4myaZA7STdZ3lo9UAGftc3 ImFmLSKfu1MGrwbAuffmrb3Li8GmtDcpobJop9o8MkAp/6pj1CMnuvpj/xo/SWEbo8y4 K1OQ== X-Received: by 10.25.24.162 with SMTP id 34mr928093lfy.84.1444727443982; Tue, 13 Oct 2015 02:10:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.114.173.179 with HTTP; Tue, 13 Oct 2015 02:10:04 -0700 (PDT) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126478DE034@IRSMSX108.ger.corp.intel.com> References: <1443509581-27823-1-git-send-email-christoph.gysin@gmail.com> <3EB4FA525960D640B5BDFFD6A3D89126478DE034@IRSMSX108.ger.corp.intel.com> From: Christoph Gysin Date: Tue, 13 Oct 2015 12:10:04 +0300 Message-ID: To: David Marchand Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2015 09:10:44 -0000 Hi David Is there anything I can do to help getting this merged? Thanks, Chris On Mon, Oct 5, 2015 at 12:44 PM, Dumitrescu, Cristian wrote: > > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Christoph Gysin >> Sent: Tuesday, September 29, 2015 7:53 AM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [PATCH] eal: fix C++ build (struct member: virtual) >> >> 'virtual' is a keyword and can't be used if the code is to compile with >> C++ compilers. >> >> If rte_devargs.h was included in C++ code, compilation with clang++ >> failed with an error. g++ did not fail, but only because of a bug >> that treats it as an anonymous struct with a decl-specifier which it >> ignores. >> >> This simply renames the member to 'virt'. >> >> Signed-off-by: Christoph Gysin >> --- > > Acked-by: Cristian Dumitrescu > > Christoph, please also copy David Marchand for further updates of this patch, as David is the maintainer of this component. Whenever in doubt about the maintainer, you can check file MAINTAINERS from DPDK root folder. > > Regards, > Cristian > -- echo mailto: NOSPAM !#$.'<*>'|sed 's. ..'|tr "<*> !#:2" org@fr33z3