DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ariel Rodriguez <arodriguez@callistech.com>
To: Ming Zhao <mzhao@luminatewireless.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] "virtual" C++ keyword used in rte_devargs.h and causes compilation error in C++
Date: Sun, 8 Feb 2015 04:31:39 -0300	[thread overview]
Message-ID: <CADoa0baQnWJTUhJRWh13UJCcqZ_JEpd5mwzVdfPeeehJ+fLYdg@mail.gmail.com> (raw)
In-Reply-To: <54D70343.6060502@luminatewireless.com>

"virtual" is a reserved word in c++. When the c++ compiler "g++" use that
header in a "extern way (just generate standard typo for function
identifiers)", there`s not way that the compiler posible "turn off" the
"virtual" reserved  word. If, for example, you guys use the "new" word ...
its just the same as virtual.

Regards.

On Sun, Feb 8, 2015 at 3:33 AM, Ming Zhao <mzhao@luminatewireless.com>
wrote:

> In fact the current rte_devargs.h header is enclosed inside  extern C {}
> block already. But it looks like it's not sufficient. Also there is also
> the case that rte_devargs.virtual field could be accessed inside a cpp
> file.
>
> On 02/07/2015 12:23 PM, Neil Horman wrote:
> > On Fri, Feb 06, 2015 at 11:24:15PM -0800, Ming Zhao wrote:
> >> The code is in rte_devargs.h:
> >>
> >> rte_devargs.h:
> >>
> >>                 /** Used if type is RTE_DEVTYPE_VIRTUAL. */
> >>                 struct {
> >>                         /** Driver name. */
> >>                         char drv_name[32];
> >>                 } virtual;
> >>         };
> >>
> >> Which caused clang compiler to report error when this file is included
> >> by a cpp file, the error message is:
> >>
> >> In file included from net/dpdk/testing/base-test.cc:3:
> >> In file included from net/dpdk/testing/base-test.h:8:
> >> third-party/dpdk/lib/librte_eal/common/include/rte_devargs.h:89:5:
> >> error: 'virtual' can only appear on non-static
> >>       member functions
> >>                 } virtual;
> >>                   ^
> >>
> >> I think we should try to pick another name for this field. I would
> >> suggest calling it "vdev" instead, or I'll be happy to take another name
> >> if someone comes with a different idea.
> >>
> >> Thanks!
> >> Ming
> >>
> > You could do that, but it seems like it shouldn't be necessecary.
> Shouldn't the
> > solution just be to encapsulate either the header file or the #include
> directive
> > from the C++ file with extern C { }?
> > Neil
> >
>

  reply	other threads:[~2015-02-08  7:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-07  7:24 Ming Zhao
2015-02-07 20:23 ` Neil Horman
2015-02-08  6:33   ` Ming Zhao
2015-02-08  7:31     ` Ariel Rodriguez [this message]
2015-02-08 13:53       ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADoa0baQnWJTUhJRWh13UJCcqZ_JEpd5mwzVdfPeeehJ+fLYdg@mail.gmail.com \
    --to=arodriguez@callistech.com \
    --cc=dev@dpdk.org \
    --cc=mzhao@luminatewireless.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).