DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ariel Rodriguez <arodriguez@callistech.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] SEGMENTATION FAULT in kni example : kni_free_kni() call
Date: Tue, 28 Oct 2014 23:07:35 -0300	[thread overview]
Message-ID: <CADoa0bbog5n7gsPU7013Jp8d584dCh_pT+w+pxCVtWMjnLkOGA@mail.gmail.com> (raw)

Hi, im trying the kni example. When i hit ctrl-c in the terminal  stopping
the example, the os signals  with a segmentation fault.

The issue is in this block of code:

static int kni_free_kni(uint8_t port_id) {
uint8_t i;
struct kni_port_params **p = kni_port_params_array;

if (port_id >= RTE_MAX_ETHPORTS || !p[port_id])
return -1;

-- for (i = 0; i < p[i]->nb_kni; i++) {
-- rte_kni_release(p[i]->kni[i]);
-- p[i]->kni[i] = NULL;
}
rte_eth_dev_stop(port_id);

return 0;
}


The following change fix that issue:

static int kni_free_kni(uint8_t port_id) {
uint8_t i;
struct kni_port_params **p = kni_port_params_array;

if (port_id >= RTE_MAX_ETHPORTS || !p[port_id])
return -1;

++ for (i = 0; i < p[port_id]->nb_kni; i++) {
++ rte_kni_release(p[port_id]->kni[i]);
++ p[port_id]->kni[i] = NULL;
}
rte_eth_dev_stop(port_id);

return 0;
}

Sorry for the basic of my fix ... i dont know  the correct style to report
this kind of issues... im just a user of the dpdk library ... but i meet
this bug ...


Regards.

Ariel Horacio Rodriguez.

             reply	other threads:[~2014-10-29  1:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29  2:07 Ariel Rodriguez [this message]
2014-10-29  8:35 ` Thomas Monjalon
2014-10-29  8:42   ` Zhang, Helin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADoa0bbog5n7gsPU7013Jp8d584dCh_pT+w+pxCVtWMjnLkOGA@mail.gmail.com \
    --to=arodriguez@callistech.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).